Use good certificate (#148)

Author: kblok

CONTRIBUTING.md

@@ -18,8 +18,10 @@ The test server requires a self-signed certificate at this location: `.\lib\Pupp
 You can run this PowerShell script on Windows
 
 ```
-New-SelfSignedCertificate -Subject "puppeteer" -FriendlyName "Puppeteer" -CertStoreLocation "cert:\LocalMachine\My"
-Get-ChildItem -Path cert:\LocalMachine\my | where { $_.subject -eq "CN=puppeteer" } | Export-Certificate -FilePath .\lib\PuppeteerSharp.TestServer\testCert.cer
+New-SelfSignedCertificate -Subject "localhost" -FriendlyName "Puppeteer" -CertStoreLocation "cert:\CurrentUser\My"
+
+Get-ChildItem -Path cert:\CurrentUSer\my | where { $_.friendlyname -eq "Puppeteer" } | Export-Certificate -FilePath C:\projects\puppeteer-sharp\lib\PuppeteerSharp.TestServer\testCert.cer
+
 ```
 
 On MacOS, you can create an “SSL Client” certificate using the Keychain Access app and then export it to `.\lib\PuppeteerSharp.TestServer\testCert.cer`

appveyor.yml

@@ -0,0 +1,24 @@
+version: 1.0.{build}
+branches:
+  only:
+  - master
+image: Previous Visual Studio 2017
+configuration: Release
+before_build:
+- ps: >-
+    dotnet restore .\lib\PuppeteerSharp.sln
+    
+    New-SelfSignedCertificate -Subject "localhost" -FriendlyName "Puppeteer" -CertStoreLocation "cert:\CurrentUser\My"
+
+    Get-ChildItem -Path cert:\CurrentUSer\my | where { $_.friendlyname -eq "Puppeteer" } | Export-Certificate -FilePath C:\projects\puppeteer-sharp\lib\PuppeteerSharp.TestServer\testCert.cer
+
+build:
+  project: .\lib\PuppeteerSharp.sln
+  publish_nuget: true
+  include_nuget_references: true
+  verbosity: minimal
+test_script:
+- cmd: >-
+    cd .\lib\PuppeteerSharp.Tests
+
+    dotnet test -s test.runsettings

lib/PuppeteerSharp.TestServer/wwwroot/testCert.pem

@@ -34,7 +34,7 @@ public async Task ShouldFailWhenNavigatingToBadUrl()
             Assert.Contains("Cannot navigate to invalid URL", exception.Message);
         }
 
-        [Fact(Skip = "message is ERR_CERT_COMMON_NAME_INVALID instead of ERR_CERT_AUTHORITY_INVALID")]
+        [Fact]
         public async Task ShouldFailWhenNavigatingToBadSSL()
         {
             Page.RequestCreated += (sender, e) => Assert.NotNull(e.Request);
@@ -45,7 +45,7 @@ public async Task ShouldFailWhenNavigatingToBadSSL()
             Assert.Contains("net::ERR_CERT_AUTHORITY_INVALID", exception.Message);
         }
 
-        [Fact(Skip = "message is ERR_CERT_COMMON_NAME_INVALID instead of ERR_CERT_AUTHORITY_INVALID")]
+        [Fact]
         public async Task ShouldFailWhenNavigatingToBadSSLAfterRedirects()
         {
             var exception = await Assert.ThrowsAnyAsync<Exception>(async () => await Page.GoToAsync(TestConstants.HttpsPrefix + "/redirect/2.html"));