Round the clip dimensions (#896)

* Round the clip dimensions

* Update lib/PuppeteerSharp.Tests/ElementHandleTests/ScreenshotTests.cs

Co-Authored-By: Meir017 <[email protected]>

* Update lib/PuppeteerSharp/Page.cs

Co-Authored-By: Meir017 <[email protected]>

* Update lib/PuppeteerSharp/Page.cs

Co-Authored-By: Meir017 <[email protected]>

Author: Meir017

lib/PuppeteerSharp.Tests/ElementHandleTests/ScreenshotTests.cs

@@ -152,5 +152,23 @@ public async Task ShouldNotHangWithZeroWidthHeightElement()
             var exception = await Assert.ThrowsAsync<PuppeteerException>(elementHandle.ScreenshotDataAsync);
             Assert.Equal("Node has 0 height.", exception.Message);
         }
+
+        [Fact]
+        public async Task ShouldWorkForAnElementWithFractionalDimensions()
+        {
+            await Page.SetContentAsync("<div style=\"width:48.51px;height:19.8px;border:1px solid black;\"></div>");
+            var elementHandle = await Page.QuerySelectorAsync("div");
+            var screenshot = await elementHandle.ScreenshotDataAsync();
+            Assert.True(ScreenshotHelper.PixelMatch("screenshot-element-fractional.png", screenshot));
+        }
+
+        [Fact]
+        public async Task ShouldWorkForAnElementWithAnOffset()
+        {
+            await Page.SetContentAsync("<div style=\"position:absolute; top: 10.3px; left: 20.4px;width:50.3px;height:20.2px;border:1px solid black;\"></div>");
+            var elementHandle = await Page.QuerySelectorAsync("div");
+            var screenshot = await elementHandle.ScreenshotDataAsync();
+            Assert.True(ScreenshotHelper.PixelMatch("screenshot-element-fractional-offset.png", screenshot));
+        }
     }
 }

lib/PuppeteerSharp.Tests/Screenshots/screenshot-element-fractional-offset.png

@@ -1,7 +1,4 @@
-using System;
-using Newtonsoft.Json;
-
-namespace PuppeteerSharp.Media
+namespace PuppeteerSharp.Media
 {
     /// <summary>
     /// Clip data.
@@ -35,16 +32,5 @@ public class Clip
         /// </summary>
         /// <value>The scale.</value>
         public int Scale { get; internal set; }
-
-        internal Clip Clone()
-        {
-            return new Clip
-            {
-                X = X,
-                Y = Y,
-                Width = Width,
-                Height = Height
-            };
-        }
     }
 }

lib/PuppeteerSharp.Tests/Screenshots/screenshot-element-fractional.png

@@ -1640,11 +1640,7 @@ private async Task<string> PerformScreenshot(ScreenshotType type, ScreenshotOpti
                 }).ConfigureAwait(false);
             }
 
-            var clip = options.Clip?.Clone();
-            if (clip != null)
-            {
-                clip.Scale = 1;
-            }
+            var clip = options.Clip != null ? ProcessClip(options.Clip) : null;
 
             if (!_screenshotBurstModeOn)
             {
@@ -1743,6 +1739,21 @@ private async Task<string> PerformScreenshot(ScreenshotType type, ScreenshotOpti
             return result.Data;
         }
 
+        private Clip ProcessClip(Clip clip)
+        {
+            var x = Math.Round(clip.X);
+            var y = Math.Round(clip.Y);
+            
+            return new Clip
+            {
+                X = x,
+                Y = y,
+                Width = Math.Round(clip.Width + clip.X - x, MidpointRounding.AwayFromZero),
+                Height = Math.Round(clip.Height + clip.Y - y, MidpointRounding.AwayFromZero),
+                Scale = 1
+            };
+        }
+
         private Task ResetBackgroundColorAndViewportAsync(ScreenshotOptions options)
         {
             var omitBackgroundTask = options?.OmitBackground == true && options.Type == ScreenshotType.Png ?