Skip to content

Commit 33334a7

Browse files
authored
Fix Chrome version fetching (#2301)
1 parent 2ddf7d6 commit 33334a7

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

lib/PuppeteerSharp.Tests/Browsers/Chrome/ChromeDataTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.IO;
3+
using System.Threading.Tasks;
34
using NUnit.Framework;
45
using PuppeteerSharp.BrowserData;
56
using PuppeteerSharp.Nunit;
@@ -93,5 +94,9 @@ public void ShouldResolveSystemExecutablePath()
9394

9495
Assert.AreEqual("Canary is not supported", ex.Message);
9596
}
97+
98+
[Test]
99+
public async Task ShouldReturnLatestVersion()
100+
=> await BrowserData.Chrome.ResolveBuildIdAsync(ChromeReleaseChannel.Stable);
96101
}
97102
}

lib/PuppeteerSharp/BrowserData/Chrome.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.IO;
3+
using System.Linq;
34
using System.Threading.Tasks;
45

56
namespace PuppeteerSharp.BrowserData
@@ -76,7 +77,7 @@ internal static string ResolveSystemExecutablePath(Platform platform, ChromeRele
7677
{
7778
var data = await JsonUtils.GetAsync<ChromeGoodVersionsResult>("https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json").ConfigureAwait(false);
7879

79-
foreach (var channelKey in data.Channels.Keys)
80+
foreach (var channelKey in data.Channels.Keys.ToArray())
8081
{
8182
data.Channels[channelKey.ToUpperInvariant()] = data.Channels[channelKey]!;
8283
}

lib/PuppeteerSharp/PuppeteerSharp.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
<Description>Headless Browser .NET API</Description>
1313
<PackageId>PuppeteerSharp</PackageId>
1414
<PackageReleaseNotes></PackageReleaseNotes>
15-
<PackageVersion>11.0.3</PackageVersion>
16-
<ReleaseVersion>11.0.3</ReleaseVersion>
17-
<AssemblyVersion>11.0.3</AssemblyVersion>
18-
<FileVersion>11.0.3</FileVersion>
15+
<PackageVersion>11.0.4</PackageVersion>
16+
<ReleaseVersion>11.0.4</ReleaseVersion>
17+
<AssemblyVersion>11.0.4</AssemblyVersion>
18+
<FileVersion>11.0.4</FileVersion>
1919
<SynchReleaseVersion>false</SynchReleaseVersion>
2020
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
2121
<DebugType>embedded</DebugType>

0 commit comments

Comments
 (0)