Fix CDP Params could be null (#2935)

* Fix CDP Params could be null

* update analyzer

* analyzer fixes

* Update lib/PuppeteerSharp/Cdp/CdpCDPSession.cs

Author: kblok

lib/PuppeteerSharp/Cdp/CdpCDPSession.cs

@@ -130,7 +130,7 @@ internal void OnMessage(ConnectionResponse obj)
         {
             Connection.MessageQueue.Enqueue(callback, obj);
         }
-        else if (obj.Method != null)
+        else if (obj.Method is not null && obj.Params is not null)
         {
             // If the message was set to not wait for callback, the message won't be in the callbacks dictionary
             // And it might have no method set.

lib/PuppeteerSharp/ElementHandle.cs

@@ -241,7 +241,7 @@ public Task<IElementHandle[]> QuerySelectorAllAsync(string selector)
 
                 var (updatedSelector, queryHandler) = CustomQuerySelectorRegistry.GetQueryHandlerAndSelector(selector);
                 var result = new List<IElementHandle>();
-                await foreach (var item in queryHandler.QueryAllAsync(handle, updatedSelector))
+                await foreach (var item in queryHandler.QueryAllAsync(handle, updatedSelector).ConfigureAwait(false))
                 {
                     result.Add(item);
                 }

lib/PuppeteerSharp/Frame.cs

@@ -309,7 +309,7 @@ public async Task<ElementHandle> FrameElementAsync()
                 return document.querySelectorAll('iframe, frame');
             }").ConfigureAwait(false);
 
-            await foreach (var iframe in list.TransposeIterableHandleAsync())
+            await foreach (var iframe in list.TransposeIterableHandleAsync().ConfigureAwait(false))
             {
                 var frame = await iframe.ContentFrameAsync().ConfigureAwait(false);
                 if (frame?.Id == Id)

lib/PuppeteerSharp/PuppeteerHandleExtensions.cs

@@ -123,7 +123,7 @@ internal static RuntimeCallFunctionOnRequestArgumentValue FormatArgument(this IJ
                 throw new PuppeteerException("JSHandle is disposed!");
             }
 
-            if ((jSHandle as JSHandle).Realm != context.World)
+            if ((jSHandle as JSHandle)?.Realm != context.World)
             {
                 throw new PuppeteerException("JSHandles can be evaluated only in the context they were created!");
             }
@@ -162,7 +162,7 @@ internal static async IAsyncEnumerable<IElementHandle> TransposeIterableHandleAs
                 })();
             }").ConfigureAwait(false);
 
-            await foreach (var item in iterator.TransposeIteratorHandleAsync())
+            await foreach (var item in iterator.TransposeIteratorHandleAsync().ConfigureAwait(false))
             {
                 yield return item;
             }
@@ -211,7 +211,7 @@ internal static async Task<IEnumerable<IElementHandle>> FastTransposeIteratorHan
             var properties = await array.GetPropertiesAsync().ConfigureAwait(false);
 
             await array.DisposeAsync().ConfigureAwait(false);
-            return properties.Values.Where(handle => handle is IElementHandle).Cast<IElementHandle>();
+            return properties.Values.Where(h => h is IElementHandle).Cast<IElementHandle>();
         }
     }
 }

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -12,10 +12,10 @@
     <Description>Headless Browser .NET API</Description>
     <PackageId>PuppeteerSharp</PackageId>
     <PackageReleaseNotes></PackageReleaseNotes>
-    <PackageVersion>20.2.0</PackageVersion>
-    <ReleaseVersion>20.2.0</ReleaseVersion>
-    <AssemblyVersion>20.2.0</AssemblyVersion>
-    <FileVersion>20.2.0</FileVersion>
+    <PackageVersion>20.2.1</PackageVersion>
+    <ReleaseVersion>20.2.1</ReleaseVersion>
+    <AssemblyVersion>20.2.1</AssemblyVersion>
+    <FileVersion>20.2.1</FileVersion>
     <SynchReleaseVersion>false</SynchReleaseVersion>
     <StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
     <DebugType>embedded</DebugType>
@@ -29,7 +29,7 @@
   </PropertyGroup>
   <Import Project="../Common/CommonProps.props" />
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
+    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

lib/PuppeteerSharp/QueryHandlers/QueryHandler.cs

@@ -31,7 +31,7 @@ public string QuerySelectorAll
                 return _querySelectorAll;
             }
 
-            set
+            init
             {
                 _querySelectorAll = value;
             }
@@ -65,7 +65,7 @@ internal string QuerySelector
                 return _querySelector;
             }
 
-            set
+            init
             {
                 _querySelector = value;
             }
@@ -166,7 +166,7 @@ internal virtual async IAsyncEnumerable<IElementHandle> QueryAllAsync(IElementHa
                 new LazyArg(async context => await context.GetPuppeteerUtilAsync().ConfigureAwait(false)))
                 .ConfigureAwait(false);
 
-            await foreach (var item in handle.TransposeIterableHandleAsync())
+            await foreach (var item in handle.TransposeIterableHandleAsync().ConfigureAwait(false))
             {
                 yield return item;
             }