Changes to enforce error on SA1624 rule (#1888)

Co-authored-by: Mantas Valuckas <[email protected]>

Author: MantasVa

lib/PuppeteerSharp.ruleset

@@ -8,7 +8,7 @@
     <Rule Id="SA1309" Action="None" />
     <Rule Id="SX1309" Action="Error" />
 
-    <Rule Id="SA1624" Action="None" /> <!-- Error SA1624: Because the property only contains a visible get accessor, the documentation summary text should begin with 'Gets'. (SA1624)-->
+    <Rule Id="SA1624" Action="Error" /> <!-- Error SA1624: Because the property only contains a visible get accessor, the documentation summary text should begin with 'Gets'. (SA1624)-->
     <Rule Id="SA1028" Action="Error" /> <!-- Error SA1028: Code should not contain trailing whitespace (SA1028)-->
     <Rule Id="SA1600" Action="None" /> <!-- Error SA1600: Elements should be documented (SA1600)-->
     <Rule Id="SA1516" Action="Error" /> <!-- Error SA1516: Elements should be separated by blank line (SA1516)-->

lib/PuppeteerSharp/CDPSession.cs

@@ -82,7 +82,7 @@ internal CDPSession(Connection connection, TargetType targetType, string session
         internal event EventHandler<SessionAttachedEventArgs> SessionAttached;
 
         /// <summary>
-        /// Gets or sets a value indicating whether this <see cref="CDPSession"/> is closed.
+        /// Gets a value indicating whether this <see cref="CDPSession"/> is closed.
         /// </summary>
         /// <value><c>true</c> if is closed; otherwise, <c>false</c>.</value>
         public bool IsClosed { get; internal set; }

lib/PuppeteerSharp/Connection.cs

@@ -77,7 +77,7 @@ internal Connection(string url, int delay, bool enqueueAsyncMessages, IConnectio
         internal event EventHandler<SessionAttachedEventArgs> SessionAttached;
 
         /// <summary>
-        /// Gets or sets a value indicating whether this <see cref="Connection"/> is closed.
+        /// Gets a value indicating whether this <see cref="Connection"/> is closed.
         /// </summary>
         /// <value><c>true</c> if is closed; otherwise, <c>false</c>.</value>
         public bool IsClosed { get; internal set; }

lib/PuppeteerSharp/JSHandle.cs

@@ -29,7 +29,7 @@ internal JSHandle(ExecutionContext context, CDPSession client, RemoteObject remo
         /// <value>The execution context.</value>
         public ExecutionContext ExecutionContext { get; }
         /// <summary>
-        /// Gets or sets a value indicating whether this <see cref="JSHandle"/> is disposed.
+        /// Gets a value indicating whether this <see cref="JSHandle"/> is disposed.
         /// </summary>
         /// <value><c>true</c> if disposed; otherwise, <c>false</c>.</value>
         public bool Disposed { get; private set; }

lib/PuppeteerSharp/MessageEventArgs.cs

@@ -8,12 +8,12 @@ namespace PuppeteerSharp
     public class MessageEventArgs
     {
         /// <summary>
-        /// Gets or sets the message identifier.
+        /// Gets the message identifier.
         /// </summary>
         /// <value>The message identifier.</value>
         public string MessageID { get; internal set; }
         /// <summary>
-        /// Gets or sets the message data.
+        /// Gets the message data.
         /// </summary>
         /// <value>The message data.</value>
         public JToken MessageData { get; internal set; }

lib/PuppeteerSharp/Request.cs

@@ -69,22 +69,22 @@ internal Request(
         /// <value>The response.</value>
         public Response Response { get; internal set; }
         /// <summary>
-        /// Gets or sets the failure.
+        /// Gets the failure.
         /// </summary>
         /// <value>The failure.</value>
         public string Failure { get; internal set; }
         /// <summary>
-        /// Gets or sets the request identifier.
+        /// Gets the request identifier.
         /// </summary>
         /// <value>The request identifier.</value>
         public string RequestId { get; internal set; }
         /// <summary>
-        /// Gets or sets the interception identifier.
+        /// Gets the interception identifier.
         /// </summary>
         /// <value>The interception identifier.</value>
         public string InterceptionId { get; internal set; }
         /// <summary>
-        /// Gets or sets the type of the resource.
+        /// Gets the type of the resource.
         /// </summary>
         /// <value>The type of the resource.</value>
         public ResourceType ResourceType { get; internal set; }
@@ -98,22 +98,22 @@ internal Request(
         /// </summary>
         public bool IsNavigationRequest { get; }
         /// <summary>
-        /// Gets or sets the HTTP method.
+        /// Gets the HTTP method.
         /// </summary>
         /// <value>HTTP method.</value>
         public HttpMethod Method { get; internal set; }
         /// <summary>
-        /// Gets or sets the post data.
+        /// Gets the post data.
         /// </summary>
         /// <value>The post data.</value>
         public object PostData { get; internal set; }
         /// <summary>
-        /// Gets or sets the HTTP headers.
+        /// Gets the HTTP headers.
         /// </summary>
         /// <value>HTTP headers.</value>
         public Dictionary<string, string> Headers { get; internal set; }
         /// <summary>
-        /// Gets or sets the URL.
+        /// Gets the URL.
         /// </summary>
         /// <value>The URL.</value>
         public string Url { get; internal set; }

lib/PuppeteerSharp/RequestEventArgs.cs

@@ -11,9 +11,9 @@ namespace PuppeteerSharp
     public class RequestEventArgs : EventArgs
     {
         /// <summary>
-        /// Gets or sets the request.
+        /// Gets the request.
         /// </summary>
         /// <value>The request.</value>
         public Request Request { get; internal set; }
     }
-}
+}

lib/PuppeteerSharp/ResponseCreatedEventArgs.cs

@@ -8,9 +8,9 @@ namespace PuppeteerSharp
     public class ResponseCreatedEventArgs : EventArgs
     {
         /// <summary>
-        /// Gets or sets the response.
+        /// Gets the response.
         /// </summary>
         /// <value>The response.</value>
         public Response Response { get; internal set; }
     }
-}
+}

lib/PuppeteerSharp/TargetChangedArgs.cs

@@ -9,14 +9,14 @@ namespace PuppeteerSharp
     public class TargetChangedArgs
     {
         /// <summary>
-        /// Gets or sets the target info.
+        /// Gets the target info.
         /// </summary>
         /// <value>The target info.</value>
         public TargetInfo TargetInfo { get; internal set; }
         /// <summary>
-        /// Gets or sets the target.
+        /// Gets the target.
         /// </summary>
         /// <value>The target.</value>
         public Target Target { get; internal set; }
     }
-}
+}

lib/PuppeteerSharp/TargetInfo.cs

@@ -30,7 +30,7 @@ internal TargetInfo()
         [JsonProperty]
         public string TargetId { get; internal set; }
         /// <summary>
-        /// Gets or sets the target browser contextId
+        /// Gets the target browser contextId
         /// </summary>
         [JsonProperty]
         public string BrowserContextId { get; internal set; }
@@ -40,4 +40,4 @@ internal TargetInfo()
         [JsonProperty]
         public string OpenerId { get; internal set; }
     }
-}
+}