Allow for passing IJSHandle as argument to EvaluateFunctionAsync/EvaluateFunctionHandleAsync (#2038)

* Allow for passing IJSHandle as argument to EvaluateFunctionAsync/EvaluateFunctionHandleAsync

- Update ExecutionContext.FormatArgument to match IJSHandle instead of JSHandle
- Make RemoteObjectHelper class static
- Move JSHandle.FormatArgument to RemoteObjectHelper.FormatArgument (extension method)
- IJSHandle.RemoteObject fix xml doc

* Move FormatArgument from RemoteObjectHelper to PuppeteerHandleExtensions

Review feedback

Author: amaitland

lib/PuppeteerSharp/ExecutionContext.cs

@@ -196,7 +196,7 @@ private object FormatArgument(object arg)
 
                     break;
 
-                case JSHandle objectHandle:
+                case IJSHandle objectHandle:
                     return objectHandle.FormatArgument(this);
             }
 

lib/PuppeteerSharp/IJSHandle.cs

@@ -24,7 +24,7 @@ public interface IJSHandle : IAsyncDisposable
         IExecutionContext ExecutionContext { get; }
 
         /// <summary>
-        /// Gets or sets the remote object.
+        /// Gets the remote object.
         /// </summary>
         /// <value>The remote object.</value>
         RemoteObject RemoteObject { get; }

lib/PuppeteerSharp/JSHandle.cs

@@ -152,34 +152,5 @@ public Task<T> EvaluateFunctionAsync<T>(string script, params object[] args)
             list.Insert(0, this);
             return ExecutionContext.EvaluateFunctionAsync<T>(script, list.ToArray());
         }
-
-        internal object FormatArgument(ExecutionContext context)
-        {
-            if (ExecutionContext != context)
-            {
-                throw new PuppeteerException("JSHandles can be evaluated only in the context they were created!");
-            }
-
-            if (Disposed)
-            {
-                throw new PuppeteerException("JSHandle is disposed!");
-            }
-
-            var unserializableValue = RemoteObject.UnserializableValue;
-
-            if (unserializableValue != null)
-            {
-                return new { unserializableValue };
-            }
-
-            if (RemoteObject.ObjectId == null)
-            {
-                return new { RemoteObject.Value };
-            }
-
-            var objectId = RemoteObject.ObjectId;
-
-            return new { objectId };
-        }
     }
 }

lib/PuppeteerSharp/PuppeteerHandleExtensions.cs

@@ -112,5 +112,34 @@ public static async Task<T> EvaluateFunctionAsync<T>(this IJSHandle arrayHandle,
             await arrayHandle.DisposeAsync().ConfigureAwait(false);
             return result;
         }
+
+        internal static object FormatArgument(this IJSHandle jSHandle, ExecutionContext context)
+        {
+            if (jSHandle.Disposed)
+            {
+                throw new PuppeteerException("JSHandle is disposed!");
+            }
+
+            if (jSHandle.ExecutionContext != context)
+            {
+                throw new PuppeteerException("JSHandles can be evaluated only in the context they were created!");
+            }
+
+            var unserializableValue = jSHandle.RemoteObject.UnserializableValue;
+
+            if (unserializableValue != null)
+            {
+                return new { unserializableValue };
+            }
+
+            if (jSHandle.RemoteObject.ObjectId == null)
+            {
+                return new { jSHandle.RemoteObject.Value };
+            }
+
+            var objectId = jSHandle.RemoteObject.ObjectId;
+
+            return new { objectId };
+        }
     }
 }