Remove callback items (#641)

* Remove callback items

* 0 warnings policy

Author: kblok

lib/PuppeteerSharp.Tests/ConnectionTests/ConnectionTests.cs

@@ -23,6 +23,18 @@ public async Task ShouldThrowNiceErrors()
             Assert.Contains("ThisCommand.DoesNotExist", exception.Message);
         }
 
+        [Fact]
+        public async Task ShouldCleanCallbackList()
+        {
+            await Browser.GetVersionAsync();
+            await Browser.GetVersionAsync();
+            Assert.False(Browser.Connection.HasPendingCallbacks());
+
+            await Page.SetJavaScriptEnabledAsync(false);
+            await Page.SetJavaScriptEnabledAsync(true);
+            Assert.False(Page.Client.HasPendingCallbacks());
+        }
+
         private async Task TheSourceOfTheProblems()
         {
             await Page.Client.SendAsync("ThisCommand.DoesNotExist");

lib/PuppeteerSharp/CDPSession.cs

@@ -155,6 +155,8 @@ internal async Task<dynamic> SendAsync(string method, bool rawContent, dynamic a
         public Task DetachAsync()
             => Connection.SendAsync("Target.detachFromTarget", new { sessionId = SessionId });
 
+        internal bool HasPendingCallbacks() => _callbacks.Count != 0;
+
         #endregion
 
         #region Private Methods

lib/PuppeteerSharp/Connection.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using System.Net.WebSockets;
@@ -130,6 +131,8 @@ internal async Task<CDPSession> CreateSessionAsync(TargetInfo targetInfo)
             _sessions.Add(sessionId, session);
             return session;
         }
+
+        internal bool HasPendingCallbacks() => _callbacks.Count != 0;
         #endregion
 
         private void OnClose()
@@ -237,7 +240,7 @@ private void ProcessResponse(string response)
 
                 //If we get the object we are waiting for we return if
                 //if not we add this to the list, sooner or later some one will come for it 
-                if (_callbacks.TryGetValue(id, out var callback))
+                if (_callbacks.TryGetValue(id, out var callback) && _callbacks.Remove(id))
                 {
                     if (objAsJObject["error"] != null)
                     {

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -29,6 +29,13 @@
   <PropertyGroup>
     <LangVersion>7.1</LangVersion>
   </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <DebugType></DebugType>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.2" />
     <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />

lib/PuppeteerSharp/WaitTaskTimeoutException.cs

@@ -20,25 +20,47 @@ public class WaitTaskTimeoutException : PuppeteerException
         /// <value>The element.</value>
         public string ElementType { get; }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="PuppeteerSharp.WaitTaskTimeoutException"/> class.
+        /// </summary>
         public WaitTaskTimeoutException()
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="PuppeteerSharp.WaitTaskTimeoutException"/> class.
+        /// </summary>
+        /// <param name="message">Message.</param>
         public WaitTaskTimeoutException(string message) : base(message)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="PuppeteerSharp.WaitTaskTimeoutException"/> class.
+        /// </summary>
+        /// <param name="timeout">Timeout.</param>
+        /// <param name="elementType">Element type.</param>
         public WaitTaskTimeoutException(int timeout, string elementType) :
             base($"waiting for {elementType} failed: timeout {timeout}ms exceeded")
         {
             Timeout = timeout;
             ElementType = elementType;
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="PuppeteerSharp.WaitTaskTimeoutException"/> class.
+        /// </summary>
+        /// <param name="message">Message.</param>
+        /// <param name="innerException">Inner exception.</param>
         public WaitTaskTimeoutException(string message, Exception innerException) : base(message, innerException)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="PuppeteerSharp.WaitTaskTimeoutException"/> class.
+        /// </summary>
+        /// <param name="info">Info.</param>
+        /// <param name="context">Context.</param>
         protected WaitTaskTimeoutException(SerializationInfo info, StreamingContext context) : base(info, context)
         {
         }