BufferAsync should work with binaries (#766)

Author: kblok

lib/PuppeteerSharp.Tests/Issues/Issue0764.cs

@@ -0,0 +1,32 @@
+using System.Threading.Tasks;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace PuppeteerSharp.Tests.Issues
+{
+    [Collection("PuppeteerLoaderFixture collection")]
+    public class Issue0764 : PuppeteerPageBaseTest
+    {
+        public Issue0764(ITestOutputHelper output) : base(output)
+        {
+        }
+
+        [Fact]
+        public async Task BufferAsyncShouldWorkWithBinaries()
+        {
+            var tcs = new TaskCompletionSource<byte[]>();
+            Page.Response += async (sender, e) =>
+            {
+                if (e.Response.Url.Contains("digits/0.png"))
+                {
+                    tcs.TrySetResult(await e.Response.BufferAsync());
+                }
+            };
+
+            await Task.WhenAll(
+                Page.GoToAsync(TestConstants.ServerUrl + "/grid.html"),
+                tcs.Task);
+            Assert.True(ScreenshotHelper.PixelMatch("0.png", await tcs.Task));
+        }
+    }
+}

lib/PuppeteerSharp.Tests/Screenshots/0.png

@@ -15,7 +15,7 @@ public class Response
     {
         private readonly CDPSession _client;
         private readonly bool _fromDiskCache;
-        private string _buffer;
+        private byte[] _buffer;
 
         internal Response(
             CDPSession client,
@@ -112,7 +112,7 @@ internal Response(
         /// Returns a Task which resolves to a buffer with response body
         /// </summary>
         /// <returns>A Task which resolves to a buffer with response body</returns>
-        public async ValueTask<string> BufferAsync()
+        public async ValueTask<byte[]> BufferAsync()
         {
             if (_buffer == null)
             {
@@ -125,9 +125,9 @@ public async ValueTask<string> BufferAsync()
                         { MessageKeys.RequestId, Request.RequestId}
                     }).ConfigureAwait(false);
 
-                    _buffer = response.Base64Encoded
-                        ? Encoding.UTF8.GetString(Convert.FromBase64String(response.Body))
-                        : response.Body;
+                    _buffer = response.Base64Encoded
+                        ? Convert.FromBase64String(response.Body)
+                        : Encoding.UTF8.GetBytes(response.Body);
                 }
                 catch (Exception ex)
                 {
@@ -142,7 +142,7 @@ public async ValueTask<string> BufferAsync()
         /// Returns a Task which resolves to a text representation of response body
         /// </summary>
         /// <returns>A Task which resolves to a text representation of response body</returns>
-        public ValueTask<string> TextAsync() => BufferAsync();
+        public async ValueTask<string> TextAsync() => Encoding.UTF8.GetString(await BufferAsync().ConfigureAwait(false));
 
         /// <summary>
         /// Returns a Task which resolves to a <see cref="JObject"/> representation of response body