Skip to content

Commit 45c0926

Browse files
authored
Roll Chromium to r682225 (#1283)
1 parent cedaa0a commit 45c0926

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

lib/PuppeteerSharp.Tests/PuppeteerTests/HeadfulTests.cs

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ await page.EvaluateExpressionAsync(
8484
}
8585
}
8686

87-
[Fact]
87+
[Fact(Skip = "TODO: Support OOOPIF. @see https://github.com/GoogleChrome/puppeteer/issues/2548")]
8888
public async Task OOPIFShouldReportGoogleComFrame()
8989
{
9090
// https://google.com is isolated by default in Chromium embedder.
@@ -124,6 +124,20 @@ public async Task ShouldCloseBrowserWithBeforeunloadPage()
124124
}
125125
}
126126

127+
[Fact]
128+
public async Task ShouldOpenDevtoolsWhenDevtoolsTrueOptionIsGiven()
129+
{
130+
var headfulOptions = TestConstants.DefaultBrowserOptions();
131+
headfulOptions.Devtools = true;
132+
using (var browser = await Puppeteer.LaunchAsync(headfulOptions))
133+
{
134+
var context = await browser.CreateIncognitoBrowserContextAsync();
135+
await Task.WhenAll(
136+
context.NewPageAsync(),
137+
context.WaitForTargetAsync(target => target.Url.Contains("devtools://")));
138+
}
139+
}
140+
127141
[Fact]
128142
public async Task BringToFrontShouldWork()
129143
{

lib/PuppeteerSharp/BrowserFetcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class BrowserFetcher
3838
/// <summary>
3939
/// Default Chromium revision.
4040
/// </summary>
41-
public const int DefaultRevision = 674921;
41+
public const int DefaultRevision = 682225;
4242

4343
/// <summary>
4444
/// Gets the downloads folder.

lib/PuppeteerSharp/ChromiumProcess.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class ChromiumProcess : IDisposable
3131
"--disable-default-apps",
3232
"--disable-dev-shm-usage",
3333
"--disable-extensions",
34-
"--disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees",
34+
"--disable-features=TranslateUI,BlinkGenPropertyTrees",
3535
"--disable-hang-monitor",
3636
"--disable-ipc-flooding-protection",
3737
"--disable-popup-blocking",

0 commit comments

Comments
 (0)