IFrame.ChildFrames change from IEnumerable to IReadOnlyCollection (#2188)

Author: amaitland

lib/PuppeteerSharp.Tests/OOPIFTests/OOPIFTests.cs

@@ -38,7 +38,7 @@ await FrameUtils.AttachFrameAsync(
               TestConstants.CrossProcessHttpPrefix + "/empty.html"
             );
             await frameTask.WithTimeout();
-            Assert.Equal(2, Page.MainFrame.ChildFrames.Count());
+            Assert.Equal(2, Page.MainFrame.ChildFrames.Count);
         }
 
         [PuppeteerTest("oopif.spec.ts", "OOPIF", "should track navigations within OOP iframes")]

lib/PuppeteerSharp/Frame.cs

@@ -23,7 +23,7 @@ internal Frame(FrameManager frameManager, string frameId, string parentFrameId,
         }
 
         /// <inheritdoc/>
-        public IEnumerable<IFrame> ChildFrames => FrameManager.FrameTree.GetChildFrames(Id);
+        public IReadOnlyCollection<IFrame> ChildFrames => FrameManager.FrameTree.GetChildFrames(Id);
 
         /// <inheritdoc/>
         public string Name { get; private set; }

lib/PuppeteerSharp/FrameManager.cs

@@ -372,7 +372,7 @@ private async Task OnFrameNavigatedAsync(FramePayload framePayload)
             // Detach all child frames first.
             if (frame != null)
             {
-                while (frame.ChildFrames.Any())
+                while (frame.ChildFrames.Count > 0)
                 {
                     RemoveFramesRecursively(frame.ChildFrames.First() as Frame);
                 }

lib/PuppeteerSharp/IFrame.cs

@@ -41,7 +41,7 @@ public interface IFrame
         /// <summary>
         /// Gets the child frames of the this frame.
         /// </summary>
-        IEnumerable<IFrame> ChildFrames { get; }
+        IReadOnlyCollection<IFrame> ChildFrames { get; }
 
         /// <summary>
         /// Gets a value indicating if the frame is detached or not.