Handle negative area results in computeQuadArea (#756)

kblok · Meir017 · commit 5c7cc1afedfa · 2018-11-14T20:30:32.000+02:00
diff --git a/lib/PuppeteerSharp.TestServer/wwwroot/input/rotatedButton.html b/lib/PuppeteerSharp.TestServer/wwwroot/input/rotatedButton.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>Rotated button test</title>
+  </head>
+  <body>
+    <script src="mouse-helper.js"></script>
+    <button onclick="clicked();">Click target</button>
+    <style>
+      button {
+        transform: rotateY(180deg);
+      }
+    </style>
+    <script>
+      window.result = 'Was not clicked';
+      function clicked() {
+        result = 'Clicked';
+      }
+    </script>
+  </body>
+</html>
diff --git a/lib/PuppeteerSharp.Tests/InputTests/InputTests.cs b/lib/PuppeteerSharp.Tests/InputTests/InputTests.cs
@@ -395,6 +395,14 @@ await Page.EvaluateExpressionAsync(@"{
             Assert.Equal("Clicked", await Page.EvaluateExpressionAsync<string>("result"));
         }
 
+        [Fact]
+        public async Task ShouldClickARotatedButton()
+        {
+            await Page.GoToAsync(TestConstants.ServerUrl + "/input/rotatedButton.html");
+            await Page.ClickAsync("button");
+            Assert.Equal("Clicked", await Page.EvaluateExpressionAsync<string>("result"));
+        }
+
         [Fact]
         public async Task ShouldSelectTheTextWithMouse()
         {
diff --git a/lib/PuppeteerSharp/ElementHandle.cs b/lib/PuppeteerSharp/ElementHandle.cs
@@ -518,7 +518,7 @@ private decimal ComputeQuadArea(BoxModelPoint[] quad)
                 var p2 = quad[(i + 1) % quad.Length];
                 area += ((p1.X * p2.Y) - (p2.X * p1.Y)) / 2;
             }
-            return area;
+            return Math.Abs(area);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,14 @@ await Page.EvaluateExpressionAsync(@"{`
`395`	`395`	`Assert.Equal("Clicked", await Page.EvaluateExpressionAsync<string>("result"));`
`396`	`396`	`}`
`397`	`397`
	`398`	`+ [Fact]`
	`399`	`+ public async Task ShouldClickARotatedButton()`
	`400`	`+ {`
	`401`	`+ await Page.GoToAsync(TestConstants.ServerUrl + "/input/rotatedButton.html");`
	`402`	`+ await Page.ClickAsync("button");`
	`403`	`+ Assert.Equal("Clicked", await Page.EvaluateExpressionAsync<string>("result"));`
	`404`	`+ }`
	`405`	`+`
`398`	`406`	`[Fact]`
`399`	`407`	`public async Task ShouldSelectTheTextWithMouse()`
`400`	`408`	`{`
Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ private decimal ComputeQuadArea(BoxModelPoint[] quad)`
`518`	`518`	`var p2 = quad[(i + 1) % quad.Length];`
`519`	`519`	`area += ((p1.X * p2.Y) - (p2.X * p1.Y)) / 2;`
`520`	`520`	`}`
`521`		`- return area;`
	`521`	`+ return Math.Abs(area);`
`522`	`522`	`}`
`523`	`523`	`}`
`524`	`524`	`}`