Make Clip.Scale public (#1676)

* Make Clip.Scale public

* Default Scale to 1

Author: campersau

lib/PuppeteerSharp.Tests/PageTests/ScreenshotTests.cs

@@ -111,6 +111,32 @@ await page.SetViewportAsync(new ViewPortOptions
             }
         }
 
+        [Fact(Timeout = TestConstants.DefaultTestTimeout)]
+        public async Task ShouldClipScale()
+        {
+            await using (var page = await Context.NewPageAsync())
+            {
+                await page.SetViewportAsync(new ViewPortOptions
+                {
+                    Width = 500,
+                    Height = 500
+                });
+                await page.GoToAsync(TestConstants.ServerUrl + "/grid.html");
+                var screenshot = await page.ScreenshotDataAsync(new ScreenshotOptions
+                {
+                    Clip = new Clip
+                    {
+                        X = 50,
+                        Y = 100,
+                        Width = 150,
+                        Height = 100,
+                        Scale = 2
+                    }
+                });
+                Assert.True(ScreenshotHelper.PixelMatch("screenshot-clip-rect-scale.png", screenshot));
+            }
+        }
+
         [SkipBrowserFact(skipFirefox: true)]
         public async Task ShouldClipElementsToTheViewport()
         {

lib/PuppeteerSharp.Tests/Screenshots/golden-chromium/screenshot-clip-rect-scale.png

@@ -31,6 +31,6 @@ public class Clip
         /// Scale of the webpage rendering. Defaults to 1.
         /// </summary>
         /// <value>The scale.</value>
-        public int Scale { get; internal set; }
+        public int Scale { get; set; } = 1;
     }
-}
+}

lib/PuppeteerSharp.Tests/Screenshots/golden-firefox/screenshot-clip-rect-scale.png

@@ -2023,7 +2023,7 @@ private Clip ProcessClip(Clip clip)
                 Y = y,
                 Width = Math.Round(clip.Width + clip.X - x, MidpointRounding.AwayFromZero),
                 Height = Math.Round(clip.Height + clip.Y - y, MidpointRounding.AwayFromZero),
-                Scale = 1
+                Scale = clip.Scale
             };
         }