Launcher should not be static (#62)

We need to allow multiples chromium processors running at the same time

Author: kblok

lib/PuppeteerSharp/Launcher.cs

@@ -36,17 +36,13 @@ public class Launcher
             "--use-mock-keychain"
         };
 
-        private static bool _chromeClosed;
-        private static Process _chromeProcess;
-        private static string _temporaryUserDataDir = null;
-        private static Connection _connection = null;
-        private static Timer _timer = null;
+        private bool _chromeClosed;
+        private Process _chromeProcess;
+        private string _temporaryUserDataDir = null;
+        private Connection _connection = null;
+        private Timer _timer = null;
 
-        public Launcher()
-        {
-        }
-
-        internal static async Task<Browser> LaunchAsync(Dictionary<string, object> options, int chromiumRevision)
+        internal async Task<Browser> LaunchAsync(Dictionary<string, object> options, int chromiumRevision)
         {
             var chromeArguments = new List<string>(_defaultArgs);
 
@@ -141,7 +137,7 @@ internal static async Task<Browser> LaunchAsync(Dictionary<string, object> optio
 
         }
 
-        private static Task<string> WaitForEndpoint(Process chromeProcess, int timeout, bool dumpio)
+        private Task<string> WaitForEndpoint(Process chromeProcess, int timeout, bool dumpio)
         {
             var taskWrapper = new TaskCompletionSource<string>();
             var output = string.Empty;
@@ -199,14 +195,14 @@ private static Task<string> WaitForEndpoint(Process chromeProcess, int timeout,
             return taskWrapper.Task;
         }
 
-        private static void CleanUp()
+        private void CleanUp()
         {
             _timer?.Dispose();
             _timer = null;
             _chromeProcess?.RemoveExitedEvent();
         }
 
-        private static async Task KillChrome()
+        private async Task KillChrome()
         {
             if (!string.IsNullOrEmpty(_temporaryUserDataDir))
             {
@@ -218,7 +214,7 @@ private static async Task KillChrome()
             }
         }
 
-        private static async Task ForceKillChrome()
+        private async Task ForceKillChrome()
         {
             if (_chromeProcess.Id != 0 && Process.GetProcessById(_chromeProcess.Id) != null)
             {

lib/PuppeteerSharp/Puppeteer.cs

@@ -6,13 +6,9 @@ namespace PuppeteerSharp
 {
     public class Puppeteer
     {
-        public Puppeteer()
-        {
-        }
-
         public static async Task<Browser> LaunchAsync(Dictionary<string, object> options, int chromiumRevision)
         {
-            return await Launcher.LaunchAsync(options, chromiumRevision);
+            return await new Launcher().LaunchAsync(options, chromiumRevision);
         }
     }
 }