Fix dispose deadlock (#339)

Author: kblok

lib/PuppeteerSharp/Launcher.cs

@@ -54,6 +54,7 @@ public class Launcher
         private TaskCompletionSource<bool> _waitForChromeToClose;
         private bool _processLoaded;
         private bool _chromiumLaunched;
+        private object _isChromeCloseLock = new object();
         #endregion
 
         #region Properties
@@ -389,18 +390,19 @@ private void CleanUp()
 
         private async Task AfterProcessExit()
         {
-            if (IsChromeClosed)
+            lock (_isChromeCloseLock)
             {
-                return;
+                if (IsChromeClosed)
+                {
+                    return;
+                }
+                IsChromeClosed = true;
             }
-
             if (_options.LogProcess)
             {
                 _logger.LogInformation("Process Count: {ProcessCount}", Interlocked.Decrement(ref _processCount));
             }
 
-            IsChromeClosed = true;
-
             if (_temporaryUserDataDir != null)
             {
                 await TryDeleteUserDataDir();
@@ -417,6 +419,7 @@ private async Task KillChrome()
             if (!string.IsNullOrEmpty(_temporaryUserDataDir))
             {
                 ForceKillChrome();
+                await AfterProcessExit();
             }
             else if (_connection != null)
             {

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <PackOnBuild>true</PackOnBuild>
-    <PackageVersion>1.0.1</PackageVersion>
+    <PackageVersion>1.0.2</PackageVersion>
     <Authors>Darío Kondratiuk</Authors>
     <Owners>Darío Kondratiuk</Owners>
     <PackageProjectUrl>https://github.com/kblok/puppeteer-sharp</PackageProjectUrl>
@@ -12,6 +12,9 @@
     <Description>Headless Chrome .NET API</Description>
     <PackageId>PuppeteerSharp</PackageId>
     <PackageReleaseNotes>
+1.0.2
+==============
+* Fix Dispose deadlocks on ASP.NET MVC
 1.0.1
 ==============
 * Fix Chromium downloader on 32bits apps runnning on a x64 platform
@@ -60,7 +63,7 @@
  * PuppeteerSharp.DeviceDescriptors => PuppeteerSharp.Mobile.DeviceDescriptors
  * PuppeteerSharp.DeviceDescriptorName => PuppeteerSharp.Mobile.DeviceDescriptorName
     </PackageReleaseNotes>
-    <ReleaseVersion>1.0.1</ReleaseVersion>
+    <ReleaseVersion>1.0.2</ReleaseVersion>
     <SynchReleaseVersion>false</SynchReleaseVersion>
   </PropertyGroup>
   <PropertyGroup>