Detach client event handler when detaching IsolatedWorld (#2298)

jnyrup · web-flow · commit 670837693efe · 2023-08-30T15:38:02.000-03:00
diff --git a/lib/PuppeteerSharp/IsolatedWorld.cs b/lib/PuppeteerSharp/IsolatedWorld.cs
@@ -141,6 +141,7 @@ internal async Task<IJSHandle> AdoptHandleAsync(IJSHandle handle)
         internal void Detach()
         {
             _detached = true;
+            _client.MessageReceived -= Client_MessageReceived;
             TaskManager.TerminateAll(new Exception("waitForFunction failed: frame got detached."));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,7 @@ internal async Task<IJSHandle> AdoptHandleAsync(IJSHandle handle)`
`141`	`141`	`internal void Detach()`
`142`	`142`	`{`
`143`	`143`	`_detached = true;`
	`144`	`+ _client.MessageReceived -= Client_MessageReceived;`
`144`	`145`	`TaskManager.TerminateAll(new Exception("waitForFunction failed: frame got detached."));`
`145`	`146`	`}`
`146`	`147`