Skip to content

Commit 676e571

Browse files
committed
FIRST GREEN TEST
1 parent 5acb602 commit 676e571

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

lib/PuppeteerSharp.Tests/Puppeteer/PuppeteerLaunch.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public async Task should_support_ignoreHTTPSErrors_option()
3838
var page = await browser.NewPageAsync();
3939

4040
var response = await page.GoToAsync(HttpsPrefix + "/empty.html");
41-
Assert.Equals(response.ok, true);
41+
Assert.Equal(response.Status.ToString(), "OK");
4242

4343
browser.Close();
4444
}

lib/PuppeteerSharp/FrameManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void _client_MessageReceived(object sender, PuppeteerSharp.MessageEventArgs e)
7474

7575
private void OnLifeCycleEvent(MessageEventArgs e)
7676
{
77-
if (!Frames.ContainsKey(e.MessageData.frameId.ToString()))
77+
if (Frames.ContainsKey(e.MessageData.frameId.ToString()))
7878
{
7979
var frame = Frames[e.MessageData.frameId.ToString()];
8080

lib/PuppeteerSharp/NavigationWatcher.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,10 @@ void FrameManager_LifecycleEvent(object sender, FrameEventArgs e)
9292
return;
9393
}
9494

95-
LifeCycleCompleteTaskWrapper.SetResult(true);
95+
if (!LifeCycleCompleteTaskWrapper.Task.IsCompleted)
96+
{
97+
LifeCycleCompleteTaskWrapper.SetResult(true);
98+
}
9699
}
97100

98101
private bool CheckLifecycle(Frame frame, IEnumerable<string> expectedLifecycle)

0 commit comments

Comments
 (0)