Migrate tests to Nunit (#2276)

* Remove xunit collection

* Docs changes

* New nunit flow

* Remove xunit imports

* Replace Playwright.Xunit with Playwright.Nunit

* Docs changes

* Refactor skip browser

* Missing import fixes

* PuppeteerFact to PuppeteerTimeout

* Use ignore attribute

* Replace skip non windows

* Remove PuppeteerLoaderCollection

* Rename PuppeteerSharp.Xunit project to Nunit

* Replace packages

* Remove xunit constructor

* Replace Fact with test

* Replace InlineData with TestCase

* Remove theory attribute

* Use more PuppeteerTimeout

* Add some usings

* Assert.Equal to Assert.AreEqual

* Empty to IsEmpty

* Docs changes

* Same to AreSame

* Assert.Contains to StringAssert.Contains

* ThrowsAnyAsync to ThrowAsync

* Migrate .Single

* Remove async from Assert.ThrowsAsync

* sync test

* Migrate DoesNotContain

* NotEmpty to IsNotEmpty

* more usings

* cookies fix

* more usings

* async to sync

* Contains fixes

* sync

* more usings

* More of the same

* sync

* Improve task queue tests

* Fix TaskHelperTests

* Fix FrameManagementTests

* More simple things

* CloseTests fixes

* TargetTests fixes

* Small things

* Green build

* CodeFactor

* Fix QueryOneTests

* Fix WaitForSelectorAriaTests

* Fix CDPSession tests

* Fix some tests

* Fix mouse test

* Remove extra browser creation

* Fix tests with custom setups

* fix goto tests

* More fixes

* Codefactor

* Fix a wait task test

---------

Co-authored-by: GitHub Action <[email protected]>

Author: kblok

README.md

@@ -57,7 +57,7 @@ await using var page = await browser.NewPageAsync();
 await page.GoToAsync("http://www.google.com");
 await page.ScreenshotAsync(outputFile);
 ```
-<sup><a href='/lib/PuppeteerSharp.Tests/ScreenshotTests/PageScreenshotTests.cs#L63-L71' title='Snippet source file'>snippet source</a> | <a href='#snippet-screenshotasync' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/lib/PuppeteerSharp.Tests/ScreenshotTests/PageScreenshotTests.cs#L61-L69' title='Snippet source file'>snippet source</a> | <a href='#snippet-screenshotasync' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 You can also change the view port before generating the screenshot
@@ -71,7 +71,7 @@ await Page.SetViewportAsync(new ViewPortOptions
     Height = 500
 });
 ```
-<sup><a href='/lib/PuppeteerSharp.Tests/ScreenshotTests/ElementHandleScreenshotTests.cs#L21-L27' title='Snippet source file'>snippet source</a> | <a href='#snippet-setviewportasync' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/lib/PuppeteerSharp.Tests/ScreenshotTests/ElementHandleScreenshotTests.cs#L19-L25' title='Snippet source file'>snippet source</a> | <a href='#snippet-setviewportasync' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ### Generate PDF files
@@ -87,7 +87,7 @@ await page.GoToAsync("http://www.google.com"); // In case of fonts being loaded
 await page.EvaluateExpressionHandleAsync("document.fonts.ready"); // Wait for fonts to be loaded. Omitting this might result in no text rendered in pdf.
 await page.PdfAsync(outputFile);
 ```
-<sup><a href='/lib/PuppeteerSharp.Tests/PageTests/PdfTests.cs#L30-L40' title='Snippet source file'>snippet source</a> | <a href='#snippet-pdfasync' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/lib/PuppeteerSharp.Tests/PageTests/PdfTests.cs#L28-L38' title='Snippet source file'>snippet source</a> | <a href='#snippet-pdfasync' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ### Inject HTML
@@ -99,7 +99,7 @@ await using var page = await browser.NewPageAsync();
 await page.SetContentAsync("<div>My Receipt</div>");
 var result = await page.GetContentAsync();
 ```
-<sup><a href='/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs#L21-L27' title='Snippet source file'>snippet source</a> | <a href='#snippet-setcontentasync' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs#L19-L25' title='Snippet source file'>snippet source</a> | <a href='#snippet-setcontentasync' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ### Evaluate Javascript
@@ -112,7 +112,7 @@ var seven = await page.EvaluateExpressionAsync<int>("4 + 3");
 var someObject = await page.EvaluateFunctionAsync<dynamic>("(value) => ({a: value})", 5);
 Console.WriteLine(someObject.a);
 ```
-<sup><a href='/lib/PuppeteerSharp.Tests/QuerySelectorTests/ElementHandleQuerySelectorEvalTests.cs#L19-L24' title='Snippet source file'>snippet source</a> | <a href='#snippet-evaluate' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/lib/PuppeteerSharp.Tests/QuerySelectorTests/ElementHandleQuerySelectorEvalTests.cs#L17-L22' title='Snippet source file'>snippet source</a> | <a href='#snippet-evaluate' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ### Wait For Selector

lib/PuppeteerSharp.Xunit/PuppeteerSharp.Xunit.csproj renamed to lib/PuppeteerSharp.Nunit/PuppeteerSharp.Nunit.csproj

@@ -4,5 +4,8 @@
     <TargetFrameworks Condition="'$(OS)' == 'Windows_NT' ">net48;net6.0</TargetFrameworks>
     <TargetFrameworks Condition="'$(OS)' != 'Windows_NT' ">net6.0</TargetFrameworks>
 	</PropertyGroup>
+	<ItemGroup>
+	  <PackageReference Include="NUnit" Version="3.13.3" />
+	</ItemGroup>
 	<Import Project="../Common/SignAssembly.props" />
 </Project>

lib/PuppeteerSharp.Xunit/PuppeteerTestAttribute.cs renamed to lib/PuppeteerSharp.Nunit/PuppeteerTestAttribute.cs

@@ -1,12 +1,13 @@
 using System;
+using NUnit.Framework;
 
-namespace PuppeteerSharp.Xunit
+namespace PuppeteerSharp.Nunit
 {
     /// <summary>
     /// Enables decorating test facts with information about the corresponding test in the upstream repository.
     /// </summary>
     [AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
-    public class PuppeteerTestAttribute : Attribute
+    public class PuppeteerTestAttribute : TestAttribute
     {
         /// <summary>
         /// Creates a new instance of the attribute.

lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs

@@ -1,21 +1,19 @@
 using System.Threading.Tasks;
 using PuppeteerSharp.PageAccessibility;
 using PuppeteerSharp.Tests.Attributes;
-using PuppeteerSharp.Xunit;
-using Xunit;
-using Xunit.Abstractions;
+using PuppeteerSharp.Nunit;
+using NUnit.Framework;
 
 namespace PuppeteerSharp.Tests.AccesibilityTests
 {
-    [Collection(TestConstants.TestFixtureCollectionName)]
     public class AccesibilityTests : PuppeteerPageBaseTest
     {
-        public AccesibilityTests(ITestOutputHelper output) : base(output)
+        public AccesibilityTests(): base()
         {
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "should work")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldWork()
         {
             await Page.SetContentAsync(@"
@@ -114,17 +112,17 @@ await Page.SetContentAsync(@"
             };
             await Page.FocusAsync("[placeholder='Empty input']");
             var snapshot = await Page.Accessibility.SnapshotAsync();
-            Assert.Equal(nodeToCheck, snapshot);
+            Assert.AreEqual(nodeToCheck, snapshot);
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "should report uninteresting nodes")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldReportUninterestingNodes()
         {
             await Page.SetContentAsync("<textarea autofocus>hi</textarea>");
             await Page.FocusAsync("textarea");
 
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "textbox",
@@ -156,7 +154,7 @@ public async Task ShouldReportUninterestingNodes()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "roledescription")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task RoleDescription()
         {
             await Page.SetContentAsync("<div tabIndex=-1 aria-roledescription='foo'>Hi</div>");
@@ -166,25 +164,25 @@ public async Task RoleDescription()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "orientation")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task Orientation()
         {
             await Page.SetContentAsync("<a href='' role='slider' aria-orientation='vertical'>11</a>");
             var snapshot = await Page.Accessibility.SnapshotAsync();
-            Assert.Equal("vertical", snapshot.Children[0].Orientation);
+            Assert.AreEqual("vertical", snapshot.Children[0].Orientation);
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "autocomplete")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task AutoComplete()
         {
             await Page.SetContentAsync("<input type='number' aria-autocomplete='list' />");
             var snapshot = await Page.Accessibility.SnapshotAsync();
-            Assert.Equal("list", snapshot.Children[0].AutoComplete);
+            Assert.AreEqual("list", snapshot.Children[0].AutoComplete);
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "multiselectable")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task MultiSelectable()
         {
             await Page.SetContentAsync("<div role='grid' tabIndex=-1 aria-multiselectable=true>hey</div>");
@@ -193,24 +191,24 @@ public async Task MultiSelectable()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "Accessibility", "keyshortcuts")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task KeyShortcuts()
         {
             await Page.SetContentAsync("<div role='grid' tabIndex=-1 aria-keyshortcuts='foo'>hey</div>");
             var snapshot = await Page.Accessibility.SnapshotAsync();
-            Assert.Equal("foo", snapshot.Children[0].KeyShortcuts);
+            Assert.AreEqual("foo", snapshot.Children[0].KeyShortcuts);
         }
 
         [PuppeteerTest("accessibility.spec.ts", "filtering children of leaf nodes", "should not report text nodes inside controls")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldNotReportTextNodesInsideControls()
         {
             await Page.SetContentAsync(@"
             <div role='tablist'>
                 <div role='tab' aria-selected='true'><b>Tab1</b></div>
                 <div role='tab'>Tab2</div>
             </div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "RootWebArea",
@@ -234,14 +232,14 @@ await Page.SetContentAsync(@"
         }
 
         [PuppeteerTest("accessibility.spec.ts", "filtering children of leaf nodes", "rich text editable fields should have children")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task RichTextEditableFieldsShouldHaveChildren()
         {
             await Page.SetContentAsync(@"
             <div contenteditable='true'>
                 Edit this image: <img src='fakeimage.png' alt='my fake image'>
             </div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "generic",
@@ -265,14 +263,14 @@ await Page.SetContentAsync(@"
         }
 
         [PuppeteerTest("accessibility.spec.ts", "filtering children of leaf nodes", "rich text editable fields with role should have children")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task RichTextEditableFieldsWithRoleShouldHaveChildren()
         {
             await Page.SetContentAsync(@"
             <div contenteditable='true' role='textbox'>
                 Edit this image: <img src='fakeimage.png' alt='my fake image'>
             </div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "textbox",
@@ -292,11 +290,11 @@ await Page.SetContentAsync(@"
         }
 
         [PuppeteerTest("accessibility.spec.ts", "plaintext contenteditable", "plain text field with role should not have children")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task PlainTextFieldWithRoleShouldNotHaveChildren()
         {
             await Page.SetContentAsync("<div contenteditable='plaintext-only' role='textbox'>Edit this image:<img src='fakeimage.png' alt='my fake image'></div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "textbox",
@@ -308,26 +306,26 @@ public async Task PlainTextFieldWithRoleShouldNotHaveChildren()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "plaintext contenteditable", "plain text field with tabindex and without role should not have content")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task PlainTextFieldWithoutRoleShouldNotHaveContent()
         {
             await Page.SetContentAsync(
                 "<div contenteditable='plaintext-only'>Edit this image:<img src='fakeimage.png' alt='my fake image'></div>");
             var snapshot = await Page.Accessibility.SnapshotAsync();
-            Assert.Equal("generic", snapshot.Children[0].Role);
-            Assert.Equal(string.Empty, snapshot.Children[0].Name);
+            Assert.AreEqual("generic", snapshot.Children[0].Role);
+            Assert.AreEqual(string.Empty, snapshot.Children[0].Name);
         }
 
         [PuppeteerTest("accessibility.spec.ts", "filtering children of leaf nodes", "non editable textbox with role and tabIndex and label should not have children")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task NonEditableTextboxWithRoleAndTabIndexAndLabelShouldNotHaveChildren()
         {
             await Page.SetContentAsync(@"
             <div role='textbox' tabIndex=0 aria-checked='true' aria-label='my favorite textbox'>
                 this is the inner content
                 <img alt='yo' src='fakeimg.png'>
             </div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "textbox",
@@ -338,15 +336,15 @@ this is the inner content
         }
 
         [PuppeteerTest("accessibility.spec.ts", "filtering children of leaf nodes", "checkbox with and tabIndex and label should not have children")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task CheckboxWithAndTabIndexAndLabelShouldNotHaveChildren()
         {
             await Page.SetContentAsync(@"
             <div role='checkbox' tabIndex=0 aria-checked='true' aria-label='my favorite checkbox'>
                 this is the inner content
                 <img alt='yo' src='fakeimg.png'>
             </div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "checkbox",
@@ -357,15 +355,15 @@ this is the inner content
         }
 
         [PuppeteerTest("accessibility.spec.ts", "filtering children of leaf nodes", "checkbox without label should not have children")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task CheckboxWithoutLabelShouldNotHaveChildren()
         {
             await Page.SetContentAsync(@"
             <div role='checkbox' aria-checked='true'>
                 this is the inner content
                 <img alt='yo' src='fakeimg.png'>
             </div>");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "checkbox",

lib/PuppeteerSharp.Tests/AccessibilityTests/RootOptionTests.cs

@@ -1,27 +1,25 @@
 using System.Threading.Tasks;
 using PuppeteerSharp.PageAccessibility;
 using PuppeteerSharp.Tests.Attributes;
-using PuppeteerSharp.Xunit;
-using Xunit;
-using Xunit.Abstractions;
+using PuppeteerSharp.Nunit;
+using NUnit.Framework;
 
 namespace PuppeteerSharp.Tests.AccesibilityTests
 {
-    [Collection(TestConstants.TestFixtureCollectionName)]
     public class RootOptionTests : PuppeteerPageBaseTest
     {
-        public RootOptionTests(ITestOutputHelper output) : base(output)
+        public RootOptionTests(): base()
         {
         }
 
         [PuppeteerTest("accessibility.spec.ts", "root option", "should work a button")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldWorkAButton()
         {
             await Page.SetContentAsync("<button>My Button</button>");
 
             var button = await Page.QuerySelectorAsync("button");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "button",
@@ -31,13 +29,13 @@ public async Task ShouldWorkAButton()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "root option", "should work an input")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldWorkAnInput()
         {
             await Page.SetContentAsync("<input title='My Input' value='My Value'>");
 
             var input = await Page.QuerySelectorAsync("input");
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "textbox",
@@ -48,7 +46,7 @@ public async Task ShouldWorkAnInput()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "root option", "should work a menu")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldWorkAMenu()
         {
             await Page.SetContentAsync(@"
@@ -86,11 +84,11 @@ await Page.SetContentAsync(@"
                     }
             };
 
-            Assert.Equal(nodeToCheck, snapshot);
+            Assert.AreEqual(nodeToCheck, snapshot);
         }
 
         [PuppeteerTest("accessibility.spec.ts", "root option", "should return null when the element is no longer in DOM")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldReturnNullWhenTheElementIsNoLongerInDOM()
         {
             await Page.SetContentAsync("<button>My Button</button>");
@@ -100,7 +98,7 @@ public async Task ShouldReturnNullWhenTheElementIsNoLongerInDOM()
         }
 
         [PuppeteerTest("accessibility.spec.ts", "root option", "should support the interestingOnly option")]
-        [SkipBrowserFact(skipFirefox: true)]
+        [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldSupportTheInterestingOnlyOption()
         {
             await Page.SetContentAsync("<div><button>My Button</button></div>");
@@ -109,7 +107,7 @@ public async Task ShouldSupportTheInterestingOnlyOption()
             {
                 Root = div
             }));
-            Assert.Equal(
+            Assert.AreEqual(
                 new SerializedAXNode
                 {
                     Role = "generic",