Expose browser context Id (#2029)

* Expose browser context Id

* do not fail fast

Author: kblok

.github/workflows/dotnet.yml

@@ -20,6 +20,7 @@ jobs:
     name: build-${{ matrix.browser }}/${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest]
         browser: [FIREFOX,CHROME]

lib/PuppeteerSharp.Tests/BrowserContextTests/BrowserContextTests.cs

@@ -1,7 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using System.Threading.Tasks;
 using PuppeteerSharp.Tests.Attributes;
 using PuppeteerSharp.Xunit;
@@ -159,6 +157,19 @@ public async Task ShouldWorkAcrossSessions()
             await context.CloseAsync();
         }
 
+        [PuppeteerTest("browsercontext.spec.ts", "BrowserContext", "should provide a context id")]
+        [SkipBrowserFact(skipFirefox: true)]
+        public async Task ShouldProvideAContextId()
+        {
+            Assert.Single(Browser.BrowserContexts());
+            Assert.Null(Browser.BrowserContexts()[0].Id);
+
+            var context = await Browser.CreateIncognitoBrowserContextAsync();
+            Assert.Equal(2, Browser.BrowserContexts().Length);
+            Assert.NotNull(Browser.BrowserContexts()[1].Id);
+            await context.CloseAsync();
+        }
+
         [PuppeteerTest("browsercontext.spec.ts", "BrowserContext", "should wait for a target")]
         [SkipBrowserFact(skipFirefox: true)]
         public async Task ShouldWaitForTarget()

lib/PuppeteerSharp/BrowserContext.cs

@@ -10,13 +10,12 @@ namespace PuppeteerSharp
     public class BrowserContext : IBrowserContext
     {
         private readonly Connection _connection;
-        private readonly string _id;
 
         internal BrowserContext(Connection connection, Browser browser, string contextId)
         {
             _connection = connection;
             Browser = browser;
-            _id = contextId;
+            Id = contextId;
         }
 
         /// <inheritdoc/>
@@ -29,7 +28,10 @@ internal BrowserContext(Connection connection, Browser browser, string contextId
         public event EventHandler<TargetChangedArgs> TargetDestroyed;
 
         /// <inheritdoc/>
-        public bool IsIncognito => _id != null;
+        public string Id { get; }
+
+        /// <inheritdoc/>
+        public bool IsIncognito => Id != null;
 
         /// <inheritdoc/>
         public Browser Browser { get; }
@@ -51,33 +53,33 @@ public async Task<IPage[]> PagesAsync()
             .Where(p => p != null).ToArray();
 
         /// <inheritdoc/>
-        public Task<IPage> NewPageAsync() => Browser.CreatePageInContextAsync(_id);
+        public Task<IPage> NewPageAsync() => Browser.CreatePageInContextAsync(Id);
 
         /// <inheritdoc/>
         public Task CloseAsync()
         {
-            if (_id == null)
+            if (Id == null)
             {
                 throw new PuppeteerException("Non-incognito profiles cannot be closed!");
             }
 
-            return Browser.DisposeContextAsync(_id);
+            return Browser.DisposeContextAsync(Id);
         }
 
         /// <inheritdoc/>
         public Task OverridePermissionsAsync(string origin, IEnumerable<OverridePermission> permissions)
             => _connection.SendAsync("Browser.grantPermissions", new BrowserGrantPermissionsRequest
             {
                 Origin = origin,
-                BrowserContextId = _id,
+                BrowserContextId = Id,
                 Permissions = permissions.ToArray(),
             });
 
         /// <inheritdoc/>
         public Task ClearPermissionOverridesAsync()
             => _connection.SendAsync("Browser.resetPermissions", new BrowserResetPermissionsRequest
             {
-                BrowserContextId = _id,
+                BrowserContextId = Id,
             });
 
         internal void OnTargetCreated(Browser browser, TargetChangedArgs args) => TargetCreated?.Invoke(browser, args);

lib/PuppeteerSharp/IBrowserContext.cs

@@ -25,6 +25,11 @@ public interface IBrowserContext
         /// </summary>
         event EventHandler<TargetChangedArgs> TargetDestroyed;
 
+        /// <summary>
+        /// Browser Context Id
+        /// </summary>
+        string Id { get; }
+
         /// <summary>
         /// Gets the browser this browser context belongs to
         /// </summary>