Roll Chromium to r705776 (#1318)

kblok · web-flow · commit 74488cf1760b · 2019-11-02T11:15:17.000-03:00
* Roll Chromium to r705776

* Add missing replacements

* Add some logs

* Init children

* Add xml doc

* Add logs

* Force focus
diff --git a/lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs b/lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs
@@ -1,4 +1,6 @@
-﻿using System.Threading.Tasks;
+﻿using System;
+using System.Threading.Tasks;
+using Newtonsoft.Json;
 using PuppeteerSharp.PageAccessibility;
 using Xunit;
 using Xunit.Abstractions;
@@ -35,12 +37,12 @@ await Page.SetContentAsync(@"
                     <option>Second Option</option>
                 </select>
             </body>");
-            Assert.Equal(
-                new SerializedAXNode
-                {
-                    Role = "WebArea",
-                    Name = "Accessibility Test",
-                    Children = new SerializedAXNode[]
+
+            var nodeToCheck = new SerializedAXNode
+            {
+                Role = "WebArea",
+                Name = "Accessibility Test",
+                Children = new SerializedAXNode[]
                     {
                         new SerializedAXNode
                         {
@@ -107,14 +109,18 @@ await Page.SetContentAsync(@"
                             }
                         }
                     }
-                },
-                await Page.Accessibility.SnapshotAsync());
+            };
+            await Page.FocusAsync("[placeholder='Empty input']");
+            var snapshot = await Page.Accessibility.SnapshotAsync();
+            Assert.Equal(nodeToCheck, snapshot);
         }
 
         [Fact]
         public async Task ShouldReportUninterestingNodes()
         {
             await Page.SetContentAsync("<textarea autofocus>hi</textarea>");
+            await Page.FocusAsync("textarea");
+
             Assert.Equal(
                 new SerializedAXNode
                 {
diff --git a/lib/PuppeteerSharp.Tests/NetworkTests/SetRequestInterceptionTests.cs b/lib/PuppeteerSharp.Tests/NetworkTests/SetRequestInterceptionTests.cs
@@ -198,7 +198,7 @@ public async Task ShouldWorkWithRedirectInsideSyncXHR()
         }
 
         [Fact]
-        public async Task ShouldWorksWithCustomizingRefererHeaders()
+        public async Task ShouldWorkWithCustomRefererHeaders()
         {
             await Page.SetExtraHttpHeadersAsync(new Dictionary<string, string>
             {
diff --git a/lib/PuppeteerSharp.Tests/PageTests/GotoTests.cs b/lib/PuppeteerSharp.Tests/PageTests/GotoTests.cs
@@ -153,7 +153,7 @@ public async Task ShouldFailWhenExceedingMaximumNavigationTimeout()
 
             var exception = await Assert.ThrowsAnyAsync<Exception>(async ()
                 => await Page.GoToAsync(TestConstants.EmptyPage, new NavigationOptions { Timeout = 1 }));
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
@@ -163,7 +163,7 @@ public async Task ShouldFailWhenExceedingDefaultMaximumNavigationTimeout()
 
             Page.DefaultNavigationTimeout = 1;
             var exception = await Assert.ThrowsAnyAsync<Exception>(async () => await Page.GoToAsync(TestConstants.EmptyPage));
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
@@ -173,7 +173,7 @@ public async Task ShouldFailWhenExceedingDefaultMaximumTimeout()
             Server.SetRoute("/empty.html", context => Task.Delay(-1));
             Page.DefaultTimeout = 1;
             var exception = await Assert.ThrowsAnyAsync<Exception>(async () => await Page.GoToAsync(TestConstants.EmptyPage));
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
@@ -184,7 +184,7 @@ public async Task ShouldPrioritizeDefaultNavigationTimeoutOverDefaultTimeout()
             Page.DefaultTimeout = 0;
             Page.DefaultNavigationTimeout = 1;
             var exception = await Assert.ThrowsAnyAsync<Exception>(async () => await Page.GoToAsync(TestConstants.EmptyPage));
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
diff --git a/lib/PuppeteerSharp.Tests/PageTests/ScreenshotTests.cs b/lib/PuppeteerSharp.Tests/PageTests/ScreenshotTests.cs
@@ -90,31 +90,6 @@ await page.SetViewportAsync(new ViewPortOptions
             }
         }
 
-        [Fact]
-        public async Task ShouldWorkForOffscreenClip()
-        {
-            using (var page = await Context.NewPageAsync())
-            {
-                await page.SetViewportAsync(new ViewPortOptions
-                {
-                    Width = 500,
-                    Height = 500
-                });
-                await page.GoToAsync(TestConstants.ServerUrl + "/grid.html");
-                var screenshot = await page.ScreenshotDataAsync(new ScreenshotOptions
-                {
-                    Clip = new Clip
-                    {
-                        X = 50,
-                        Y = 600,
-                        Width = 100,
-                        Height = 100
-                    }
-                });
-                Assert.True(ScreenshotHelper.PixelMatch("screenshot-offscreen-clip.png", screenshot));
-            }
-        }
-
         [Fact]
         public async Task ShouldRunInParallel()
         {
diff --git a/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs b/lib/PuppeteerSharp.Tests/PageTests/SetContentTests.cs
@@ -59,7 +59,7 @@ public async Task ShouldRespectTimeout()
                     Timeout = 1
                 }));
 
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
@@ -73,7 +73,7 @@ public async Task ShouldRespectDefaultTimeout()
             var exception = await Assert.ThrowsAnyAsync<TimeoutException>(async () =>
                 await Page.SetContentAsync($"<img src='{TestConstants.ServerUrl + imgPath}'></img>"));
 
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
diff --git a/lib/PuppeteerSharp.Tests/PageTests/WaitForRequestTests.cs b/lib/PuppeteerSharp.Tests/PageTests/WaitForRequestTests.cs
@@ -57,7 +57,7 @@ public async Task ShouldRespectTimeout()
                     Timeout = 1
                 }));
 
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
@@ -68,7 +68,7 @@ public async Task ShouldRespectDefaultTimeout()
             var exception = await Assert.ThrowsAnyAsync<TimeoutException>(async () =>
                 await Page.WaitForRequestAsync(request => false));
 
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
diff --git a/lib/PuppeteerSharp.Tests/PageTests/WaitForResponseTests.cs b/lib/PuppeteerSharp.Tests/PageTests/WaitForResponseTests.cs
@@ -57,7 +57,7 @@ public async Task ShouldRespectTimeout()
                     Timeout = 1
                 }));
 
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
@@ -68,7 +68,7 @@ public async Task ShouldRespectDefaultTimeout()
             var exception = await Assert.ThrowsAnyAsync<TimeoutException>(async () =>
                 await Page.WaitForResponseAsync(request => false));
 
-            Assert.Contains("Timeout Exceeded: 1ms", exception.Message);
+            Assert.Contains("Timeout of 1 ms exceeded", exception.Message);
         }
 
         [Fact]
diff --git a/lib/PuppeteerSharp.Tests/Screenshots/screenshot-offscreen-clip.png b/lib/PuppeteerSharp.Tests/Screenshots/screenshot-offscreen-clip.png
diff --git a/lib/PuppeteerSharp/BrowserFetcher.cs b/lib/PuppeteerSharp/BrowserFetcher.cs
@@ -38,7 +38,7 @@ public class BrowserFetcher
         /// <summary>
         /// Default Chromium revision.
         /// </summary>
-        public const int DefaultRevision = 686378;
+        public const int DefaultRevision = 706915;
 
         /// <summary>
         /// Gets the downloads folder.
diff --git a/lib/PuppeteerSharp/Helpers/TaskHelper.cs b/lib/PuppeteerSharp/Helpers/TaskHelper.cs
@@ -10,7 +10,7 @@ namespace PuppeteerSharp.Helpers
     public static class TaskHelper
     {
         private static readonly Func<TimeSpan, Exception> DefaultExceptionFactory =
-            timeout => new TimeoutException($"Timeout Exceeded: {timeout.TotalMilliseconds}ms exceeded");
+            timeout => new TimeoutException($"Timeout of {timeout.TotalMilliseconds} ms exceeded");
 
         //Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
         /// <summary>
diff --git a/lib/PuppeteerSharp/Page.cs b/lib/PuppeteerSharp/Page.cs
@@ -1543,7 +1543,7 @@ void requestEventListener(object sender, RequestEventArgs e)
             await Task.WhenAny(requestTcs.Task, SessionClosedTask).WithTimeout(timeout, t =>
             {
                 FrameManager.NetworkManager.Request -= requestEventListener;
-                return new TimeoutException($"Timeout Exceeded: {t.TotalMilliseconds}ms exceeded");
+                return new TimeoutException($"Timeout of {t.TotalMilliseconds} ms exceeded");
             }).ConfigureAwait(false);
 
             if (SessionClosedTask.IsFaulted)
diff --git a/lib/PuppeteerSharp/PageAccessibility/AXNode.cs b/lib/PuppeteerSharp/PageAccessibility/AXNode.cs
@@ -18,6 +18,7 @@ internal class AXNode
         private readonly bool _richlyEditable;
         private readonly bool _editable;
         private readonly bool _expanded;
+        private readonly bool _hidden;
         private bool? _cachedHasFocusableChild;
 
         public AXNode(AccessibilityGetFullAXTreeResponse.AXTreeNode payload)
@@ -31,6 +32,7 @@ public AXNode(AccessibilityGetFullAXTreeResponse.AXTreeNode payload)
             _richlyEditable = payload.Properties.FirstOrDefault(p => p.Name == "editable")?.Value.Value.ToObject<string>() == "richtext";
             _editable |= _richlyEditable;
             _expanded = payload.Properties.FirstOrDefault(p => p.Name == "expanded")?.Value.Value.ToObject<bool>() == true;
+            _hidden = payload.Properties.FirstOrDefault(p => p.Name == "hidden")?.Value.Value.ToObject<bool>() == true;
             Focusable = payload.Properties.FirstOrDefault(p => p.Name == "focusable")?.Value.Value.ToObject<bool>() == true;
         }
 
@@ -166,7 +168,7 @@ internal bool IsControl()
 
         internal bool IsInteresting(bool insideControl)
         {
-            if (_role == "Ignored")
+            if (_role == "Ignored" || _hidden)
             {
                 return false;
             }
diff --git a/lib/PuppeteerSharp/PageAccessibility/SerializedAXNode.cs b/lib/PuppeteerSharp/PageAccessibility/SerializedAXNode.cs
@@ -8,6 +8,11 @@ namespace PuppeteerSharp.PageAccessibility
     /// </summary>
     public class SerializedAXNode : IEquatable<SerializedAXNode>
     {
+        /// <summary>
+        /// Creates a new serialized node
+        /// </summary>
+        public SerializedAXNode() => Children = new SerializedAXNode[] { };
+
         /// <summary>
         /// The <see fref="https://www.w3.org/TR/wai-aria/#usage_intro">role</see>.
         /// </summary>
diff --git a/lib/PuppeteerSharp/PuppeteerException.cs b/lib/PuppeteerSharp/PuppeteerException.cs
@@ -40,7 +40,7 @@ protected PuppeteerException(SerializationInfo info, StreamingContext context) :
         }
 
         internal static string RewriteErrorMeesage(string message)
-            => message.Contains("Cannot find context with specified id")
+            => message.Contains("Cannot find context with specified id") || message.Contains("Inspected target navigated or close")
                 ? "Execution context was destroyed, most likely because of a navigation."
                 : message;
     }
diff --git a/lib/PuppeteerSharp/WaitTaskTimeoutException.cs b/lib/PuppeteerSharp/WaitTaskTimeoutException.cs
@@ -41,7 +41,7 @@ public WaitTaskTimeoutException(string message) : base(message)
         /// <param name="timeout">Timeout.</param>
         /// <param name="elementType">Element type.</param>
         public WaitTaskTimeoutException(int timeout, string elementType) :
-            base($"waiting for {elementType} failed: timeout {timeout}ms exceeded")
+            base($"waiting for {elementType} failed: timeout {timeout} ms exceeded")
         {
             Timeout = timeout;
             ElementType = elementType;

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ public async Task ShouldWorkWithRedirectInsideSyncXHR()`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`[Fact]`
`201`		`- public async Task ShouldWorksWithCustomizingRefererHeaders()`
	`201`	`+ public async Task ShouldWorkWithCustomRefererHeaders()`
`202`	`202`	`{`
`203`	`203`	`await Page.SetExtraHttpHeadersAsync(new Dictionary<string, string>`
`204`	`204`	`{`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public async Task ShouldRespectTimeout()`
`59`	`59`	`Timeout = 1`
`60`	`60`	`}));`
`61`	`61`
`62`		`- Assert.Contains("Timeout Exceeded: 1ms", exception.Message);`
	`62`	`+ Assert.Contains("Timeout of 1 ms exceeded", exception.Message);`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`[Fact]`
`@@ -73,7 +73,7 @@ public async Task ShouldRespectDefaultTimeout()`
`73`	`73`	`var exception = await Assert.ThrowsAnyAsync<TimeoutException>(async () =>`
`74`	`74`	`await Page.SetContentAsync($"<img src='{TestConstants.ServerUrl + imgPath}'></img>"));`
`75`	`75`
`76`		`- Assert.Contains("Timeout Exceeded: 1ms", exception.Message);`
	`76`	`+ Assert.Contains("Timeout of 1 ms exceeded", exception.Message);`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public async Task ShouldRespectTimeout()`
`57`	`57`	`Timeout = 1`
`58`	`58`	`}));`
`59`	`59`
`60`		`- Assert.Contains("Timeout Exceeded: 1ms", exception.Message);`
	`60`	`+ Assert.Contains("Timeout of 1 ms exceeded", exception.Message);`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`[Fact]`
`@@ -68,7 +68,7 @@ public async Task ShouldRespectDefaultTimeout()`
`68`	`68`	`var exception = await Assert.ThrowsAnyAsync<TimeoutException>(async () =>`
`69`	`69`	`await Page.WaitForRequestAsync(request => false));`
`70`	`70`
`71`		`- Assert.Contains("Timeout Exceeded: 1ms", exception.Message);`
	`71`	`+ Assert.Contains("Timeout of 1 ms exceeded", exception.Message);`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace PuppeteerSharp.Helpers`
`10`	`10`	`public static class TaskHelper`
`11`	`11`	`{`
`12`	`12`	`private static readonly Func<TimeSpan, Exception> DefaultExceptionFactory =`
`13`		`- timeout => new TimeoutException($"Timeout Exceeded: {timeout.TotalMilliseconds}ms exceeded");`
	`13`	`+ timeout => new TimeoutException($"Timeout of {timeout.TotalMilliseconds} ms exceeded");`
`14`	`14`
`15`	`15`	`//Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/`
`16`	`16`	`/// <summary>`