added Page.title tests (#96)

closes #49

Author: Meir017

.gitignore

@@ -290,6 +290,7 @@ Thumbs.db
 
 # ignore local cert
 /lib/PuppeteerSharp.TestServer/testCert.cer
+/lib/PuppeteerSharp.Tests/Screenshots/test.png
 
 demos/PuppeteerSharpPdfDemo/google.pdf
-demos/PuppeteerSharpPdfDemo/.local-chromium/
+demos/PuppeteerSharpPdfDemo/.local-chromium/

lib/PuppeteerSharp.Tests/Page/TitleTests.cs

@@ -0,0 +1,18 @@
+using System.Threading.Tasks;
+using Xunit;
+
+namespace PuppeteerSharp.Tests.Page
+{
+    [Collection("PuppeteerLoaderFixture collection")]
+    public class TitleTests : PuppeteerBaseTest
+    {
+        [Fact]
+        public async Task ShouldReturnThePageTitle()
+        {
+            var page = await Browser.NewPageAsync();
+
+            await page.GoToAsync(TestConstants.ServerUrl + "/input/button.html");
+            Assert.Equal("Button test", await page.GetTitleAsync());
+        }
+    }
+}

lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj

@@ -15,7 +15,6 @@
   </ItemGroup>
   <ItemGroup>
     <Folder Include="Puppeteer\" />
-    <Folder Include="Page\" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\PuppeteerSharp\PuppeteerSharp.csproj" />

lib/PuppeteerSharp/ContextPayload.cs

@@ -2,12 +2,14 @@
 {
     public class ContextPayload
     {
-
         public ContextPayload(dynamic context)
         {
             Id = context.id;
+            AuxData = context.auxData.ToObject<ContextPayloadAuxData>();
         }
 
-        public string Id { get; internal set; }
+        public int Id { get; internal set; }
+
+        public ContextPayloadAuxData AuxData { get; internal set; }
     }
 }

lib/PuppeteerSharp/ContextPayloadAuxData.cs

@@ -0,0 +1,8 @@
+namespace PuppeteerSharp
+{
+    public struct ContextPayloadAuxData
+    {
+        public string FrameId { get; set; }
+        public bool IsDefault { get; set; }
+    }
+}

lib/PuppeteerSharp/ExecutionContext.cs

@@ -6,17 +6,19 @@ namespace PuppeteerSharp
 {
     public class ExecutionContext
     {
-        private Session _client;
-        private string _contextId;
+        private readonly Session _client;
+        private readonly int _contextId;
 
         public ExecutionContext(Session client, ContextPayload contextPayload, Func<dynamic, JSHandle> objectHandleFactory)
         {
             _client = client;
             _contextId = contextPayload.Id;
+            FrameId = contextPayload.AuxData.FrameId;
+            IsDefault = contextPayload.AuxData.IsDefault;
             ObjectHandleFactory = objectHandleFactory;
         }
 
-        public Func<JSHandle, dynamic> ObjectHandleFactory { get; internal set; }
+        public Func<dynamic, JSHandle> ObjectHandleFactory { get; internal set; }
         public string FrameId { get; internal set; }
         public bool IsDefault { get; internal set; }
 
@@ -43,12 +45,13 @@ internal async Task<JSHandle> EvaluateHandleAsync(string pageFunction, object[]
                 {
                     remoteObject = await _client.SendAsync("Runtime.evaluate", new Dictionary<string, object>()
                     {
-                        {"expression", _contextId},
-                        {"returnByValue", false},
-                        {"awaitPromise", true}
+                        ["expression"] = pageFunction,
+                        ["contextId"] = _contextId,
+                        ["returnByValue"] = false,
+                        ["awaitPromise"] = true
                     });
 
-                    return ObjectHandleFactory(remoteObject);
+                    return ObjectHandleFactory(remoteObject.result);
                 }
                 catch (Exception ex)
                 {

lib/PuppeteerSharp/Frame.cs

@@ -51,12 +51,17 @@ public Frame(Session client, Page page, Frame parentFrame, string frameId)
 
         public Task<ExecutionContext> GetExecutionContextAsync() => ContextResolveTaskWrapper.Task;
 
+        internal async Task<dynamic> EvaluateAsync(string pageFunction, params object[] args)
+        {
+            var context = await GetExecutionContextAsync();
+            return await context.Evaluate(pageFunction, args);
+        }
+
         internal async Task<ElementHandle> GetElementAsync(string selector)
         {
             throw new NotImplementedException();
         }
 
-
         internal Task<object> Eval(string selector, Func<object> pageFunction, object[] args)
         {
             throw new NotImplementedException();
@@ -92,6 +97,12 @@ internal Task<ElementHandle> AddScriptTag(dynamic options)
             throw new NotImplementedException();
         }
 
+        internal async Task<string> GetTitleAsync()
+        {
+            var result = await EvaluateAsync("document.title");
+            return result.ToString();
+        }
+
         internal void OnLifecycleEvent(string loaderId, string name)
         {
             if (name == "init")
@@ -113,7 +124,6 @@ internal void SetDefaultContext(ExecutionContext context)
             if (context != null)
             {
                 ContextResolveTaskWrapper.SetResult(context);
-                ContextResolveTaskWrapper = null;
 
                 foreach (var waitTask in _waitTasks)
                 {
@@ -137,8 +147,9 @@ internal void Detach()
             {
                 _parentFrame.ChildFrames.Remove(this);
             }
-            _parentFrame = null;
-            #endregion
+            _parentFrame = null;            
         }
+
+        #endregion
     }
 }

lib/PuppeteerSharp/FrameManager.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics.Contracts;
 using PuppeteerSharp.Input;
 using Newtonsoft.Json.Linq;
+using System.Diagnostics;
 
 namespace PuppeteerSharp
 {
@@ -12,14 +13,14 @@ public class FrameManager
         private Mouse _mouse;
         private Touchscreen _touchscreen;
         private Page _page;
-        private Dictionary<string, ExecutionContext> _contextIdToContext;
+        private Dictionary<int, ExecutionContext> _contextIdToContext;
 
         public FrameManager(Session client, FrameTree frameTree, Page page)
         {
             _client = client;
             _page = page;
             Frames = new Dictionary<string, Frame>();
-            _contextIdToContext = new Dictionary<string, ExecutionContext>();
+            _contextIdToContext = new Dictionary<int, ExecutionContext>();
 
             _client.MessageReceived += _client_MessageReceived;
             HandleFrameTree(frameTree);
@@ -60,7 +61,7 @@ void _client_MessageReceived(object sender, PuppeteerSharp.MessageEventArgs e)
                     break;
 
                 case "Runtime.executionContextDestroyed":
-                    OnExecutionContextDestroyed(e.MessageData.executionContextId.ToString());
+                    OnExecutionContextDestroyed((int)e.MessageData.executionContextId);
                     break;
                 case "Runtime.executionContextsCleared":
                     OnExecutionContextsCleared();
@@ -92,7 +93,7 @@ private void OnExecutionContextsCleared()
             _contextIdToContext.Clear();
         }
 
-        private void OnExecutionContextDestroyed(string executionContextId)
+        private void OnExecutionContextDestroyed(int executionContextId)
         {
             _contextIdToContext.TryGetValue(executionContextId, out var context);
 
@@ -109,8 +110,11 @@ private void OnExecutionContextCreated(ContextPayload contextPayload)
             var context = new ExecutionContext(_client, contextPayload, (dynamic remoteObject) =>
             {
                 _contextIdToContext.TryGetValue(contextPayload.Id, out var storedContext);
-
-                Contract.Assert(storedContext == null, $"INTERNAL ERROR: missing context with id = {contextPayload.Id}");
+                
+                if(storedContext == null)
+                {
+                    Console.WriteLine($"INTERNAL ERROR: missing context with id = {contextPayload.Id}");
+                }
                 if (remoteObject.Subtype == "node")
                 {
                     return new ElementHandle(storedContext, _client, remoteObject, _page);

lib/PuppeteerSharp/Helper.cs

@@ -7,12 +7,35 @@ internal class Helper
     {
         internal static object ValueFromRemoteObject(dynamic remoteObject)
         {
-            throw new NotImplementedException();
+            if (remoteObject.unserializableValue != null)
+            {
+                switch (remoteObject.unserializableValue.ToString())
+                {
+                    case "-0": return -0;
+                    case "NaN": return double.NaN;
+                    case "Infinity": return double.PositiveInfinity;
+                    case "-Infinity": return double.NegativeInfinity;
+                    default:
+                        throw new Exception("Unsupported unserializable value: " + remoteObject.unserializableValue);
+                }
+            }
+            return remoteObject.value;
         }
 
-        internal static Task ReleaseObject(Session client, dynamic remoteObject)
+        internal static async Task ReleaseObject(Session client, dynamic remoteObject)
         {
-            throw new NotImplementedException();
+            if (remoteObject.objectId == null)
+                return;
+            try
+            {
+                await client.SendAsync("Runtime.releaseObject", new { remoteObject.objectId });
+            }
+            catch (Exception ex)
+            {
+                // Exceptions might happen in case of a page been navigated or closed.
+                // Swallow these since they are harmless and we don't leak anything in this case.
+                Console.WriteLine(ex.ToString());
+            }
         }
     }
 }

lib/PuppeteerSharp/JSHandle.cs

@@ -37,9 +37,9 @@ public async Task<Dictionary<string, object>> GetProperty(string propertyName)
 
         public async Task<object> JsonValue()
         {
-            if (((IDictionary<string, object>)RemoteObject).ContainsKey("objectId"))
+            if (RemoteObject.objectId != null)
             {
-                dynamic response = await _client.SendAsync("Retunrime.callFunctionOn", new Dictionary<string, object>()
+                dynamic response = await _client.SendAsync("Runtime.callFunctionOn", new Dictionary<string, object>()
                 {
                     {"functionDeclaration", "function() { return this; }"},
                     {"objectId", RemoteObject.objectId},