Skip to content

Commit 77b6030

Browse files
authored
Add missing network tests (#1901)
1 parent afab561 commit 77b6030

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

lib/PuppeteerSharp.Tests/NetworkTests/NetworkEventTests.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,18 @@ public async Task PageEventsRequest()
3636
Assert.Equal(TestConstants.EmptyPage, requests[0].Frame.Url);
3737
}
3838

39+
[PuppeteerTest("network.spec.ts", "Network Events", "Page.Events.RequestServedFromCache")]
40+
[SkipBrowserFact(skipFirefox: true)]
41+
public async Task PageEventsRequestServedFromCache()
42+
{
43+
var cached= new List<string>();
44+
Page.RequestServedFromCache += (_, e) => cached.Add(e.Request.Url.Split('/').Last());
45+
await Page.GoToAsync(TestConstants.ServerUrl + "/cached/one-style.html");
46+
Assert.Empty(cached);
47+
await Page.ReloadAsync();
48+
Assert.Equal(new[] { "one-style.css" }, cached);
49+
}
50+
3951
[PuppeteerTest("network.spec.ts", "Network Events", "Page.Events.Response")]
4052
[SkipBrowserFact(skipFirefox: true)]
4153
public async Task PageEventsResponse()

lib/PuppeteerSharp.Tests/NetworkTests/ResponseHeadersTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public ResponseHeadersTests(ITestOutputHelper output) : base(output)
1313
{
1414
}
1515

16-
[PuppeteerTest("network.spec.ts", "Request.headers", "should work")]
16+
[PuppeteerTest("network.spec.ts", "Response.headers", "should work")]
1717
[PuppeteerFact]
1818
public async Task ShouldWork()
1919
{

lib/PuppeteerSharp.Tests/WontImplementTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public WontImplementTests(ITestOutputHelper output) : base(output)
4444
[PuppeteerTest("waittask.spec.ts", "Page.waitFor", "should log a deprecation warning")]
4545
[PuppeteerTest("waittask.spec.ts", "Frame.waitForFunction", "should accept a string")]
4646
[PuppeteerTest("waittask.spec.ts", "Frame.waitForFunction", "should throw on bad polling value")]
47+
[PuppeteerTest("network.spec.ts", "Page.setExtraHTTPHeaders", "should throw for non-string header values")]
4748
[PuppeteerFact]
4849
public void TheseTesstWontBeImplemented()
4950
{

0 commit comments

Comments
 (0)