Skip to content

Commit 7c15500

Browse files
authored
Bidi: Implement mouse features (#2981)
* Bidi: Implement some mouse features * feature complete * update expectations * fixes
1 parent bc0b290 commit 7c15500

File tree

11 files changed

+374
-298
lines changed

11 files changed

+374
-298
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,3 +300,4 @@ samples/PupppeterSharpAspNetFrameworkSample/PupppeterSharpAspNetFrameworkSample/
300300
.vscode/
301301
tools/github-ops/.env
302302
lib/.claude/settings.local.json
303+
lib/.claude/settings.local.json

lib/.claude/settings.local.json

Lines changed: 0 additions & 36 deletions
This file was deleted.

lib/CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ Test directory structure demonstrates comprehensive coverage:
379379
- Protocol-specific expectations (CDP, WebDriver BiDi)
380380
- Headless mode variations (headless, headful, headless-shell)
381381
- Local and upstream expectation merging
382-
382+
- Tests should always match the code in upstream. Tests should never be changed to match the code local code.
383383
#### Test Server (`PuppeteerSharp.TestServer/`)
384384
- ASP.NET Core server for hosting test pages
385385
- wwwroot directory with test fixtures

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

Lines changed: 45 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -765,36 +765,6 @@
765765
"FAIL"
766766
]
767767
},
768-
{
769-
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
770-
"testIdPattern": "[jshandle.spec] *getProperties*",
771-
"platforms": [
772-
"darwin",
773-
"linux",
774-
"win32"
775-
],
776-
"parameters": [
777-
"webDriverBiDi"
778-
],
779-
"expectations": [
780-
"FAIL"
781-
]
782-
},
783-
{
784-
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
785-
"testIdPattern": "[jshandle.spec] *.getProperty*",
786-
"platforms": [
787-
"darwin",
788-
"linux",
789-
"win32"
790-
],
791-
"parameters": [
792-
"webDriverBiDi"
793-
],
794-
"expectations": [
795-
"FAIL"
796-
]
797-
},
798768
{
799769
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
800770
"testIdPattern": "[jshandle.spec] *.evaluateHandle*",
@@ -885,36 +855,6 @@
885855
"FAIL"
886856
]
887857
},
888-
{
889-
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
890-
"testIdPattern": "[mocha-utils] *",
891-
"platforms": [
892-
"darwin",
893-
"linux",
894-
"win32"
895-
],
896-
"parameters": [
897-
"webDriverBiDi"
898-
],
899-
"expectations": [
900-
"FAIL"
901-
]
902-
},
903-
{
904-
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
905-
"testIdPattern": "[mouse.spec] *",
906-
"platforms": [
907-
"darwin",
908-
"linux",
909-
"win32"
910-
],
911-
"parameters": [
912-
"webDriverBiDi"
913-
],
914-
"expectations": [
915-
"FAIL"
916-
]
917-
},
918858
{
919859
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
920860
"testIdPattern": "[click.spec] *",
@@ -1664,5 +1604,50 @@
16641604
"expectations": [
16651605
"SKIP"
16661606
]
1607+
},
1608+
{
1609+
"comment": "BiDi Keyboard not implemented yet - requires BidiKeyboard implementation - NEEDS KEYBOARD",
1610+
"testIdPattern": "[mouse.spec] Mouse should select the text with mouse",
1611+
"platforms": [
1612+
"darwin",
1613+
"linux",
1614+
"win32"
1615+
],
1616+
"parameters": [
1617+
"webDriverBiDi"
1618+
],
1619+
"expectations": [
1620+
"SKIP"
1621+
]
1622+
},
1623+
{
1624+
"comment": "BiDi Keyboard not implemented yet - requires BidiKeyboard implementation - NEEDS KEYBOARD",
1625+
"testIdPattern": "[mouse.spec] Mouse should set modifier keys on click",
1626+
"platforms": [
1627+
"darwin",
1628+
"linux",
1629+
"win32"
1630+
],
1631+
"parameters": [
1632+
"webDriverBiDi"
1633+
],
1634+
"expectations": [
1635+
"SKIP"
1636+
]
1637+
},
1638+
{
1639+
"comment": "BiDi Keyboard not implemented yet - requires BidiKeyboard implementation",
1640+
"testIdPattern": "[mouse.spec] Mouse should set ctrlKey on the wheel event",
1641+
"platforms": [
1642+
"darwin",
1643+
"linux",
1644+
"win32"
1645+
],
1646+
"parameters": [
1647+
"webDriverBiDi"
1648+
],
1649+
"expectations": [
1650+
"SKIP"
1651+
]
16671652
}
16681653
]

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2134,13 +2134,6 @@
21342134
"expectations": ["SKIP"],
21352135
"comment": "Wheel event is not supported"
21362136
},
2137-
{
2138-
"testIdPattern": "[mouse.spec] Mouse should trigger hover state with removed window.Node",
2139-
"platforms": ["darwin", "linux", "win32"],
2140-
"parameters": ["cdp", "firefox"],
2141-
"expectations": ["FAIL"],
2142-
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
2143-
},
21442137
{
21452138
"testIdPattern": "[navigation.spec] navigation Frame.goto should navigate subframes",
21462139
"platforms": ["darwin", "linux", "win32"],

0 commit comments

Comments
 (0)