Removed couple of common allocations (#794)

Im5tu · kblok · commit 7f07b4e42cf2 · 2018-12-10T16:54:08.000-06:00
diff --git a/lib/PuppeteerSharp/Helpers/TaskHelper.cs b/lib/PuppeteerSharp/Helpers/TaskHelper.cs
@@ -16,8 +16,6 @@ public static class TaskHelper
         /// <exception cref="TimeoutException"></exception>
         public static async Task CreateTimeoutTask(int timeout)
         {
-            var wrapper = new TaskCompletionSource<bool>();
-
             if (timeout == 0)
             {
                 await Task.Delay(-1).ConfigureAwait(false);
diff --git a/lib/PuppeteerSharp/NavigatorWatcher.cs b/lib/PuppeteerSharp/NavigatorWatcher.cs
@@ -17,6 +17,7 @@ internal class NavigatorWatcher : IDisposable
                 [WaitUntilNavigation.Networkidle0] = "networkIdle",
                 [WaitUntilNavigation.Networkidle2] = "networkAlmostIdle"
             };
+        private static readonly WaitUntilNavigation[] _defaultWaitUntil = new[] { WaitUntilNavigation.Load };
 
         private readonly IConnection _connection;
         private readonly NetworkManager _networkManager;
@@ -39,7 +40,7 @@ public NavigatorWatcher(
             int timeout,
             NavigationOptions options)
         {
-            var waitUntil = new[] { WaitUntilNavigation.Load };
+            var waitUntil = _defaultWaitUntil;
 
             if (options?.WaitUntil != null)
             {

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,6 @@ public static class TaskHelper`
`16`	`16`	`/// <exception cref="TimeoutException"></exception>`
`17`	`17`	`public static async Task CreateTimeoutTask(int timeout)`
`18`	`18`	`{`
`19`		`- var wrapper = new TaskCompletionSource<bool>();`
`20`		`-`
`21`	`19`	`if (timeout == 0)`
`22`	`20`	`{`
`23`	`21`	`await Task.Delay(-1).ConfigureAwait(false);`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ internal class NavigatorWatcher : IDisposable`
`17`	`17`	`[WaitUntilNavigation.Networkidle0] = "networkIdle",`
`18`	`18`	`[WaitUntilNavigation.Networkidle2] = "networkAlmostIdle"`
`19`	`19`	`};`
	`20`	`+ private static readonly WaitUntilNavigation[] _defaultWaitUntil = new[] { WaitUntilNavigation.Load };`
`20`	`21`
`21`	`22`	`private readonly IConnection _connection;`
`22`	`23`	`private readonly NetworkManager _networkManager;`
`@@ -39,7 +40,7 @@ public NavigatorWatcher(`
`39`	`40`	`int timeout,`
`40`	`41`	`NavigationOptions options)`
`41`	`42`	`{`
`42`		`- var waitUntil = new[] { WaitUntilNavigation.Load };`
	`43`	`+ var waitUntil = _defaultWaitUntil;`
`43`	`44`
`44`	`45`	`if (options?.WaitUntil != null)`
`45`	`46`	`{`