Skip to content

Commit 8d56e1c

Browse files
committed
Improve a test
1 parent de1e627 commit 8d56e1c

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

lib/PuppeteerSharp.Tests/DefaultBrowserContextTests/BrowserTargetEventsTests.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
namespace PuppeteerSharp.Tests.DefaultBrowserContextTests
1111
{
12-
public class BrowserTargetEventsTests : PuppeteerBrowserBaseTest
12+
public class BrowserTargetEventsTests : PuppeteerBaseTest
1313
{
1414
public BrowserTargetEventsTests(): base()
1515
{
@@ -19,11 +19,12 @@ public BrowserTargetEventsTests(): base()
1919
[Skip(SkipAttribute.Targets.Firefox)]
2020
public async Task ShouldWork()
2121
{
22+
using var browser = await Puppeteer.LaunchAsync(TestConstants.DefaultBrowserOptions());
2223
var events = new List<string>();
23-
Browser.TargetCreated += (_, _) => events.Add("CREATED");
24-
Browser.TargetChanged += (_, _) => events.Add("CHANGED");
25-
Browser.TargetDestroyed += (_, _) => events.Add("DESTROYED");
26-
var page = await Browser.NewPageAsync();
24+
browser.TargetCreated += (_, _) => events.Add("CREATED");
25+
browser.TargetChanged += (_, _) => events.Add("CHANGED");
26+
browser.TargetDestroyed += (_, _) => events.Add("DESTROYED");
27+
var page = await browser.NewPageAsync();
2728
await page.GoToAsync(TestConstants.EmptyPage);
2829
await page.CloseAsync();
2930
Assert.AreEqual(new[] { "CREATED", "CHANGED", "DESTROYED" }, events);

0 commit comments

Comments
 (0)