Ensure executable permissions in Linux and OSX

Author: kblok

lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj

@@ -11,6 +11,7 @@
     <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
     <PackageReference Include="SixLabors.ImageSharp" Version="1.0.0-beta0002" />
     <PackageReference Include="PdfSharp" Version="1.50.4845-RC2a" NoWarn="NU1701" />
+    <PackageReference Include="Mono.Posix.NETStandard" Version="1.0.0" />
   </ItemGroup>
   <ItemGroup>
     <Folder Include="Issues\" />

lib/PuppeteerSharp.Tests/PuppeteerTests/BrowserFetcherTests.cs

@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+using System.Runtime.InteropServices;
 using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
@@ -32,6 +33,12 @@ public async Task ShouldDownloadAndExtractLinuxBinary()
             revisionInfo = await browserFetcher.DownloadAsync(123456);
             Assert.True(revisionInfo.Local);
             Assert.Equal("LINUX BINARY\n", File.ReadAllText(revisionInfo.ExecutablePath));
+
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX) || RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+            {
+                Mono.Unix.Native.Syscall.stat(revisionInfo.ExecutablePath, out var stat);
+                Assert.Equal(BrowserFetcher.BrowserPermissionsInLinux, stat.st_mode & BrowserFetcher.BrowserPermissionsInLinux);
+            }
             Assert.Equal(new[] { 123456 }, browserFetcher.LocalRevisions());
             browserFetcher.Remove(123456);
             Assert.Empty(browserFetcher.LocalRevisions());

lib/PuppeteerSharp/BrowserFetcher.cs

@@ -8,6 +8,7 @@
 using System.Threading.Tasks;
 using System.Net;
 using System.IO.Compression;
+using Mono.Unix.Native;
 
 namespace PuppeteerSharp
 {
@@ -33,6 +34,13 @@ public class BrowserFetcher
             {Platform.Win64, "{0}/chromium-browser-snapshots/Win_x64/{1}/chrome-win32.zip"}
         };
 
+        internal static readonly FilePermissions BrowserPermissionsInLinux =
+            FilePermissions.S_IRWXU |
+            FilePermissions.S_IRGRP |
+            FilePermissions.S_IXGRP |
+            FilePermissions.S_IROTH |
+            FilePermissions.S_IXOTH;
+
         /// <summary>
         /// Default chromiumg revision.
         /// </summary>
@@ -164,7 +172,7 @@ public async Task<RevisionInfo> DownloadAsync(int revision)
 
             if (new DirectoryInfo(folderPath).Exists)
             {
-                return null;
+                return RevisionInfo(revision);
             }
 
             var downloadFolder = new DirectoryInfo(DownloadsFolder);
@@ -195,7 +203,13 @@ public async Task<RevisionInfo> DownloadAsync(int revision)
 
             new FileInfo(zipPath).Delete();
 
-            return RevisionInfo(revision);
+            var revisionInfo = RevisionInfo(revision);
+
+            if (revisionInfo != null && (GetCurrentPlatform() == Platform.Linux || GetCurrentPlatform() == Platform.MacOS))
+            {
+                Syscall.chmod(revisionInfo.ExecutablePath, BrowserPermissionsInLinux);
+            }
+            return revisionInfo;
         }
 
         /// <summary>

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -42,5 +42,6 @@ Changes
     <PackageReference Include="System.Net.Http" Version="4.3.3" />
     <PackageReference Include="Microsoft.AspNetCore.WebUtilities" Version="2.0.2" />
     <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.1" />
+    <PackageReference Include="Mono.Posix.NETStandard" Version="1.0.0" />
   </ItemGroup>
 </Project>