Corrects CA2000 and IDE0008 (#1463)

Corrects CA2000 issue but also correct's IDE0008. This seems to be traced back to .editorconfig

csharp_style_var_for_built_in_types = false:error
csharp_style_var_when_type_is_apparent = false:none

This was unexpected but solution compiles now.

Author: undefinedfunction

lib/PuppeteerSharp.ruleset

@@ -1,4 +1,4 @@
-<RuleSet Name="Rules for PlaywrightSharp" Description="Rules for PlaywrightSharp" ToolsVersion="10.0">
+<RuleSet Name="Rules for PlaywrightSharp" Description="Rules for PlaywrightSharp" ToolsVersion="10.0">
  <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
     <Rule Id="SA1633" Action="None" />
     <Rule Id="SA1200" Action="None" />
@@ -76,7 +76,7 @@
     <Rule Id="CA1724" Action="None" /> <!-- Error CA1724: The type name Extensions conflicts in whole or in part with the namespace name 'Microsoft.Extensions'. Change either name to eliminate the conflict. (CA1724) -->
     <Rule Id="CA1806" Action="None" /> <!-- Error CA1806: DownloadAsync calls Chmod but does not use the HRESULT or error code that the method returns. This could lead to unexpected behavior in error conditions or low-resource situations. Use the result in a conditional statement, assign the result to a variable, or pass it as an argument to another method. (CA1806)-->
     <Rule Id="CA1816" Action="None" /> <!-- Error CA1816: Change Connection.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (CA1816) -->
-    <Rule Id="CA2000" Action="None" /> <!-- Error CA2000: Call System.IDisposable.Dispose on object created by 'new Process()' before all references to it are out of scope. (CA2000) -->
+    <Rule Id="CA2000" Action="Error" /> <!-- Error CA2000: Call System.IDisposable.Dispose on object created by 'new Process()' before all references to it are out of scope. (CA2000) -->
     <Rule Id="CA2008" Action="None" /> <!-- Error ca2008: Pass TaskScheduler-->
     <Rule Id="CA2200" Action="None" /> <!-- Error CA2200: Re-throwing caught exception changes stack information. (CA2200)  -->
     <Rule Id="CA2213" Action="None" /> <!-- Error CA2213: 'WebSocketTransport' contains field '_readerCancellationSource' that is of IDisposable type 'CancellationTokenSource', but it is never disposed. Change the Dispose method on 'WebSocketTransport' to call Close or Dispose on this field. (CA2213) -->
@@ -87,4 +87,4 @@
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
     <Rule Id="CA1303" Action="None" />
   </Rules>
-</RuleSet>
+</RuleSet>

lib/PuppeteerSharp/BrowserFetcher.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
@@ -107,13 +107,15 @@ public async Task<bool> CanDownloadAsync(int revision)
         {
             try
             {
-                var url = GetDownloadURL(Platform, DownloadHost, revision);
+                string url = GetDownloadURL(Platform, DownloadHost, revision);
 
                 var client = WebRequest.Create(url);
                 client.Proxy = _webClient.Proxy;
                 client.Method = "HEAD";
-                var response = await client.GetResponseAsync().ConfigureAwait(false) as HttpWebResponse;
-                return response.StatusCode == HttpStatusCode.OK;
+                using (var response = await client.GetResponseAsync().ConfigureAwait(false) as HttpWebResponse)
+                {
+                    return response.StatusCode == HttpStatusCode.OK;
+                }
             }
             catch (WebException)
             {
@@ -177,9 +179,9 @@ public RevisionInfo RevisionInfo(int revision)
         /// <param name="revision">Revision.</param>
         public async Task<RevisionInfo> DownloadAsync(int revision)
         {
-            var url = GetDownloadURL(Platform, DownloadHost, revision);
-            var zipPath = Path.Combine(DownloadsFolder, $"download-{Platform.ToString()}-{revision}.zip");
-            var folderPath = GetFolderPath(revision);
+            string url = GetDownloadURL(Platform, DownloadHost, revision);
+            string zipPath = Path.Combine(DownloadsFolder, $"download-{Platform.ToString()}-{revision}.zip");
+            string folderPath = GetFolderPath(revision);
 
             if (new DirectoryInfo(folderPath).Exists)
             {
@@ -289,17 +291,18 @@ private string GetFolderPath(int revision)
 
         private void NativeExtractToDirectory(string zipPath, string folderPath)
         {
-            var process = new Process();
-
-            process.StartInfo.FileName = "unzip";
-            process.StartInfo.Arguments = $"\"{zipPath}\" -d \"{folderPath}\"";
-            process.Start();
-            process.WaitForExit();
+            using (var process = new Process())
+            {
+                process.StartInfo.FileName = "unzip";
+                process.StartInfo.Arguments = $"\"{zipPath}\" -d \"{folderPath}\"";
+                process.Start();
+                process.WaitForExit();
+            }
         }
 
         private int GetRevisionFromPath(string folderName)
         {
-            var splits = folderName.Split('-');
+            string[] splits = folderName.Split('-');
             if (splits.Length != 2)
             {
                 return 0;
@@ -315,7 +318,7 @@ private int GetRevisionFromPath(string folderName)
                 return 0;
             }
 
-            int.TryParse(splits[1], out var revision);
+            int.TryParse(splits[1], out int revision);
             return revision;
         }