Update stylecop.analyzers (#1930)

Author: kblok

lib/PuppeteerSharp.ruleset

@@ -34,6 +34,7 @@
     <Rule Id="SA1642" Action="None" /> <!-- Error SA1642: Constructor summary documentation should begin with standard text (SA1642) (PuppeteerSharp)-->
     <Rule Id="SA1013" Action="Error" /> <!-- Error SA1013: Closing brace should be preceded by a space. (SA1013) -->
     <Rule Id="SA1515" Action="Error" /> <!-- Error SA1515: Single-line comment should be preceded by blank line (SA1515) -->
+    <Rule Id="SA1518" Action="None" /> <!-- Error SA1518: File is required to end with a single newline character (SA1518)-->
     <Rule Id="SA1012" Action="Error" /> <!-- Error SA1012: Opening brace should be followed by a space. (SA1012) -->
     <Rule Id="SA1512" Action="None" /> <!-- Error SA1502: Element should not be on a single line (SA1502) -->
     <Rule Id="SA1648" Action="None" /> <!-- Error SA1648: inheritdoc should be used with inheriting class (SA1648) -->

lib/PuppeteerSharp/BrowserFetcher.cs

@@ -39,7 +39,7 @@ public class BrowserFetcher : IDisposable
             [Product.Firefox] = "https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central",
         };
 
-        private static readonly Dictionary<(Product product, Platform platform), string> _downloadUrls = new Dictionary<(Product product, Platform platform), string>
+        private static readonly Dictionary<(Product Product, Platform Platform), string> _downloadUrls = new()
         {
             [(Product.Chrome, Platform.Linux)] = "{0}/chromium-browser-snapshots/Linux_x64/{1}/{2}.zip",
             [(Product.Chrome, Platform.MacOS)] = "{0}/chromium-browser-snapshots/Mac/{1}/{2}.zip",

lib/PuppeteerSharp/ChromiumLauncher.cs

@@ -73,7 +73,7 @@ public ChromiumLauncher(string executable, LaunchOptions options)
 
         #region Private methods
 
-        private static (List<string> chromiumArgs, TempDirectory tempUserDataDirectory) PrepareChromiumArgs(LaunchOptions options)
+        private static (List<string> ChromiumArgs, TempDirectory TempUserDataDirectory) PrepareChromiumArgs(LaunchOptions options)
         {
             var chromiumArgs = new List<string>();
 

lib/PuppeteerSharp/ElementHandle.cs

@@ -535,7 +535,7 @@ public async Task<DragData> DragAsync(decimal x, decimal y)
 
             await ScrollIntoViewIfNeededAsync().ConfigureAwait(false);
             var start = await ClickablePointAsync().ConfigureAwait(false);
-            return await Page.Mouse.DragAsync(start.x, start.y, x, y).ConfigureAwait(false);
+            return await Page.Mouse.DragAsync(start.X, start.Y, x, y).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -610,10 +610,10 @@ public async Task DragAndDropAsync(ElementHandle target, int delay = 0)
             await ScrollIntoViewIfNeededAsync().ConfigureAwait(false);
             var (x, y) = await ClickablePointAsync().ConfigureAwait(false);
             var targetPoint = await target.ClickablePointAsync().ConfigureAwait(false);
-            await Page.Mouse.DragAndDropAsync(x, y, targetPoint.x, targetPoint.y, delay).ConfigureAwait(false);
+            await Page.Mouse.DragAndDropAsync(x, y, targetPoint.X, targetPoint.Y, delay).ConfigureAwait(false);
         }
 
-        private async Task<(decimal x, decimal y)> ClickablePointAsync()
+        private async Task<(decimal X, decimal Y)> ClickablePointAsync()
         {
             GetContentQuadsResponse result = null;
 
@@ -661,8 +661,8 @@ public async Task DragAndDropAsync(ElementHandle target, int delay = 0)
             }
 
             return (
-                x: x / 4,
-                y: y / 4);
+                X: x / 4,
+                Y: y / 4);
         }
 
         private IEnumerable<BoxModelPoint> IntersectQuadWithViewport(IEnumerable<BoxModelPoint> quad, PageGetLayoutMetricsResponse viewport)

lib/PuppeteerSharp/FirefoxLauncher.cs

@@ -38,7 +38,7 @@ public FirefoxLauncher(string executable, LaunchOptions options)
         /// <inheritdoc />
         public override string ToString() => $"Firefox process; EndPoint={EndPoint}; State={CurrentState}";
 
-        private static (List<string> firefoxArgs, TempDirectory tempUserDataDirectory) PrepareFirefoxArgs(LaunchOptions options)
+        private static (List<string> FirefoxArgs, TempDirectory TempUserDataDirectory) PrepareFirefoxArgs(LaunchOptions options)
         {
             var firefoxArgs = new List<string>();
 

lib/PuppeteerSharp/Helpers/AsyncDictionaryHelper.cs

@@ -31,7 +31,8 @@ internal async Task<TValue> GetItemAsync(TKey key)
 
             return await tcs.Task.WithTimeout(
                 new Action(() =>
-                    throw new PuppeteerException(string.Format(CultureInfo.CurrentCulture, _timeoutMessage, key))), 1000).ConfigureAwait(false);
+                    throw new PuppeteerException(string.Format(CultureInfo.CurrentCulture, _timeoutMessage, key))),
+                1000).ConfigureAwait(false);
         }
 
         internal async Task<TValue> TryGetItemAsync(TKey key)

lib/PuppeteerSharp/LauncherBase.cs

@@ -142,7 +142,8 @@ await ExitCompletionSource.Task.WithTimeout(
                     () =>
                     {
                         taskCompleted = false;
-                    }, timeout.Value).ConfigureAwait(false);
+                    },
+                    timeout.Value).ConfigureAwait(false);
                 return taskCompleted;
             }
 

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -35,7 +35,7 @@
     <PackageReference Include="Microsoft.AspNetCore.WebUtilities" Version="2.2.0" />
     <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="1.1.0" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
+    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.406">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>