Skip to content

Commit b8bec2b

Browse files
kblokCopilot
andauthored
Bidi: Implement last redirect (#2972)
* Bidi: Implement last redirect * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Update lib/CLAUDE.md Co-authored-by: Copilot <[email protected]> * Apply suggestion from @kblok --------- Co-authored-by: Copilot <[email protected]>
1 parent fc5f78c commit b8bec2b

File tree

9 files changed

+481
-24
lines changed

9 files changed

+481
-24
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,3 +299,4 @@ samples/PupppeterSharpAspNetFrameworkSample/PupppeterSharpAspNetFrameworkSample/
299299
# Visual Studio Code user config directory
300300
.vscode/
301301
tools/github-ops/.env
302+
lib/.claude/settings.local.json
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Context
2+
You are a software developer integrating changes from a project written in TypeScript into a .NET project.
3+
We call upstream to the original typescript project.
4+
5+
# Task
6+
7+
You are going to implement the changes to make $ARGUMENTS pass.
8+
9+
In order to do that you will need to:
10+
* Find the entry with the `testIdPattern` $ARGUMENTS in TestExpectations.local.json and remove that entry.
11+
* You are going to look for tests that might match that `testIdPattern` but looking at the test attribute.
12+
- For instance if the `testIdPattern` is `Chromium-Specific *`, `[Test, PuppeteerTest("chromiumonly.spec", "Chromium-Specific Page Tests", "Page.setRequestInterception should work with intervention headers")]` will be a valid match.
13+
* Once you see what fail in those tests you will need to modify the code to make the test pass. You should not edit the tests themselves.
14+
* You will find the code in typescript implementing the feature at ../../puppeteer/puppeteer and you will need to port that code to .NET.
15+
* You will also find BidiDriver code at ../../puppeteer/bidi-client you need to check what you need to use from there to make the tests pass.
16+
* You will have to implement the code as close as possible to the original code, but adapted to .NET idioms and practices.
17+
* As part of the task you will need to generate a document explaining the changes you made, and how they relate to the original PR.
18+
* You need to run related tests to ensure everything is working as expected.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Context
2+
You are a software developer integrating changes from a project written in TypeScript into a .NET project.
3+
We call upstream to the original typescript project.
4+
5+
# Task
6+
7+
You are going to check the changes on the PR $ARGUMENTS
8+
You will find the upstream repository at ../../puppeteer/puppeteer. Feel free to read the code there and even make git action to bring the changes you need to evaluate.
9+
10+
Once you have all the context, you will implement the same changes in this .NET project.
11+
You will create a new branch named `implement-upstream-change-<PR_NUMBER>` where `<PR_NUMBER>` is the number of the PR you are implementing.
12+
You will have to implement the code as close as possible to the original code, but adapted to .NET idioms and practices.
13+
14+
As part of the task you will need to generate a document explaining the changes you made, and how they relate to the original PR.
15+
16+
You need to run related tests to ensure everything is working as expected.
17+
If tests are failing, you will need to fix them.

0 commit comments

Comments
 (0)