Skip to content

Commit c97a908

Browse files
authored
NetworkId can be null (#1148)
1 parent 47a20f7 commit c97a908

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

lib/PuppeteerSharp/NetworkManager.cs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -275,13 +275,17 @@ private async Task OnRequestPausedAsync(FetchRequestPausedResponse e)
275275

276276
var requestId = e.NetworkId;
277277
var interceptionId = e.RequestId;
278-
if (!string.IsNullOrEmpty(requestId) && _requestIdToRequestWillBeSentEvent.TryRemove(requestId, out var requestWillBeSentEvent))
279-
{
280-
await OnRequestAsync(requestWillBeSentEvent, interceptionId).ConfigureAwait(false);
281-
}
282-
else
278+
279+
if (!string.IsNullOrEmpty(requestId))
283280
{
284-
_requestIdToInterceptionId[requestId] = interceptionId;
281+
if (_requestIdToRequestWillBeSentEvent.TryRemove(requestId, out var requestWillBeSentEvent))
282+
{
283+
await OnRequestAsync(requestWillBeSentEvent, interceptionId).ConfigureAwait(false);
284+
}
285+
else
286+
{
287+
_requestIdToInterceptionId[requestId] = interceptionId;
288+
}
285289
}
286290
}
287291

lib/PuppeteerSharp/PuppeteerSharp.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<PropertyGroup>
33
<TargetFramework>netstandard2.0</TargetFramework>
44
<PackOnBuild>true</PackOnBuild>
5-
<PackageVersion>1.17.0</PackageVersion>
5+
<PackageVersion>1.17.1</PackageVersion>
66
<Authors>Darío Kondratiuk</Authors>
77
<Owners>Darío Kondratiuk</Owners>
88
<PackageProjectUrl>https://github.com/kblok/puppeteer-sharp</PackageProjectUrl>
@@ -21,7 +21,7 @@
2121
* Page.SetContentAsync working with unicode strings.
2222
2323
]]></PackageReleaseNotes>
24-
<ReleaseVersion>1.17.0</ReleaseVersion>
24+
<ReleaseVersion>1.17.1</ReleaseVersion>
2525
<SynchReleaseVersion>false</SynchReleaseVersion>
2626
</PropertyGroup>
2727
<PropertyGroup>

0 commit comments

Comments
 (0)