Add missing oopif tests (#1979)

* Add missing oopif tests

* Some progress

* tests implemented

* code factor

* Improve some tests

* Add more timeouts

* Add extra withTimeouts

* Unique ports

* cr

* Add more timeouts

* change docs

* Fix screenshot

* Is this how you debug a test in CI?

* Timeout the dispose

* Improve one test

* Ignore one test

* Skip another test

* undo changes

* Remove nunit warning

* Ignore another test

* self cr

Author: kblok

lib/.editorconfig

@@ -148,7 +148,11 @@ csharp_space_between_square_brackets = false
 # Analyzers
 dotnet_code_quality.ca1802.api_surface = private, internal
 
-# C++ Files
+# C++ Files
+
+# Default severity for analyzer diagnostics with category 'Usage'
+dotnet_analyzer_diagnostic.category-Usage.severity = none
+
 [*.{cpp,h,in}]
 curly_bracket_next_line = true
 indent_brace_style = Allman

lib/PuppeteerSharp.TestServer/wwwroot/dynamic-oopif.html

@@ -3,7 +3,7 @@
   const iframe = document.createElement('iframe');
   const url = new URL(location.href);
   url.hostname = url.hostname === 'localhost' ? '127.0.0.1' : 'localhost';
-  url.pathname = '/grid.html';
+  url.pathname = '/oopif.html';
   iframe.src = url.toString();
   document.body.appendChild(iframe);
 }, false);

lib/PuppeteerSharp.TestServer/wwwroot/inner-frame1.html

@@ -0,0 +1,10 @@
+<script>
+  window.addEventListener('DOMContentLoaded', () => {
+    const iframe = document.createElement('iframe');
+    const url = new URL(location.href);
+    url.hostname = 'inner-frame2.test';
+    url.pathname = '/inner-frame2.html';
+    iframe.src = url.toString();
+    document.body.appendChild(iframe);
+  }, false);
+</script>

lib/PuppeteerSharp.TestServer/wwwroot/inner-frame2.html

@@ -0,0 +1 @@
+<button>click</button>

lib/PuppeteerSharp.TestServer/wwwroot/lazy-oopif-frame.html

@@ -0,0 +1,3 @@
+<iframe width="100%" height="300" src="about:blank"></iframe>
+<div style="height: 800vh"></div>
+<iframe width="100%" height="300" src='http://www.example.com' loading="lazy"></iframe>

lib/PuppeteerSharp.TestServer/wwwroot/main-frame.html

@@ -0,0 +1,10 @@
+<script>
+  window.addEventListener('DOMContentLoaded', () => {
+    const iframe = document.createElement('iframe');
+    const url = new URL(location.href);
+    url.hostname = 'inner-frame1.test';
+    url.pathname = '/inner-frame1.html';
+    iframe.src = url.toString();
+    document.body.appendChild(iframe);
+  }, false);
+</script>

lib/PuppeteerSharp.Tests/FrameUtils.cs

@@ -6,9 +6,12 @@ namespace PuppeteerSharp.Tests
 {
     public static class FrameUtils
     {
-        public static async Task<Frame> AttachFrameAsync(Page page, string frameId, string url)
+        public static Task<Frame> AttachFrameAsync(Page page, string frameId, string url)
+            => AttachFrameAsync(page.MainFrame, frameId, url);
+
+        public static async Task<Frame> AttachFrameAsync(Frame frame, string frameId, string url)
         {
-            var handle = (ElementHandle)await page.EvaluateFunctionHandleAsync(@" async (frameId, url) => {
+            var handle = (ElementHandle)await frame.EvaluateFunctionHandleAsync(@" async (frameId, url) => {
               const frame = document.createElement('iframe');
               frame.src = url;
               frame.id = frameId;
@@ -19,13 +22,14 @@ public static async Task<Frame> AttachFrameAsync(Page page, string frameId, stri
             return await handle.ContentFrameAsync();
         }
 
-        public static async Task DetachFrameAsync(Page page, string frameId)
-        {
-            await page.EvaluateFunctionAsync(@"function detachFrame(frameId) {
-              const frame = document.getElementById(frameId);
-              frame.remove();
-            }", frameId);
-        }
+        public static Task DetachFrameAsync(Page page, string frameId)
+            => DetachFrameAsync(page.MainFrame, frameId);
+
+        public static Task DetachFrameAsync(Frame frame, string frameId)
+            => frame.EvaluateFunctionAsync(@"function detachFrame(frameId) {
+                  const frame = document.getElementById(frameId);
+                  frame.remove();
+                }", frameId);
 
         public static IEnumerable<string> DumpFrames(Frame frame, string indentation = "")
         {
@@ -43,9 +47,12 @@ public static IEnumerable<string> DumpFrames(Frame frame, string indentation = "
             return result;
         }
 
-        internal static async Task NavigateFrameAsync(Page page, string frameId, string url)
+        internal static Task NavigateFrameAsync(Page page, string frameId, string url)
+            => NavigateFrameAsync(page.MainFrame, frameId, url);
+
+        internal static async Task NavigateFrameAsync(Frame frame, string frameId, string url)
         {
-            await page.EvaluateFunctionAsync(@"function navigateFrame(frameId, url) {
+            await frame.EvaluateFunctionAsync(@"function navigateFrame(frameId, url) {
               const frame = document.getElementById(frameId);
               frame.src = url;
               return new Promise(x => frame.onload = x);