Bidi: Idle override (#2979)

Author: kblok

.github/workflows/dotnet.yml

@@ -54,6 +54,10 @@ jobs:
             browser: FIREFOX
             mode: headless
             protocol: webdriverbidi
+          - os: ubuntu-latest
+            browser: FIREFOX
+            mode: headful
+            protocol: webdriverbidi
     steps:
     - uses: actions/checkout@v3
     - name: Setup .NET Core

lib/CLAUDE.md

@@ -385,6 +385,26 @@ Test directory structure demonstrates comprehensive coverage:
 - wwwroot directory with test fixtures
 - Asset serving for test scenarios
 
+## Development Best Practices
+
+### Building and Running Tests
+
+When running tests, always build first and then use the `--no-build` flag to avoid rebuilding during test execution. This provides faster and more reliable test runs:
+
+```bash
+# Build the test project first
+dotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj
+
+# Then run tests with --no-build flag
+dotnet test PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~TestName" --no-build -- NUnit.TestOutputXml=TestResults
+
+# Can also chain them together
+dotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj && dotnet test PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~TestName" --no-build -- NUnit.TestOutputXml=TestResults
+```
+
+You can switch between CDP and Bidi by changing the PuppeteerTestAttribute.IsCdp property.
+You can switch between Chrome and Firefox by changing the PuppeteerTestAttribute.IsChrome property.
+
 ## Utilities and Helpers
 
 ### Helper Classes (`Helpers/`)

lib/PuppeteerSharp.Nunit/PuppeteerTestAttribute.cs

@@ -22,8 +22,8 @@ public class PuppeteerTestAttribute : NUnitAttribute, IApplyToTest
         private static TestExpectation[] _localExpectations;
         private static TestExpectation[] _upstreamExpectations;
 
-        public static readonly bool IsChrome = Environment.GetEnvironmentVariable("BROWSER") != "FIREFOX";
-        public static readonly bool IsCdp = string.IsNullOrEmpty(Environment.GetEnvironmentVariable("PROTOCOL")) || Environment.GetEnvironmentVariable("PROTOCOL")!.Equals("cdp");
+        public static readonly bool IsChrome = false;
+        public static readonly bool IsCdp = false;
 
         public static readonly HeadlessMode Headless =
             string.IsNullOrEmpty(Environment.GetEnvironmentVariable("HEADLESS_MODE")) ?

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -780,51 +780,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[golden-utils] *",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[headful.spec] *",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[idle_override.spec] *",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[acceptInsecureCerts.spec] *",
@@ -870,21 +825,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[jshandle.spec] *.asElement*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[jshandle.spec] *.clickablePoint*",

lib/PuppeteerSharp.Tests/ElementHandleTests/ContentFrameTests.cs

@@ -27,12 +27,12 @@ public async Task ShouldWork()
         [Test, PuppeteerTest("elementhandle.spec", "PuppeteerSharp", "should work headful")]
         public async Task ShouldWorkHeadful()
         {
-            await using var Browser = await Puppeteer.LaunchAsync(_headfulOptions);
-            await using var Page = await Browser.NewPageAsync();
-            await Page.GoToAsync($"{TestConstants.ServerUrl}/frame-example.html");
-            var elementHandle = await Page.QuerySelectorAsync("iframe");
+            await using var browser = await Puppeteer.LaunchAsync(_headfulOptions);
+            await using var page = await browser.NewPageAsync();
+            await page.GoToAsync($"{TestConstants.ServerUrl}/frame-example.html");
+            var elementHandle = await page.QuerySelectorAsync("iframe");
             var frame = await elementHandle.ContentFrameAsync();
-            Assert.That(frame, Is.EqualTo(Page.FirstChildFrame()));
+            Assert.That(frame, Is.EqualTo(page.FirstChildFrame()));
         }
     }
 }

lib/PuppeteerSharp.Tests/IdleOverrideTests/IdleOverrideTests.cs

@@ -6,10 +6,6 @@ namespace PuppeteerSharp.Tests.IdleOverrideTests
 {
     public class IdleOverrideTests : PuppeteerPageBaseTest
     {
-        public IdleOverrideTests() : base()
-        {
-        }
-
         private async Task<string> GetIdleStateAsync()
         {
             var stateElement = await Page.QuerySelectorAsync("#state");
@@ -31,10 +27,9 @@ public async Task ChangingIdleStateEmulationCausesChangeOfTheIdleDetectorState()
         {
             await Context.OverridePermissionsAsync(
                 TestConstants.ServerUrl + "/idle-detector.html",
-                new[]
-                {
-                    OverridePermission.IdleDetection,
-                });
+                [
+                    OverridePermission.IdleDetection
+                ]);
 
             await Page.GoToAsync(TestConstants.ServerUrl + "/idle-detector.html");
 

lib/PuppeteerSharp/Bidi/BidiPage.cs

@@ -96,7 +96,8 @@ public override async Task BringToFrontAsync()
     public override Task EmulateTimezoneAsync(string timezoneId) => throw new NotImplementedException();
 
     /// <inheritdoc />
-    public override Task EmulateIdleStateAsync(EmulateIdleOverrides idleOverrides = null) => throw new NotImplementedException();
+    public override Task EmulateIdleStateAsync(EmulateIdleOverrides idleOverrides = null)
+        => _cdpEmulationManager.EmulateIdleStateAsync(idleOverrides);
 
     /// <inheritdoc />
     public override Task EmulateCPUThrottlingAsync(decimal? factor = null) => throw new NotImplementedException();