Bidi Page Popup event (#3004)

Author: kblok

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -1020,21 +1020,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[page.spec] *Page.Events.Popup*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[page.spec] *Page.removeExposedFunction*",

lib/PuppeteerSharp/Bidi/BidiBrowserContext.cs

@@ -122,26 +122,23 @@ private void Initialize()
 
             // We need to wait for the DOMContentLoaded as the
             // browsingContext still may be navigating from the about:blank
-            browsingContext.DomContentLoaded += (o, eventArgs) =>
+            if (browsingContext.OriginalOpener == null)
             {
-                if (browsingContext.OriginalOpener == null)
+                return;
+            }
+
+            foreach (var context in UserContext.BrowsingContexts)
+            {
+                if (context.Id != browsingContext.OriginalOpener)
                 {
-                    return;
+                    continue;
                 }
 
-                foreach (var context in UserContext.BrowsingContexts)
+                if (_pages.TryGetValue(context, out var originalOpenerPage))
                 {
-                    if (context.Id != browsingContext.OriginalOpener)
-                    {
-                        continue;
-                    }
-
-                    if (_pages.TryGetValue(context, out var originalOpenerPage))
-                    {
-                        originalOpenerPage.OnPopup(page);
-                    }
+                    originalOpenerPage.OnPopup(page);
                 }
-            };
+            }
         };
     }