Skip to content

Commit d8a35cb

Browse files
kblokMeir017
authored andcommitted
Unflake page test that was causing us a lot of CI flakes (#625)
1 parent 5f22946 commit d8a35cb

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/PuppeteerSharp.Tests/PageTests/WaitForNavigationTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,10 @@ public async Task ShouldWorkWhenSubframeIssuesWindowStop()
162162
}
163163
};
164164
await frameNavigatedTaskSource.Task;
165-
var task = frame.EvaluateFunctionAsync("() => window.stop()");
166-
await navigationTask;
165+
await Task.WhenAll(
166+
frame.EvaluateFunctionAsync("() => window.stop()"),
167+
navigationTask
168+
);
167169
}
168170
}
169171
}

0 commit comments

Comments
 (0)