Enable rule SA1629 (#2053)

* Enable rule SA1629

* Fix build errors

Co-authored-by: Akshay Kumar <[email protected]>

Author: akshay-zz

lib/PuppeteerSharp.ruleset

@@ -12,7 +12,7 @@
     <Rule Id="SA1028" Action="Error" /> <!-- Error SA1028: Code should not contain trailing whitespace (SA1028)-->
     <Rule Id="SA1600" Action="None" /> <!-- Error SA1600: Elements should be documented (SA1600)-->
     <Rule Id="SA1516" Action="Error" /> <!-- Error SA1516: Elements should be separated by blank line (SA1516)-->
-    <Rule Id="SA1629" Action="None" /> <!-- Error SA1629: Documentation text should end with a period (SA1629)-->
+    <Rule Id="SA1629" Action="Error" /> <!-- Error SA1629: Documentation text should end with a period (SA1629)-->
     <Rule Id="SA1514" Action="Error" /> <!-- Error SA1514: Element documentation header should be preceded by blank line (SA1514)-->
     <Rule Id="SA1201" Action="Error" /> <!-- Error SA1201: Elements must appear in the correct order (SA1201)-->
     <Rule Id="SA1202" Action="Error" /> <!-- Error SA1202: 'public' members should come before 'internal' members (SA1202)-->

lib/PuppeteerSharp/BoxModel.cs

@@ -10,32 +10,32 @@ internal BoxModel()
         }
 
         /// <summary>
-        /// Gets the Content box
+        /// Gets the Content box.
         /// </summary>
         public BoxModelPoint[] Content { get; internal set; }
 
         /// <summary>
-        /// Gets the Padding box
+        /// Gets the Padding box.
         /// </summary>
         public BoxModelPoint[] Padding { get; internal set; }
 
         /// <summary>
-        /// Gets the Border box
+        /// Gets the Border box.
         /// </summary>
         public BoxModelPoint[] Border { get; internal set; }
 
         /// <summary>
-        /// Gets the Margin box
+        /// Gets the Margin box.
         /// </summary>
         public BoxModelPoint[] Margin { get; internal set; }
 
         /// <summary>
-        /// Gets the element's width
+        /// Gets the element's width.
         /// </summary>
         public int Width { get; internal set; }
 
         /// <summary>
-        /// Gets the element's height
+        /// Gets the element's height.
         /// </summary>
         public int Height { get; internal set; }
     }

lib/PuppeteerSharp/BoxModelPoint.cs

@@ -1,17 +1,17 @@
 namespace PuppeteerSharp
 {
     /// <summary>
-    /// Represents a point
+    /// Represents a point.
     /// </summary>
     public struct BoxModelPoint
     {
         /// <summary>
-        /// The X coordinate
+        /// The X coordinate.
         /// </summary>
         public decimal X { get; set; }
 
         /// <summary>
-        /// The y coordinate
+        /// The y coordinate.
         /// </summary>
         public decimal Y { get; set; }
     }

lib/PuppeteerSharp/Browser.cs

@@ -217,7 +217,7 @@ public void Dispose()
         /// Closes <see cref="Connection"/> and any Chromium <see cref="Process"/> that was
         /// created by Puppeteer.
         /// </summary>
-        /// <returns>ValueTask</returns>
+        /// <returns>ValueTask.</returns>
         public ValueTask DisposeAsync() => new ValueTask(CloseAsync());
 
         internal static async Task<Browser> CreateAsync(

lib/PuppeteerSharp/BrowserFetcherOptions.cs

@@ -4,15 +4,15 @@
 namespace PuppeteerSharp
 {
     /// <summary>
-    /// Browser fetcher options used to construct a <see cref="BrowserFetcher"/>
+    /// Browser fetcher options used to construct a <see cref="BrowserFetcher"/>.
     /// </summary>
     public class BrowserFetcherOptions
     {
         /// <summary>
-        /// A custom download delegate
+        /// A custom download delegate.
         /// </summary>
-        /// <param name="address">address</param>
-        /// <param name="fileName">fileName</param>
+        /// <param name="address">address.</param>
+        /// <param name="fileName">fileName.</param>
         /// <returns>A Task that resolves when the download finishes.</returns>
         public delegate Task CustomFileDownloadAction(string address, string fileName);
 
@@ -37,7 +37,7 @@ public class BrowserFetcherOptions
         public string Host { get; set; }
 
         /// <summary>
-        /// Gets the default or a custom download delegate
+        /// Gets the default or a custom download delegate.
         /// </summary>
         public CustomFileDownloadAction CustomFileDownload { get; set; }
     }

lib/PuppeteerSharp/Connection.cs

@@ -14,7 +14,7 @@
 namespace PuppeteerSharp
 {
     /// <summary>
-    /// A connection handles the communication with a Chromium browser
+    /// A connection handles the communication with a Chromium browser.
     /// </summary>
     public class Connection : IDisposable
     {

lib/PuppeteerSharp/ConsoleMessage.cs

@@ -13,7 +13,7 @@ public class ConsoleMessage
         /// <param name="type">Type.</param>
         /// <param name="text">Text.</param>
         /// <param name="args">Arguments.</param>
-        /// <param name="location">Message location</param>
+        /// <param name="location">Message location.</param>
         public ConsoleMessage(ConsoleType type, string text, IList<IJSHandle> args, ConsoleMessageLocation location = null)
         {
             Type = type;

lib/PuppeteerSharp/Credentials.cs

@@ -1,17 +1,17 @@
 namespace PuppeteerSharp
 {
     /// <summary>
-    /// Options to be used in <see cref="IPage.AuthenticateAsync(Credentials)"/>
+    /// Options to be used in <see cref="IPage.AuthenticateAsync(Credentials)"/>.
     /// </summary>
     public class Credentials
     {
         /// <summary>
-        /// Gets or sets the username to be used for authentication
+        /// Gets or sets the username to be used for authentication.
         /// </summary>
         public string Username { get; set; }
 
         /// <summary>
-        /// Gets or sets the password to be used for authentication
+        /// Gets or sets the password to be used for authentication.
         /// </summary>
         public string Password { get; set; }
     }

lib/PuppeteerSharp/DOMWorldType.cs

@@ -8,18 +8,18 @@ namespace PuppeteerSharp
     internal enum DOMWorldType
     {
         /// <summary>
-        /// Other type
+        /// Other type.
         /// </summary>
         Other,
 
         /// <summary>
-        /// Isolated type
+        /// Isolated type.
         /// </summary>
         [EnumMember(Value = "isolated")]
         Isolated,
 
         /// <summary>
-        /// Default type
+        /// Default type.
         /// </summary>
         [EnumMember(Value = "default")]
         Default,

lib/PuppeteerSharp/DragData.cs

@@ -6,7 +6,7 @@
     public partial class DragData
     {
         /// <summary>
-        /// Drag items
+        /// Drag items.
         /// </summary>
         public DragDataItem[] Items { get; set; }