Enabled and fixed issues for the rule SA1514. (#2012)

Author: MursalovAltun

lib/PuppeteerSharp.ruleset

@@ -13,7 +13,7 @@
     <Rule Id="SA1600" Action="None" /> <!-- Error SA1600: Elements should be documented (SA1600)-->
     <Rule Id="SA1516" Action="Error" /> <!-- Error SA1516: Elements should be separated by blank line (SA1516)-->
     <Rule Id="SA1629" Action="None" /> <!-- Error SA1629: Documentation text should end with a period (SA1629)-->
-    <Rule Id="SA1514" Action="None" /> <!-- Error SA1514: Element documentation header should be preceded by blank line (SA1514)-->
+    <Rule Id="SA1514" Action="Error" /> <!-- Error SA1514: Element documentation header should be preceded by blank line (SA1514)-->
     <Rule Id="SA1201" Action="Error" /> <!-- Error SA1201: Elements must appear in the correct order (SA1201)-->
     <Rule Id="SA1202" Action="None" /> <!-- Error SA1202: 'public' members should come before 'internal' members (SA1202)-->
     <Rule Id="SA1210" Action="Error" /> <!-- Error SA1210: Using directives should be ordered alphabetically by the namespaces. (SA1210)-->

lib/PuppeteerSharp/BoundingBox.cs

@@ -36,16 +36,19 @@ public BoundingBox(decimal x, decimal y, decimal width, decimal height)
         /// </summary>
         /// <value>The x.</value>
         public decimal X { get; set; }
+
         /// <summary>
         /// The y coordinate of the element in pixels.
         /// </summary>
         /// <value>The y.</value>
         public decimal Y { get; set; }
+
         /// <summary>
         /// The width of the element in pixels.
         /// </summary>
         /// <value>The width.</value>
         public decimal Width { get; set; }
+
         /// <summary>
         /// The height of the element in pixels.
         /// </summary>

lib/PuppeteerSharp/Browser.cs

@@ -149,6 +149,7 @@ public bool IsClosed
         /// Dafault wait time in milliseconds. Defaults to 30 seconds.
         /// </summary>
         public int DefaultWaitForTimeout { get; set; } = Puppeteer.DefaultTimeout;
+
         /// <summary>
         /// Indicates that the browser is connected.
         /// </summary>

lib/PuppeteerSharp/ConsoleType.cs

@@ -11,78 +11,97 @@ public enum ConsoleType
         /// Log.
         /// </summary>
         Log,
+
         /// <summary>
         /// Debug.
         /// </summary>
         Debug,
+
         /// <summary>
         /// Info.
         /// </summary>
         Info,
+
         /// <summary>
         /// Error.
         /// </summary>
         Error,
+
         /// <summary>
         /// Warning.
         /// </summary>
         Warning,
+
         /// <summary>
         /// Dir.
         /// </summary>
         Dir,
+
         /// <summary>
         /// Dirxml.
         /// </summary>
         Dirxml,
+
         /// <summary>
         /// Table.
         /// </summary>
         Table,
+
         /// <summary>
         /// Trace.
         /// </summary>
         Trace,
+
         /// <summary>
         /// Clear.
         /// </summary>
         Clear,
+
         /// <summary>
         /// StartGroup.
         /// </summary>
         StartGroup,
+
         /// <summary>
         /// StartGroupCollapsed.
         /// </summary>
         StartGroupCollapsed,
+
         /// <summary>
         /// EndGroup.
         /// </summary>
         EndGroup,
+
         /// <summary>
         /// Assert.
         /// </summary>
         Assert,
+
         /// <summary>
         /// Profile.
         /// </summary>
         Profile,
+
         /// <summary>
         /// ProfileEnd.
         /// </summary>
         ProfileEnd,
+
         /// <summary>
         /// Count.
         /// </summary>
         Count,
+
         /// <summary>
         /// TimeEnd.
         /// </summary>
         TimeEnd,
+
         /// <summary>
         /// Verbose.
         /// </summary>
         Verbose,
+
         /// <summary>
         /// Time Stamp.
         /// </summary>

lib/PuppeteerSharp/CookieParam.cs

@@ -15,59 +15,70 @@ public class CookieParam
         /// </summary>
         /// <value>The name.</value>
         public string Name { get; set; }
+
         /// <summary>
         /// Gets or sets the value.
         /// </summary>
         /// <value>The value.</value>
         public string Value { get; set; }
+
         /// <summary>
         /// Gets or sets the domain.
         /// </summary>
         /// <value>The domain.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public string Domain { get; set; }
+
         /// <summary>
         /// Gets or sets the URL.
         /// </summary>
         /// <value>The URL.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public string Url { get; set; }
+
         /// <summary>
         /// Gets or sets the path.
         /// </summary>
         /// <value>The path.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public string Path { get; set; }
+
         /// <summary>
         /// Gets or sets the expiration. Unix time in seconds.
         /// </summary>
         /// <value>Expiration.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public double? Expires { get; set; }
+
         /// <summary>
         /// Gets or sets the size.
         /// </summary>
         /// <value>The size.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
+
         public int? Size { get; set; }
+
         /// <summary>
         /// Gets or sets if it's HTTP only.
         /// </summary>
         /// <value>Whether it's http only or not.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public bool? HttpOnly { get; set; }
+
         /// <summary>
         /// Gets or sets if it's secure.
         /// </summary>
         /// <value>Whether it's secure or not.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public bool? Secure { get; set; }
+
         /// <summary>
         /// Gets or sets if it's session only.
         /// </summary>
         /// <value>Whether it's session only or not.</value>
         [JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
         public bool? Session { get; set; }
+
         /// <summary>
         /// Gets or sets the cookies SameSite value.
         /// </summary>

lib/PuppeteerSharp/Dialog.cs

@@ -43,11 +43,13 @@ public Dialog(CDPSession client, DialogType type, string message, string default
         /// </summary>
         /// <value>The type of the dialog.</value>
         public DialogType DialogType { get; set; }
+
         /// <summary>
         /// If dialog is prompt, returns default prompt value. Otherwise, returns empty string.
         /// </summary>
         /// <value>The default value.</value>
         public string DefaultValue { get; set; }
+
         /// <summary>
         /// A message displayed in the dialog.
         /// </summary>

lib/PuppeteerSharp/DialogType.cs

@@ -12,14 +12,17 @@ public enum DialogType
         /// Alert dialog.
         /// </summary>
         Alert,
+
         /// <summary>
         /// Prompt dialog.
         /// </summary>
         Prompt,
+
         /// <summary>
         /// Confirm dialog.
         /// </summary>
         Confirm,
+
         /// <summary>
         /// Before unload dialog.
         /// </summary>

lib/PuppeteerSharp/DragOperation.cs

@@ -1,4 +1,4 @@
-namespace PuppeteerSharp
+namespace PuppeteerSharp
 {
     /// <summary>
     /// Drag operations available on <see cref="DragData"/>.
@@ -9,14 +9,17 @@ public enum DragOperation
         /// Unknown.
         /// </summary>
         Unknown = -1,
+
         /// <summary>
         /// Copy.
         /// </summary>
         Copy = 1,
+
         /// <summary>
         /// Link.
         /// </summary>
         Link = 2,
+
         /// <summary>
         /// Move.
         /// </summary>

lib/PuppeteerSharp/GeolocationOption.cs

@@ -14,11 +14,13 @@ public class GeolocationOption : IEquatable<GeolocationOption>
         /// </summary>
         /// <value>The latitude.</value>
         public decimal Latitude { get; set; }
+
         /// <summary>
         /// Longitude between -180 and 180.
         /// </summary>
         /// <value>The longitude.</value>
         public decimal Longitude { get; set; }
+
         /// <summary>
         /// Optional non-negative accuracy value.
         /// </summary>
@@ -36,8 +38,10 @@ public bool Equals(GeolocationOption other)
                 Latitude == other.Latitude &&
                 Longitude == other.Longitude &&
                 Accuracy == other.Accuracy;
+
         /// <inheritdoc/>
         public override bool Equals(object obj) => Equals(obj as GeolocationOption);
+
         /// <inheritdoc/>
         public override int GetHashCode()
             => (Latitude.GetHashCode() ^ 2014) +

lib/PuppeteerSharp/Helpers/TaskHelper.cs

@@ -13,6 +13,7 @@ public static class TaskHelper
             timeout => new TimeoutException($"Timeout of {timeout.TotalMilliseconds} ms exceeded");
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after <paramref name="milliseconds"/> milliseconds
         /// </summary>
@@ -29,6 +30,7 @@ public static Task WithTimeout(
             => WithTimeout(task, TimeSpan.FromMilliseconds(milliseconds), exceptionFactory, cancellationToken);
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after a given <paramref name="timeout"/> period
         /// </summary>
@@ -48,6 +50,7 @@ public static Task WithTimeout(
                 cancellationToken);
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after <paramref name="milliseconds"/> milliseconds
         /// </summary>
@@ -64,6 +67,7 @@ public static Task WithTimeout(
             => WithTimeout(task, timeoutAction, TimeSpan.FromMilliseconds(milliseconds), cancellationToken);
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after a given <paramref name="timeout"/> period
         /// </summary>
@@ -92,6 +96,7 @@ public static async Task WithTimeout(this Task task, Func<Task> timeoutAction, T
         }
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after <paramref name="milliseconds"/> milliseconds
         /// </summary>
@@ -104,6 +109,7 @@ public static Task<T> WithTimeout<T>(this Task<T> task, Action timeoutAction, in
             => WithTimeout(task, timeoutAction, TimeSpan.FromMilliseconds(milliseconds));
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after a given <paramref name="timeout"/> period
         /// </summary>
@@ -134,6 +140,7 @@ public static async Task<T> WithTimeout<T>(this Task<T> task, Action timeoutActi
         }
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after <paramref name="milliseconds"/> milliseconds
         /// </summary>
@@ -146,6 +153,7 @@ public static Task<T> WithTimeout<T>(this Task<T> task, int milliseconds = 1_000
             => WithTimeout(task, TimeSpan.FromMilliseconds(milliseconds), exceptionFactory);
 
         // Recipe from https://blogs.msdn.microsoft.com/pfxteam/2012/10/05/how-do-i-cancel-non-cancelable-async-operations/
+
         /// <summary>
         /// Cancels the <paramref name="task"/> after a given <paramref name="timeout"/> period
         /// </summary>