Include UrlFragment to Frame Url (#1853)

Author: kblok

lib/PuppeteerSharp.TestServer/wwwroot/frames/frameset.html

@@ -0,0 +1,8 @@
+<frameset>
+  <frameset>
+    <frame src='./frame.html'></frame>
+    <frame src='about:blank'></frame>
+  </frameset>
+  <frame src='/empty.html'></frame>
+  <frame></frame>
+</frameset>

lib/PuppeteerSharp.TestServer/wwwroot/frames/one-frame-url-fragment.html

@@ -0,0 +1 @@
+<iframe src='./frame.html?param=value#fragment'></iframe>

lib/PuppeteerSharp.Tests/FrameTests/FrameManagementTests.cs

@@ -71,6 +71,15 @@ await Task.WhenAll(
             Assert.Equal(TestConstants.EmptyPage + "#foo", Page.Url);
         }
 
+        [PuppeteerTest("frame.spec.ts", "Frame Management", "should support url fragment")]
+        [PuppeteerFact]
+        public async Task ShouldReturnUrlFragmentAsPartOfUrl()
+        {
+            await Page.GoToAsync(TestConstants.ServerUrl + "/frames/one-frame-url-fragment.html");
+            Assert.Equal(2, Page.Frames.Length);
+            Assert.Equal(TestConstants.ServerUrl + "/frames/frame.html?param=value#fragment", Page.FirstChildFrame().Url);
+        }
+
         [PuppeteerTest("frame.spec.ts", "Frame Management", "should persist mainFrame on cross-process navigation")]
         [PuppeteerFact]
         public async Task ShouldPersistMainFrameOnCrossProcessNavigation()

lib/PuppeteerSharp.Tests/RequestInterceptionTests/SetRequestInterceptionTests.cs

@@ -423,7 +423,7 @@ public async Task ShouldWorkWithEqualRequests()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
             var responseCount = 1;
-            Server.SetRoute("/zzz", context => context.Response.WriteAsync((responseCount++) * 11 + string.Empty));
+            Server.SetRoute("/zzz", context => context.Response.WriteAsync(((responseCount++) * 11) + string.Empty));
             await Page.SetRequestInterceptionAsync(true);
 
             var spinner = false;

lib/PuppeteerSharp/Frame.cs

@@ -587,8 +587,8 @@ internal void OnLifecycleEvent(string loaderId, string name)
         internal void Navigated(FramePayload framePayload)
         {
             Name = framePayload.Name ?? string.Empty;
-            NavigationURL = framePayload.Url;
-            Url = framePayload.Url;
+            NavigationURL = framePayload.Url + framePayload.UrlFragment;
+            Url = framePayload.Url + framePayload.UrlFragment;
         }
 
         internal void NavigatedWithinDocument(string url) => Url = url;

lib/PuppeteerSharp/FramePayload.cs

@@ -11,5 +11,7 @@ internal class FramePayload
         public string Name { get; set; }
 
         public string Url { get; set; }
+
+        public string UrlFragment { get; set; }
     }
 }