Merge pull request #2735 from hardkoded/rename-ignorehttpserrors

kblok · web-flow · commit dcce7ed3b4ed · 2024-08-14T12:29:34.000-03:00
Rename IgnoreHTTPSErrors to AcceptInsecureCerts
diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
@@ -453,7 +453,7 @@
   },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[ignorehttpserrors.spec] *",
+    "testIdPattern": "[acceptInsecureCerts.spec] *",
     "platforms": [
       "darwin",
       "linux",
diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json
@@ -1727,77 +1727,77 @@
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["chrome", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "firefox"],
     "expectations": ["FAIL", "PASS"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails Network redirects should report SecurityDetails",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["firefox", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails should be |null| for non-secure requests",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails should be |null| for non-secure requests",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["chrome", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails should be |null| for non-secure requests",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails should be |null| for non-secure requests",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["firefox", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails should work",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails should work",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["chrome", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails should work",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails should work",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "firefox"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors Response.securityDetails should work",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors Response.securityDetails should work",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["firefox", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors should work with request interception",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors should work with request interception",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["chrome", "webDriverBiDi"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors should work with request interception",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors should work with request interception",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["cdp", "firefox"],
     "expectations": ["FAIL"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
   {
-    "testIdPattern": "[ignorehttpserrors.spec] ignoreHTTPSErrors should work with request interception",
+    "testIdPattern": "[acceptInsecureCerts.spec] ignoreHTTPSErrors should work with request interception",
     "platforms": ["darwin", "linux", "win32"],
     "parameters": ["firefox", "webDriverBiDi"],
     "expectations": ["FAIL"],
diff --git a/lib/PuppeteerSharp.Tests/BFCacheTests/BFCacheTests.cs b/lib/PuppeteerSharp.Tests/BFCacheTests/BFCacheTests.cs
@@ -10,7 +10,7 @@ public class BFCacheTests : PuppeteerPageBaseTest
     public BFCacheTests()
     {
         DefaultOptions = TestConstants.DefaultBrowserOptions();
-        DefaultOptions.IgnoreHTTPSErrors = true;
+        DefaultOptions.AcceptInsecureCerts = true;
     }
 
     [Test, Retry(2), PuppeteerTest("bfcache.spec", "BFCache", "can navigate to a BFCached page")]
diff --git a/lib/PuppeteerSharp.Tests/CookiesTests/SetCookiesTests.cs b/lib/PuppeteerSharp.Tests/CookiesTests/SetCookiesTests.cs
@@ -347,7 +347,7 @@ await Page.EvaluateFunctionAsync(@"src => {
         public async Task ShouldSetSecureSameSiteCookiesFromAFrame()
         {
             var options = TestConstants.DefaultBrowserOptions();
-            options.IgnoreHTTPSErrors = true;
+            options.AcceptInsecureCerts = true;
 
             await using var browser = await Puppeteer.LaunchAsync(options, TestConstants.LoggerFactory);
             await using var page = await browser.NewPageAsync();
diff --git a/lib/PuppeteerSharp.Tests/IgnoreHttpsErrorsTests/AcceptInsecureCertsTests.cs b/lib/PuppeteerSharp.Tests/IgnoreHttpsErrorsTests/AcceptInsecureCertsTests.cs
@@ -6,22 +6,22 @@
 
 namespace PuppeteerSharp.Tests.IgnoreHttpsErrorsTests
 {
-    public class IgnoreHttpsErrorsTests : PuppeteerPageBaseTest
+    public class AcceptInsecureCertsTests : PuppeteerPageBaseTest
     {
-        public IgnoreHttpsErrorsTests() : base()
+        public AcceptInsecureCertsTests() : base()
         {
             DefaultOptions = TestConstants.DefaultBrowserOptions();
-            DefaultOptions.IgnoreHTTPSErrors = true;
+            DefaultOptions.AcceptInsecureCerts = true;
         }
 
-        [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "ignoreHTTPSErrors", "should work")]
+        [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "ignoreHTTPSErrors", "should work")]
         public async Task ShouldWork()
         {
             var response = await Page.GoToAsync($"{TestConstants.HttpsPrefix}/empty.html");
             Assert.That(response.Ok, Is.True);
         }
 
-        [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "ignoreHTTPSErrors", "should work with request interception")]
+        [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "ignoreHTTPSErrors", "should work with request interception")]
         public async Task ShouldWorkWithRequestInterception()
         {
             await Page.SetRequestInterceptionAsync(true);
@@ -30,7 +30,7 @@ public async Task ShouldWorkWithRequestInterception()
             Assert.That(response.Status, Is.EqualTo(HttpStatusCode.OK));
         }
 
-        [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "ignoreHTTPSErrors", "should work with mixed content")]
+        [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "ignoreHTTPSErrors", "should work with mixed content")]
         public async Task ShouldWorkWithMixedContent()
         {
             HttpsServer.SetRoute("/mixedcontent.html", async (context) =>
diff --git a/lib/PuppeteerSharp.Tests/IgnoreHttpsErrorsTests/ResponseSecurityDetailsTests.cs b/lib/PuppeteerSharp.Tests/IgnoreHttpsErrorsTests/ResponseSecurityDetailsTests.cs
@@ -13,10 +13,10 @@ public class ResponseSecurityDetailsTests : PuppeteerPageBaseTest
         public ResponseSecurityDetailsTests() : base()
         {
             DefaultOptions = TestConstants.DefaultBrowserOptions();
-            DefaultOptions.IgnoreHTTPSErrors = true;
+            DefaultOptions.AcceptInsecureCerts = true;
         }
 
-        [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "Response.securityDetails", "Should Work")]
+        [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "Response.securityDetails", "Should Work")]
         public async Task ShouldWork()
         {
             // Checking for the TLS socket is it is in upstreams proves to be flaky in .net framework.
@@ -28,14 +28,14 @@ public async Task ShouldWork()
             Assert.That(response.SecurityDetails.Protocol, Does.Contain("TLS"));
         }
 
-        [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "Response.securityDetails", "should be |null| for non-secure requests")]
+        [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "Response.securityDetails", "should be |null| for non-secure requests")]
         public async Task ShouldBeNullForNonSecureRequests()
         {
             var response = await Page.GoToAsync(TestConstants.EmptyPage);
             Assert.That(response.SecurityDetails, Is.Null);
         }
 
-        [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "Response.securityDetails", "Network redirects should report SecurityDetails")]
+        [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "Response.securityDetails", "Network redirects should report SecurityDetails")]
         [Ignore("This is super flaky")]
         public async Task NetworkRedirectsShouldReportSecurityDetails()
         {
diff --git a/lib/PuppeteerSharp.Tests/LauncherTests/PuppeteerConnectTests.cs b/lib/PuppeteerSharp.Tests/LauncherTests/PuppeteerConnectTests.cs
@@ -54,7 +54,7 @@ public async Task ShouldSupportIgnoreHTTPSErrorsOption()
             await using var browser = await Puppeteer.ConnectAsync(new ConnectOptions
             {
                 BrowserWSEndpoint = originalBrowser.WebSocketEndpoint,
-                IgnoreHTTPSErrors = true
+                AcceptInsecureCerts = true
             });
             await using var page = await browser.NewPageAsync();
             var requestTask = HttpsServer.WaitForRequest(
diff --git a/lib/PuppeteerSharp.Tests/LauncherTests/PuppeteerLaunchTests.cs b/lib/PuppeteerSharp.Tests/LauncherTests/PuppeteerLaunchTests.cs
@@ -18,7 +18,7 @@ public class PuppeteerLaunchTests : PuppeteerBaseTest
         public async Task ShouldWorkInRealLife()
         {
             var options = TestConstants.DefaultBrowserOptions();
-            options.IgnoreHTTPSErrors = true;
+            options.AcceptInsecureCerts = true;
 
             await using var browser = await Puppeteer.LaunchAsync(options, TestConstants.LoggerFactory);
             await using var page = await browser.NewPageAsync();
diff --git a/lib/PuppeteerSharp/Browser.cs b/lib/PuppeteerSharp/Browser.cs
@@ -39,7 +39,7 @@ public abstract class Browser : IBrowser
         public Process Process => Launcher?.Process;
 
         /// <inheritdoc/>
-        public bool IgnoreHTTPSErrors { get; set; }
+        public bool AcceptInsecureCerts { get; set; }
 
         /// <inheritdoc/>
         public abstract bool IsClosed { get; }
diff --git a/lib/PuppeteerSharp/Cdp/CdpBrowser.cs b/lib/PuppeteerSharp/Cdp/CdpBrowser.cs
@@ -46,14 +46,14 @@ internal CdpBrowser(
         SupportedBrowser browser,
         Connection connection,
         string[] contextIds,
-        bool ignoreHTTPSErrors,
+        bool acceptInsecureCerts,
         ViewPortOptions defaultViewport,
         LauncherBase launcher,
         Func<Target, bool> targetFilter = null,
         Func<Target, bool> isPageTargetFunc = null)
     {
         BrowserType = browser;
-        IgnoreHTTPSErrors = ignoreHTTPSErrors;
+        AcceptInsecureCerts = acceptInsecureCerts;
         DefaultViewport = defaultViewport;
         Launcher = launcher;
         Connection = connection;
@@ -157,7 +157,7 @@ internal static async Task<CdpBrowser> CreateAsync(
         SupportedBrowser browserToCreate,
         Connection connection,
         string[] contextIds,
-        bool ignoreHTTPSErrors,
+        bool acceptInsecureCerts,
         ViewPortOptions defaultViewPort,
         LauncherBase launcher,
         Func<Target, bool> targetFilter = null,
@@ -168,7 +168,7 @@ internal static async Task<CdpBrowser> CreateAsync(
             browserToCreate,
             connection,
             contextIds,
-            ignoreHTTPSErrors,
+            acceptInsecureCerts,
             defaultViewPort,
             launcher,
             targetFilter,
@@ -267,7 +267,7 @@ private CdpTarget CreateTarget(TargetInfo targetInfo, CDPSession session, CDPSes
                 context,
                 TargetManager,
                 CreateSession,
-                IgnoreHTTPSErrors,
+                AcceptInsecureCerts,
                 DefaultViewport,
                 ScreenshotTaskQueue);
         }
@@ -280,7 +280,7 @@ private CdpTarget CreateTarget(TargetInfo targetInfo, CDPSession session, CDPSes
                 context,
                 TargetManager,
                 CreateSession,
-                IgnoreHTTPSErrors,
+                AcceptInsecureCerts,
                 DefaultViewport,
                 ScreenshotTaskQueue);
         }
diff --git a/lib/PuppeteerSharp/Cdp/CdpDevToolsTarget.cs b/lib/PuppeteerSharp/Cdp/CdpDevToolsTarget.cs
@@ -15,10 +15,10 @@ internal CdpDevToolsTarget(
             BrowserContext context,
             ITargetManager targetManager,
             Func<bool, Task<CDPSession>> sessionFactory,
-            bool ignoreHTTPSErrors,
+            bool acceptInsecureCerts,
             ViewPortOptions defaultViewport,
             TaskQueue screenshotTaskQueue)
-            : base(targetInfo, session, context, targetManager, sessionFactory, ignoreHTTPSErrors, defaultViewport, screenshotTaskQueue)
+            : base(targetInfo, session, context, targetManager, sessionFactory, acceptInsecureCerts, defaultViewport, screenshotTaskQueue)
         {
         }
 
diff --git a/lib/PuppeteerSharp/Cdp/CdpPage.cs b/lib/PuppeteerSharp/Cdp/CdpPage.cs
@@ -65,7 +65,7 @@ private CdpPage(
         CdpCDPSession client,
         CdpTarget target,
         TaskQueue screenshotTaskQueue,
-        bool ignoreHTTPSErrors) : base(screenshotTaskQueue)
+        bool acceptInsecureCerts) : base(screenshotTaskQueue)
     {
         PrimaryTargetClient = client;
         TabTargetClient = (CdpCDPSession)client.ParentSession;
@@ -80,7 +80,7 @@ private CdpPage(
 
         _emulationManager = new EmulationManager(client);
         _logger = Client.Connection.LoggerFactory.CreateLogger<Page>();
-        FrameManager = new FrameManager(client, this, ignoreHTTPSErrors, TimeoutSettings);
+        FrameManager = new FrameManager(client, this, acceptInsecureCerts, TimeoutSettings);
         Accessibility = new Accessibility(client);
 
         FrameManager.FrameAttached += (_, e) => OnFrameAttached(e);
@@ -715,11 +715,11 @@ await PrimaryTargetClient.Connection
     internal static async Task<Page> CreateAsync(
         CdpCDPSession client,
         CdpTarget target,
-        bool ignoreHTTPSErrors,
+        bool acceptInsecureCerts,
         ViewPortOptions defaultViewPort,
         TaskQueue screenshotTaskQueue)
     {
-        var page = new CdpPage(client, target, screenshotTaskQueue, ignoreHTTPSErrors);
+        var page = new CdpPage(client, target, screenshotTaskQueue, acceptInsecureCerts);
 
         try
         {
diff --git a/lib/PuppeteerSharp/Cdp/CdpPageTarget.cs b/lib/PuppeteerSharp/Cdp/CdpPageTarget.cs
@@ -9,7 +9,7 @@ namespace PuppeteerSharp.Cdp
     /// </summary>
     public class CdpPageTarget : CdpTarget
     {
-        private readonly bool _ignoreHTTPSErrors;
+        private readonly bool _acceptInsecureCerts;
         private readonly ViewPortOptions _defaultViewport;
         private readonly TaskQueue _screenshotTaskQueue;
 
@@ -19,12 +19,12 @@ internal CdpPageTarget(
             BrowserContext context,
             ITargetManager targetManager,
             Func<bool, Task<CDPSession>> sessionFactory,
-            bool ignoreHTTPSErrors,
+            bool acceptInsecureCerts,
             ViewPortOptions defaultViewport,
             TaskQueue screenshotTaskQueue)
             : base(targetInfo, (CdpCDPSession)session, (CdpBrowserContext)context, targetManager, sessionFactory, screenshotTaskQueue)
         {
-            _ignoreHTTPSErrors = ignoreHTTPSErrors;
+            _acceptInsecureCerts = acceptInsecureCerts;
             _defaultViewport = defaultViewport;
             _screenshotTaskQueue = screenshotTaskQueue;
             PageTask = null;
@@ -42,7 +42,7 @@ public override async Task<IPage> PageAsync()
                 PageTask = CdpPage.CreateAsync(
                     session,
                     this,
-                    _ignoreHTTPSErrors,
+                    _acceptInsecureCerts,
                     _defaultViewport,
                     _screenshotTaskQueue);
             }
diff --git a/lib/PuppeteerSharp/Cdp/FrameManager.cs b/lib/PuppeteerSharp/Cdp/FrameManager.cs
@@ -24,12 +24,12 @@ internal class FrameManager : IDisposable, IAsyncDisposable, IFrameProvider
         private readonly ConcurrentDictionary<CDPSession, DeviceRequestPromptManager> _deviceRequestPromptManagerMap = new();
         private TaskCompletionSource<bool> _frameTreeHandled = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
-        internal FrameManager(CDPSession client, Page page, bool ignoreHTTPSErrors, TimeoutSettings timeoutSettings)
+        internal FrameManager(CDPSession client, Page page, bool acceptInsecureCerts, TimeoutSettings timeoutSettings)
         {
             Client = client;
             Page = page;
             _logger = Client.Connection.LoggerFactory.CreateLogger<FrameManager>();
-            NetworkManager = new NetworkManager(ignoreHTTPSErrors, this, client.Connection.LoggerFactory);
+            NetworkManager = new NetworkManager(acceptInsecureCerts, this, client.Connection.LoggerFactory);
             TimeoutSettings = timeoutSettings;
 
             Client.MessageReceived += Client_MessageReceived;
diff --git a/lib/PuppeteerSharp/Cdp/NetworkManager.cs b/lib/PuppeteerSharp/Cdp/NetworkManager.cs
@@ -13,7 +13,7 @@ namespace PuppeteerSharp.Cdp
 {
     internal class NetworkManager
     {
-        private readonly bool _ignoreHTTPSErrors;
+        private readonly bool _acceptInsecureCerts;
         private readonly NetworkEventManager _networkEventManager = new();
         private readonly ILogger _logger;
         private readonly ConcurrentSet<string> _attemptedAuthentications = [];
@@ -33,13 +33,13 @@ internal class NetworkManager
         /// <summary>
         /// Initializes a new instance of the <see cref="NetworkManager"/> class.
         /// </summary>
-        /// <param name="ignoreHTTPSErrors">If set to <c>true</c> ignore http errors.</param>
+        /// <param name="acceptInsecureCerts">If set to <c>true</c> ignore http errors.</param>
         /// <param name="frameManager">Frame manager.</param>
         /// <param name="loggerFactory">Logger factory.</param>
-        internal NetworkManager(bool ignoreHTTPSErrors, IFrameProvider frameManager, ILoggerFactory loggerFactory)
+        internal NetworkManager(bool acceptInsecureCerts, IFrameProvider frameManager, ILoggerFactory loggerFactory)
         {
             _frameManager = frameManager;
-            _ignoreHTTPSErrors = ignoreHTTPSErrors;
+            _acceptInsecureCerts = acceptInsecureCerts;
             _loggerFactory = loggerFactory;
             _logger = loggerFactory.CreateLogger<NetworkManager>();
         }
@@ -71,7 +71,7 @@ internal Task AddClientAsync(ICDPSession client)
             subscriptions.Defer(() => client.MessageReceived -= Client_MessageReceived);
 
             return Task.WhenAll(
-                _ignoreHTTPSErrors ? client.SendAsync("Security.setIgnoreCertificateErrors", new SecuritySetIgnoreCertificateErrorsRequest { Ignore = true }) : Task.CompletedTask,
+                _acceptInsecureCerts ? client.SendAsync("Security.setIgnoreCertificateErrors", new SecuritySetIgnoreCertificateErrorsRequest { Ignore = true }) : Task.CompletedTask,
                 client.SendAsync("Network.enable"),
                 ApplyExtraHTTPHeadersAsync(client),
                 ApplyNetworkConditionsAsync(client),
diff --git a/lib/PuppeteerSharp/ConnectOptions.cs b/lib/PuppeteerSharp/ConnectOptions.cs
diff --git a/lib/PuppeteerSharp/IBrowser.cs b/lib/PuppeteerSharp/IBrowser.cs
diff --git a/lib/PuppeteerSharp/IBrowserOptions.cs b/lib/PuppeteerSharp/IBrowserOptions.cs
diff --git a/lib/PuppeteerSharp/LaunchOptions.cs b/lib/PuppeteerSharp/LaunchOptions.cs
diff --git a/lib/PuppeteerSharp/Launcher.cs b/lib/PuppeteerSharp/Launcher.cs

Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,7 @@`
`453`	`453`	`},`
`454`	`454`	`{`
`455`	`455`	`"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",`
`456`		`- "testIdPattern": "[ignorehttpserrors.spec] *",`
	`456`	`+ "testIdPattern": "[acceptInsecureCerts.spec] *",`
`457`	`457`	`"platforms": [`
`458`	`458`	`"darwin",`
`459`	`459`	`"linux",`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public class BFCacheTests : PuppeteerPageBaseTest`
`10`	`10`	`public BFCacheTests()`
`11`	`11`	`{`
`12`	`12`	`DefaultOptions = TestConstants.DefaultBrowserOptions();`
`13`		`- DefaultOptions.IgnoreHTTPSErrors = true;`
	`13`	`+ DefaultOptions.AcceptInsecureCerts = true;`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`[Test, Retry(2), PuppeteerTest("bfcache.spec", "BFCache", "can navigate to a BFCached page")]`
Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ await Page.EvaluateFunctionAsync(@"src => {`
`347`	`347`	`public async Task ShouldSetSecureSameSiteCookiesFromAFrame()`
`348`	`348`	`{`
`349`	`349`	`var options = TestConstants.DefaultBrowserOptions();`
`350`		`- options.IgnoreHTTPSErrors = true;`
	`350`	`+ options.AcceptInsecureCerts = true;`
`351`	`351`
`352`	`352`	`await using var browser = await Puppeteer.LaunchAsync(options, TestConstants.LoggerFactory);`
`353`	`353`	`await using var page = await browser.NewPageAsync();`
Original file line number	Diff line number	Diff line change
`@@ -6,22 +6,22 @@`
`6`	`6`
`7`	`7`	`namespace PuppeteerSharp.Tests.IgnoreHttpsErrorsTests`
`8`	`8`	`{`
`9`		`- public class IgnoreHttpsErrorsTests : PuppeteerPageBaseTest`
	`9`	`+ public class AcceptInsecureCertsTests : PuppeteerPageBaseTest`
`10`	`10`	`{`
`11`		`- public IgnoreHttpsErrorsTests() : base()`
	`11`	`+ public AcceptInsecureCertsTests() : base()`
`12`	`12`	`{`
`13`	`13`	`DefaultOptions = TestConstants.DefaultBrowserOptions();`
`14`		`- DefaultOptions.IgnoreHTTPSErrors = true;`
	`14`	`+ DefaultOptions.AcceptInsecureCerts = true;`
`15`	`15`	`}`
`16`	`16`
`17`		`- [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "ignoreHTTPSErrors", "should work")]`
	`17`	`+ [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "ignoreHTTPSErrors", "should work")]`
`18`	`18`	`public async Task ShouldWork()`
`19`	`19`	`{`
`20`	`20`	`var response = await Page.GoToAsync($"{TestConstants.HttpsPrefix}/empty.html");`
`21`	`21`	`Assert.That(response.Ok, Is.True);`
`22`	`22`	`}`
`23`	`23`
`24`		`- [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "ignoreHTTPSErrors", "should work with request interception")]`
	`24`	`+ [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "ignoreHTTPSErrors", "should work with request interception")]`
`25`	`25`	`public async Task ShouldWorkWithRequestInterception()`
`26`	`26`	`{`
`27`	`27`	`await Page.SetRequestInterceptionAsync(true);`
`@@ -30,7 +30,7 @@ public async Task ShouldWorkWithRequestInterception()`
`30`	`30`	`Assert.That(response.Status, Is.EqualTo(HttpStatusCode.OK));`
`31`	`31`	`}`
`32`	`32`
`33`		`- [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "ignoreHTTPSErrors", "should work with mixed content")]`
	`33`	`+ [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "ignoreHTTPSErrors", "should work with mixed content")]`
`34`	`34`	`public async Task ShouldWorkWithMixedContent()`
`35`	`35`	`{`
`36`	`36`	`HttpsServer.SetRoute("/mixedcontent.html", async (context) =>`
Original file line number	Diff line number	Diff line change
`@@ -13,10 +13,10 @@ public class ResponseSecurityDetailsTests : PuppeteerPageBaseTest`
`13`	`13`	`public ResponseSecurityDetailsTests() : base()`
`14`	`14`	`{`
`15`	`15`	`DefaultOptions = TestConstants.DefaultBrowserOptions();`
`16`		`- DefaultOptions.IgnoreHTTPSErrors = true;`
	`16`	`+ DefaultOptions.AcceptInsecureCerts = true;`
`17`	`17`	`}`
`18`	`18`
`19`		`- [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "Response.securityDetails", "Should Work")]`
	`19`	`+ [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "Response.securityDetails", "Should Work")]`
`20`	`20`	`public async Task ShouldWork()`
`21`	`21`	`{`
`22`	`22`	`// Checking for the TLS socket is it is in upstreams proves to be flaky in .net framework.`
`@@ -28,14 +28,14 @@ public async Task ShouldWork()`
`28`	`28`	`Assert.That(response.SecurityDetails.Protocol, Does.Contain("TLS"));`
`29`	`29`	`}`
`30`	`30`
`31`		`- [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "Response.securityDetails", "should be \|null\| for non-secure requests")]`
	`31`	`+ [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "Response.securityDetails", "should be \|null\| for non-secure requests")]`
`32`	`32`	`public async Task ShouldBeNullForNonSecureRequests()`
`33`	`33`	`{`
`34`	`34`	`var response = await Page.GoToAsync(TestConstants.EmptyPage);`
`35`	`35`	`Assert.That(response.SecurityDetails, Is.Null);`
`36`	`36`	`}`
`37`	`37`
`38`		`- [Test, Retry(2), PuppeteerTest("ignorehttpserrors.spec", "Response.securityDetails", "Network redirects should report SecurityDetails")]`
	`38`	`+ [Test, Retry(2), PuppeteerTest("acceptInsecureCerts.spec", "Response.securityDetails", "Network redirects should report SecurityDetails")]`
`39`	`39`	`[Ignore("This is super flaky")]`
`40`	`40`	`public async Task NetworkRedirectsShouldReportSecurityDetails()`
`41`	`41`	`{`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public async Task ShouldSupportIgnoreHTTPSErrorsOption()`
`54`	`54`	`await using var browser = await Puppeteer.ConnectAsync(new ConnectOptions`
`55`	`55`	`{`
`56`	`56`	`BrowserWSEndpoint = originalBrowser.WebSocketEndpoint,`
`57`		`- IgnoreHTTPSErrors = true`
	`57`	`+ AcceptInsecureCerts = true`
`58`	`58`	`});`
`59`	`59`	`await using var page = await browser.NewPageAsync();`
`60`	`60`	`var requestTask = HttpsServer.WaitForRequest(`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public class PuppeteerLaunchTests : PuppeteerBaseTest`
`18`	`18`	`public async Task ShouldWorkInRealLife()`
`19`	`19`	`{`
`20`	`20`	`var options = TestConstants.DefaultBrowserOptions();`
`21`		`- options.IgnoreHTTPSErrors = true;`
	`21`	`+ options.AcceptInsecureCerts = true;`
`22`	`22`
`23`	`23`	`await using var browser = await Puppeteer.LaunchAsync(options, TestConstants.LoggerFactory);`
`24`	`24`	`await using var page = await browser.NewPageAsync();`