Typing emoji (#624)

* Progress

* Feature complete

* cr

* cr

* cr

Author: kblok

lib/PuppeteerSharp.Tests/InputTests/InputTests.cs

@@ -595,5 +595,28 @@ public async Task ShouldThrowOnUnknownKeys()
 
             await Assert.ThrowsAsync<KeyNotFoundException>(() => Page.Keyboard.PressAsync("😊"));
         }
+
+        [Fact]
+        public async Task ShouldTypeEmoji()
+        {
+            await Page.GoToAsync(TestConstants.ServerUrl + "/input/textarea.html");
+            await Page.TypeAsync("textarea", "👹 Tokyo street Japan \uD83C\uDDEF\uD83C\uDDF5");
+            Assert.Equal(
+                "👹 Tokyo street Japan \uD83C\uDDEF\uD83C\uDDF5",
+                await Page.QuerySelectorAsync("textarea").EvaluateFunctionAsync<string>("t => t.value"));
+        }
+
+        [Fact]
+        public async Task ShouldTypeEmojiIntoAniframe()
+        {
+            await Page.GoToAsync(TestConstants.EmptyPage);
+            await FrameUtils.AttachFrameAsync(Page, "emoji-test", TestConstants.ServerUrl + "/input/textarea.html");
+            var frame = Page.Frames[1];
+            var textarea = await frame.QuerySelectorAsync("textarea");
+            await textarea.TypeAsync("👹 Tokyo street Japan \uD83C\uDDEF\uD83C\uDDF5");
+            Assert.Equal(
+                "👹 Tokyo street Japan \uD83C\uDDEF\uD83C\uDDF5",
+                await frame.QuerySelectorAsync("textarea").EvaluateFunctionAsync<string>("t => t.value"));
+        }
     }
 }

lib/PuppeteerSharp/Input/Keyboard.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Globalization;
 using System.Threading.Tasks;
 
 namespace PuppeteerSharp.Input
@@ -41,7 +42,8 @@ public Task DownAsync(string key, DownOptions options = null)
 
             var text = options?.Text == null ? description.Text : options.Text;
 
-            return _client.SendAsync("Input.dispatchKeyEvent", new Dictionary<string, object>(){
+            return _client.SendAsync("Input.dispatchKeyEvent", new Dictionary<string, object>
+            {
                 {"type", text != null ? "keyDown" : "rawKeyDown"},
                 {"modifiers", Modifiers},
                 {"windowsVirtualKeyCode", description.KeyCode},
@@ -67,7 +69,8 @@ public Task UpAsync(string key)
             Modifiers &= ~ModifierBit(key);
             _pressedKeys.Remove(description.Code);
 
-            return _client.SendAsync("Input.dispatchKeyEvent", new Dictionary<string, object>(){
+            return _client.SendAsync("Input.dispatchKeyEvent", new Dictionary<string, object>
+            {
                 {"type", "keyUp"},
                 {"modifiers", Modifiers},
                 {"key", description.Key},
@@ -83,15 +86,7 @@ public Task UpAsync(string key)
         /// <param name="charText">Character to send into the page</param>
         /// <returns>Task</returns>
         public Task SendCharacterAsync(string charText)
-        {
-            return _client.SendAsync("Input.dispatchKeyEvent", new Dictionary<string, object>(){
-                {"type", "char"},
-                {"modifiers", Modifiers},
-                {"text", charText },
-                {"key", charText},
-                {"unmodifiedText", charText }
-            });
-        }
+            => _client.SendAsync("Input.insertText", new Dictionary<string, object> { ["text"] = charText });
 
         /// <summary>
         /// Sends a <c>keydown</c>, <c>keypress</c>/<c>input</c>, and <c>keyup</c> event for each character in the text.
@@ -109,8 +104,11 @@ public async Task TypeAsync(string text, TypeOptions options = null)
             {
                 delay = (int)options.Delay;
             }
-            foreach (var letter in text)
+
+            var textParts = StringInfo.GetTextElementEnumerator(text);
+            while (textParts.MoveNext())
             {
+                var letter = textParts.Current;
                 if (KeyDefinitions.ContainsKey(letter.ToString()))
                 {
                     await PressAsync(letter.ToString(), new PressOptions { Delay = delay }).ConfigureAwait(false);