Improve waiting for selector to be hidden error message (#635)

* Improve waiting for selector to be hidden error message

* cr

Author: kblok

lib/PuppeteerSharp.Tests/FrameTests/WaitForSelectorTests.cs

@@ -178,10 +178,19 @@ public async Task ShouldRespectTimeout()
             var exception = await Assert.ThrowsAsync<WaitTaskTimeoutException>(async ()
                 => await Page.WaitForSelectorAsync("div", new WaitForSelectorOptions { Timeout = 10 }));
 
-            Assert.NotNull(exception);
             Assert.Contains("waiting for selector 'div' failed: timeout", exception.Message);
         }
 
+        [Fact]
+        public async Task ShouldHaveAnErrorMessageSpecificallyForAwaitingAnElementToBeHidden()
+        {
+            await Page.SetContentAsync("<div></div>");
+            var exception = await Assert.ThrowsAsync<WaitTaskTimeoutException>(async ()
+                => await Page.WaitForSelectorAsync("div", new WaitForSelectorOptions { Hidden = true, Timeout = 10 }));
+
+            Assert.Contains("waiting for selector 'div' to be hidden failed: timeout", exception.Message);
+        }
+
         [Fact]
         public async Task ShouldRespondToNodeAttributeMutation()
         {

lib/PuppeteerSharp/Frame.cs

@@ -547,7 +547,7 @@ function hasVisibleBoundingBox() {
                 this,
                 predicate,
                 false,
-                $"{(isXPath ? "XPath" : "selector")} '{selectorOrXPath}'",
+                $"{(isXPath ? "XPath" : "selector")} '{selectorOrXPath}'{(options.Hidden ? " to be hidden" : "")}",
                 options.Polling,
                 options.PollingInterval,
                 options.Timeout,
@@ -557,7 +557,7 @@ function hasVisibleBoundingBox() {
                     isXPath,
                     options.Visible,
                     options.Hidden
-            }).Task.ConfigureAwait(false);
+                }).Task.ConfigureAwait(false);
             return handle as ElementHandle;
         }