Await handle on disposal (#2699)

kblok · web-flow · commit e4528ad7f65a · 2024-07-18T09:53:31.000-03:00
diff --git a/lib/PuppeteerSharp/Cdp/CdpElementHandle.cs b/lib/PuppeteerSharp/Cdp/CdpElementHandle.cs
@@ -144,18 +144,17 @@ await handle.Client.SendAsync(
             });
 
     /// <inheritdoc />
-    public override ValueTask DisposeAsync()
+    public override async ValueTask DisposeAsync()
     {
         if (Disposed)
         {
-            return default;
+            return;
         }
 
         Disposed = true;
 
-        Handle.DisposeAsync();
+        await Handle.DisposeAsync().ConfigureAwait(false);
         GC.SuppressFinalize(this);
-        return default;
     }
 
     /// <inheritdoc />

Original file line number	Diff line number	Diff line change
`@@ -144,18 +144,17 @@ await handle.Client.SendAsync(`
`144`	`144`	`});`
`145`	`145`
`146`	`146`	`/// <inheritdoc />`
`147`		`- public override ValueTask DisposeAsync()`
	`147`	`+ public override async ValueTask DisposeAsync()`
`148`	`148`	`{`
`149`	`149`	`if (Disposed)`
`150`	`150`	`{`
`151`		`- return default;`
	`151`	`+ return;`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`Disposed = true;`
`155`	`155`
`156`		`- Handle.DisposeAsync();`
	`156`	`+ await Handle.DisposeAsync().ConfigureAwait(false);`
`157`	`157`	`GC.SuppressFinalize(this);`
`158`		`- return default;`
`159`	`158`	`}`
`160`	`159`
`161`	`160`	`/// <inheritdoc />`