Skip to content

Commit e5c4b25

Browse files
authored
Increase test session timeout to 45 minutes (#2290)
* Increase test session timeout to 45 minutes * Run on runsettings change * Ignore flaky test
1 parent 929d1a6 commit e5c4b25

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/workflows/dotnet.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ on:
1212
- '**.yml'
1313
- '**.cs'
1414
- '**.csproj'
15+
- '**.runsettings'
1516

1617
env:
1718
DOTNET_VERSION: '6.0.x' # The .NET SDK version to use

lib/PuppeteerSharp.Tests/IgnoreHttpsErrorsTests/ResponseSecurityDetailsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public async Task ShouldBeNullForNonSecureRequests()
4141
}
4242

4343
[PuppeteerTest("ignorehttpserrors.spec.ts", "Response.securityDetails", "Network redirects should report SecurityDetails")]
44-
[Skip(SkipAttribute.Targets.Firefox)]
44+
[Ignore("This is super flaky")]
4545
public async Task NetworkRedirectsShouldReportSecurityDetails()
4646
{
4747
var responses = new List<IResponse>();

lib/PuppeteerSharp.Tests/test.runsettings

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
<RunSettings>
33
<!-- Configurations that affect the Test Framework -->
44
<RunConfiguration>
5-
<TestSessionTimeout>1800000</TestSessionTimeout>
5+
<TestSessionTimeout>2700000</TestSessionTimeout>
66
</RunConfiguration>
77
</RunSettings>

0 commit comments

Comments
 (0)