Unflake tests

Author: kblok

lib/PuppeteerSharp.Tests/DefaultBrowserContextTests/BrowserTargetEventsTests.cs

@@ -21,15 +21,13 @@ public async Task ShouldWork()
         {
             using var browser = await Puppeteer.LaunchAsync(TestConstants.DefaultBrowserOptions());
 
-            // .NET has a race here where we get the target created of the default page.
-            // We will wait for the new page before moving on.
-            await Task.Delay(500);
+            var page = await browser.NewPageAsync();
             await browser.PagesAsync();
             var events = new List<string>();
             browser.TargetCreated += (_, _) => events.Add("CREATED");
             browser.TargetChanged += (_, _) => events.Add("CHANGED");
             browser.TargetDestroyed += (_, _) => events.Add("DESTROYED");
-            var page = await browser.NewPageAsync();
+            page = await browser.NewPageAsync();
             await page.GoToAsync(TestConstants.EmptyPage);
             await page.CloseAsync();
 

lib/PuppeteerSharp.Tests/LauncherTests/DefaultBrowserContextTests.cs

@@ -19,11 +19,16 @@ public BrowserTargetEventsTests(): base()
         [Skip(SkipAttribute.Targets.Firefox)]
         public async Task ShouldWork()
         {
+            using var browser = await Puppeteer.LaunchAsync(TestConstants.DefaultBrowserOptions());
             var events = new List<string>();
+            // This new page is not in upstream but we use to to wait for the browser to be ready
+            // If we don't do this the first event we get is the target of the about:blank page
+            var page = await browser.NewPageAsync();
+
             Browser.TargetCreated += (_, _) => events.Add("CREATED");
             Browser.TargetChanged += (_, _) => events.Add("CHANGED");
             Browser.TargetDestroyed += (_, _) => events.Add("DESTROYED");
-            var page = await Browser.NewPageAsync();
+            page = await Browser.NewPageAsync();
             await page.GoToAsync(TestConstants.EmptyPage);
             await page.CloseAsync();
             Assert.AreEqual(new[] { "CREATED", "CHANGED", "DESTROYED" }, events);