Use source generated regexes where appropriate (#2927)

Author: IliaBrahinets

lib/PuppeteerSharp/Cdp/CdpHttpResponse.cs

@@ -8,9 +8,11 @@
 namespace PuppeteerSharp.Cdp;
 
 /// <inheritdoc/>
-public class CdpHttpResponse : Response<CdpHttpRequest>
+public partial class CdpHttpResponse : Response<CdpHttpRequest>
 {
+#if NETSTANDARD2_0
     private static readonly Regex _extraInfoLines = new(@"[^ ]* [^ ]* (?<text>.*)", RegexOptions.Multiline);
+#endif
     private readonly CDPSession _client;
     private readonly bool _fromDiskCache;
     private byte[] _buffer;
@@ -82,6 +84,13 @@ public override async ValueTask<byte[]> BufferAsync()
         return _buffer;
     }
 
+#if NET8_0_OR_GREATER
+    [GeneratedRegex(@"[^ ]* [^ ]* (?<text>.*)", RegexOptions.Multiline)]
+    private static partial Regex GetExtraInfoLines();
+#else
+    private static Regex GetExtraInfoLines() => _extraInfoLines;
+#endif
+
     private string ParseStatusTextFromExtraInfo(ResponseReceivedExtraInfoResponse extraInfo)
     {
         if (extraInfo == null || extraInfo.HeadersText == null)
@@ -97,7 +106,7 @@ private string ParseStatusTextFromExtraInfo(ResponseReceivedExtraInfoResponse ex
 
         var firstLine = lines[0];
 
-        var match = _extraInfoLines.Match(firstLine);
+        var match = GetExtraInfoLines().Match(firstLine);
         if (!match.Success)
         {
             return null;

lib/PuppeteerSharp/ExecutionContext.cs

@@ -12,12 +12,16 @@
 namespace PuppeteerSharp
 {
     /// <inheritdoc cref="IExecutionContext"/>
-    public sealed class ExecutionContext : IExecutionContext, IDisposable, IAsyncDisposable
+    public sealed partial class ExecutionContext : IExecutionContext, IDisposable, IAsyncDisposable
     {
         internal const string EvaluationScriptUrl = "__puppeteer_evaluation_script__";
         private const string EvaluationScriptSuffix = $"//# sourceURL={EvaluationScriptUrl}";
 
-        private static readonly Regex _sourceUrlRegex = new(@"^[\040\t]*\/\/[@#] sourceURL=\s*\S*?\s*$", RegexOptions.Multiline);
+#if NETSTANDARD2_0
+        private static readonly Regex _sourceUrlRegex =
+            new(@"^[\040\t]*\/\/[@#] sourceURL=\s*\S*?\s*$", RegexOptions.Multiline);
+#endif
+
         private readonly TaskQueue _puppeteerUtilQueue = new();
         private IJSHandle _puppeteerUtil;
 
@@ -128,6 +132,13 @@ internal IJSHandle CreateJSHandle(RemoteObject remoteObject)
                 ? new CdpElementHandle(World, remoteObject)
                 : new CdpJSHandle(World, remoteObject);
 
+#if NET8_0_OR_GREATER
+        [GeneratedRegex(@"^[\040\t]*\/\/[@#] sourceURL=\s*\S*?\s*$", RegexOptions.Multiline)]
+        private static partial Regex GetSourceUrlRegex();
+#else
+        private static Regex GetSourceUrlRegex() => _sourceUrlRegex;
+#endif
+
         private static string GetExceptionMessage(EvaluateExceptionResponseDetails exceptionDetails)
         {
             if (exceptionDetails.Exception != null)
@@ -179,7 +190,7 @@ private async Task<T> RemoteObjectTaskToObject<T>(Task<RemoteObject> remote)
         private Task<RemoteObject> EvaluateExpressionInternalAsync(bool returnByValue, string script)
             => ExecuteEvaluationAsync("Runtime.evaluate", new Dictionary<string, object>
             {
-                ["expression"] = _sourceUrlRegex.IsMatch(script) ? script : $"{script}\n{EvaluationScriptSuffix}",
+                ["expression"] = GetSourceUrlRegex().IsMatch(script) ? script : $"{script}\n{EvaluationScriptSuffix}",
                 ["contextId"] = ContextId,
                 ["returnByValue"] = returnByValue,
                 ["awaitPromise"] = true,

lib/PuppeteerSharp/QueryHandlers/AriaQueryHandler.cs

@@ -8,11 +8,13 @@
 
 namespace PuppeteerSharp.QueryHandlers
 {
-    internal class AriaQueryHandler : QueryHandler
+    internal partial class AriaQueryHandler : QueryHandler
     {
-        private static readonly Regex _ariaSelectorAttributeRegEx = new(
+#if NETSTANDARD2_0
+        private static readonly Regex _ariaSelectorAttributeRegex = new(
             """\[\s*(?<attribute>\w+)\s*=\s*(?<quote>"|')(?<value>\\.|.*?(?=\k<quote>))\k<quote>\s*\]""",
             RegexOptions.Compiled);
+#endif
 
         private static readonly string[] _nonElementNodeRoles = { "StaticText", "InlineTextBox" };
 
@@ -77,7 +79,7 @@ private static AriaQueryOption ParseAriaSelector(string selector)
         {
             var knownAriaAttributes = new[] { "name", "role" };
             AriaQueryOption queryOptions = new();
-            var defaultName = _ariaSelectorAttributeRegEx.Replace(selector, match =>
+            var defaultName = GetAriaSelectorAttributeRegex().Replace(selector, match =>
             {
                 var attribute = match.Groups["attribute"].Value;
                 if (!knownAriaAttributes.Contains(attribute))
@@ -104,5 +106,12 @@ private static AriaQueryOption ParseAriaSelector(string selector)
 
             return queryOptions;
         }
+
+#if NET8_0_OR_GREATER
+        [GeneratedRegex("""\[\s*(?<attribute>\w+)\s*=\s*(?<quote>"|')(?<value>\\.|.*?(?=\k<quote>))\k<quote>\s*\]""")]
+        private static partial Regex GetAriaSelectorAttributeRegex();
+#else
+        private static Regex GetAriaSelectorAttributeRegex() => _ariaSelectorAttributeRegex;
+#endif
     }
 }