Page.ClickAsync should work with disabled javascript (#636)

* Page.ClickAsync should work with disabled javascript

* Ops

Author: kblok

lib/PuppeteerSharp.Tests/InputTests/InputTests.cs

@@ -33,6 +33,18 @@ public async Task ShouldClickTheButton()
             Assert.Equal("Clicked", await Page.EvaluateExpressionAsync<string>("result"));
         }
 
+        [Fact]
+        public async Task ShouldClickWithDisabledJavascript()
+        {
+            await Page.SetJavaScriptEnabledAsync(false);
+            await Page.GoToAsync(TestConstants.ServerUrl + "/wrappedlink.html");
+            await Task.WhenAll(
+                Page.ClickAsync("a"),
+                Page.WaitForNavigationAsync()
+            );
+            Assert.Equal(TestConstants.ServerUrl + "/wrappedlink.html#clicked", Page.Url);
+        }
+
         [Fact]
         public async Task ShouldClickOffscreenButtons()
         {

lib/PuppeteerSharp/ElementHandle.cs

@@ -457,11 +457,16 @@ public Task<bool> IsIntersectingViewportAsync()
 
         private async Task ScrollIntoViewIfNeededAsync()
         {
-            var errorMessage = await ExecutionContext.EvaluateFunctionAsync<string>(@" async element => {
+            var errorMessage = await ExecutionContext.EvaluateFunctionAsync<string>(@"async(element, pageJavascriptEnabled) => {
               if (!element.isConnected)
                 return 'Node is detached from document';
               if (element.nodeType !== Node.ELEMENT_NODE)
                 return 'Node is not of type HTMLElement';
+              // force-scroll if page's javascript is disabled.
+              if (!pageJavascriptEnabled) {
+                element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+                return false;
+              }
               const visibleRatio = await new Promise(resolve => {
                 const observer = new IntersectionObserver(entries => {
                   resolve(entries[0].intersectionRatio);
@@ -472,7 +477,7 @@ private async Task ScrollIntoViewIfNeededAsync()
               if (visibleRatio !== 1.0)
                 element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
               return false;
-            }", this).ConfigureAwait(false);
+            }", this, Page.JavascriptEnabled).ConfigureAwait(false);
 
             if (errorMessage != null)
             {

lib/PuppeteerSharp/Page.cs

@@ -304,6 +304,7 @@ private Page(
         /// </summary>
         public bool IsClosed { get; private set; }
 
+        internal bool JavascriptEnabled { get; set; } = true;
         #endregion
 
         #region Public Methods
@@ -893,7 +894,14 @@ public async Task<byte[]> PdfDataAsync(PdfOptions options)
         /// <returns>Task.</returns>
         /// <param name="enabled">Whether or not to enable JavaScript on the page.</param>
         public Task SetJavaScriptEnabledAsync(bool enabled)
-            => Client.SendAsync("Emulation.setScriptExecutionDisabled", new { value = !enabled });
+        {
+            if (enabled == JavascriptEnabled)
+            {
+                return Task.CompletedTask;
+            }
+            JavascriptEnabled = enabled;
+            return Client.SendAsync("Emulation.setScriptExecutionDisabled", new { value = !enabled });
+        }
 
         /// <summary>
         /// Toggles bypassing page's Content-Security-Policy.