Frame/FrameManager and Page redirect fixes (#102)

Several bug fixes on Frame and FrameManager
Fixed duplicated requests on Page

Author: kblok

lib/PuppeteerSharp.Tests/Issues/Issue0100.cs

@@ -0,0 +1,32 @@
+using System;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace PuppeteerSharp.Tests.Issues
+{
+    [Collection("PuppeteerLoaderFixture collection")]
+    public class Issue0100 : PuppeteerBaseTest
+    {
+        [Fact]
+        public async Task PdfWundergroundShouldWork()
+        {
+            using (var page = await Browser.NewPageAsync())
+            {
+                var response = await page.GoToAsync("https://www.wunderground.com/weather/be/antwerp");
+                var pdf = await page.PdfStreamAsync();
+                Assert.NotNull(pdf);
+            }
+        }
+
+        [Fact]
+        public async Task PdfDarkskyShouldWork()
+        {
+            using (var page = await Browser.NewPageAsync())
+            {
+                await page.GoToAsync("https://darksky.net/forecast/51.2211,4.3997/si12/en");
+                var pdf = await page.PdfStreamAsync();
+                Assert.NotNull(pdf);
+            }
+        }
+    }
+}

lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj

@@ -15,6 +15,7 @@
   </ItemGroup>
   <ItemGroup>
     <Folder Include="Puppeteer\" />
+    <Folder Include="Issues\" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\PuppeteerSharp\PuppeteerSharp.csproj" />

lib/PuppeteerSharp/Frame.cs

@@ -10,7 +10,6 @@ public class Frame
         private Session _client;
         private Page _page;
         private Frame _parentFrame;
-        private string _id;
         private string _defaultContextId = "<not-initialized>";
         private object _context = null;
         private string _url = string.Empty;
@@ -22,7 +21,7 @@ public Frame(Session client, Page page, Frame parentFrame, string frameId)
             _client = client;
             _page = page;
             _parentFrame = parentFrame;
-            _id = frameId;
+            Id = frameId;
 
             if (parentFrame != null)
             {

lib/PuppeteerSharp/FrameManager.cs

@@ -45,7 +45,7 @@ void _client_MessageReceived(object sender, PuppeteerSharp.MessageEventArgs e)
             switch (e.MessageID)
             {
                 case "Page.frameAttached":
-                    OnFrameAttached(e.MessageData.frameId.ToString(), e.MessageData.parentFrameId);
+                    OnFrameAttached(e.MessageData.frameId.ToString(), e.MessageData.parentFrameId.ToString());
                     break;
 
                 case "Page.frameNavigated":
@@ -149,9 +149,9 @@ private void OnFrameNavigated(FramePayload framePayload)
             // Detach all child frames first.
             if (frame != null)
             {
-                foreach (var child in frame.ChildFrames)
+                while (frame.ChildFrames.Count > 0)
                 {
-                    RemoveFramesRecursively(child);
+                    RemoveFramesRecursively(frame.ChildFrames[0]);
                 }
             }
 
@@ -195,9 +195,9 @@ private void RemoveContext(ExecutionContext context)
 
         private void RemoveFramesRecursively(Frame frame)
         {
-            foreach (var child in frame.ChildFrames)
+            while (frame.ChildFrames.Count > 0)
             {
-                RemoveFramesRecursively(child);
+                RemoveFramesRecursively(frame.ChildFrames[0]);
             }
             frame.Detach();
             Frames.Remove(frame.Id);

lib/PuppeteerSharp/Page.cs

@@ -272,7 +272,12 @@ public async Task<dynamic> GoToAsync(string url, Dictionary<string, string> opti
             var requests = new Dictionary<string, Request>();
 
             EventHandler<RequestEventArgs> createRequestEventListener = (object sender, RequestEventArgs e) =>
-                requests.Add(e.Request.Url, e.Request);
+            {
+                if (!requests.ContainsKey(e.Request.Url))
+                {
+                    requests.Add(e.Request.Url, e.Request);
+                }
+            };
 
             _networkManager.RequestCreated += createRequestEventListener;
 
@@ -679,22 +684,19 @@ private async Task OnCertificateError(MessageEventArgs e)
 
         private void HandleException(string exceptionDetails)
         {
-            throw new NotImplementedException();
         }
 
         private void OnDialog(MessageEventArgs e)
         {
-            throw new NotImplementedException();
         }
 
         private void OnConsoleAPI(MessageEventArgs e)
         {
-            throw new NotImplementedException();
         }
 
         private Task ReloadAsync()
         {
-            throw new NotImplementedException();
+            return null;
         }