Skip to content

Commit 018f2a3

Browse files
committed
optimize js navigate method
1 parent 1a771f8 commit 018f2a3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

devdocs_desktop.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,6 @@ def on_header_search_entry_search_changed(self, widget):
359359

360360
def on_menu_main_link_clicked(self, widget):
361361
link = Gtk.Buildable.get_name(widget).split('_')[-1]
362-
link = link.replace('home', '')
363-
364362
self.run_javascript('navigate', link)
365363

366364
def on_header_button_save_clicked(self, _widget):
@@ -373,7 +371,7 @@ def on_apply_button_visibility(self, visible):
373371
self.run_javascript('click', 'saveButton')
374372
else:
375373
self.header_title.set_label('Saving...')
376-
self.run_javascript('navigate', '')
374+
self.run_javascript('navigate', 'home')
377375

378376
def on_finder_search_entry_map(self, _widget):
379377
self.finder_search.grab_focus()

scripts/webview.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ class DevDocsDesktop {
8282
}
8383

8484
navigate(path) {
85-
const element = this.query(`a[href="/${path}"]`)
85+
const pathKey = path.replace('home', '')
86+
const element = this.query(`a[href="/${pathKey}"]`)
87+
8688
element && element.click()
8789
}
8890
}

0 commit comments

Comments
 (0)