optimize search term/filter sync with webview

Author: jonian

devdocs_desktop.py

@@ -222,24 +222,19 @@ def set_window_accel_groups(self):
 
     self.window.add_accel_group(group)
 
-  def update_header_filter(self, text):
-    filter_exists = bool(text.strip())
-    self.header_filter.set_visible(filter_exists)
+  def sync_header_search(self):
+    self.js_element_value('._search-tag', self.update_header_filter)
+    self.js_element_value('._search-input', self.update_header_search)
 
-    if filter_exists:
-      self.filter = text.strip()
+  def update_header_filter(self, text):
+    if text != self.filter:
+      self.filter = text
       self.header_filter.set_label(text)
-      self.reset_header_search()
-    else:
-      self.filter = ''
+      self.header_filter.set_visible(bool(text))
 
-  def reset_header_filter(self, value=''):
-    if not bool(value.strip()):
-      self.update_header_filter('')
-
-  def reset_header_search(self, value=''):
-    if not bool(value.strip()):
-      self.header_search.set_text('')
+  def update_header_search(self, text):
+    if text != self.search:
+      self.header_search.set_text(text)
 
   def on_cookies_changed(self, _manager):
     self.retrieve_cookies_values()
@@ -309,7 +304,7 @@ def on_window_main_key_press_event(self, _widget, event):
 
     if kname == 'Tab' and bool(self.search) and search:
       self.js_keyboard_event('._search', 9)
-      self.js_element_value('._search-tag', self.update_header_filter)
+      self.sync_header_search()
 
       return True
 
@@ -318,7 +313,7 @@ def on_header_search_entry_key_press_event(self, _widget, event):
 
     if kname == 'BackSpace' and not bool(self.search):
       self.js_keyboard_event('._search', 8)
-      self.js_element_value('._search-tag', self.update_header_filter)
+      self.sync_header_search()
 
   def on_header_search_entry_key_release_event(self, _widget, event):
     kname = Gdk.keyval_name(event.keyval)
@@ -420,9 +415,7 @@ def on_webview_title_changed(self, _widget, _title):
   def on_webview_uri_changed(self, _widget, _uri):
     save = self.webview.get_uri().endswith('settings')
     self.toggle_save_button(save)
-
-    self.js_element_value('._search-input', self.reset_header_search)
-    self.js_element_value('._search-tag', self.reset_header_filter)
+    self.sync_header_search()
 
   def on_history_changed(self, _list, _added, _removed):
     back = self.webview.can_go_back()