Skip to content

Commit 6dfd27f

Browse files
authored
Task 63: Remove SecBundle and SecCertificate deletes (rdkcentral#64)
Remove secapi2-adapter's deletion of certificates and bundles stored in a file system to avoid data synchronization issues encountered with applications running in containers. The issue manifests as missing data when an existing certificate file is updated outside of the container. This is due to the file system inode changing on writing a new file. Update the existing file without deleting the data prior to update maintains the inode and preserve the ability for the containerized application to access the new data. Update version numbers as required by release team.
1 parent 5c34961 commit 6dfd27f

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ add_library(sec_api SHARED
141141
set_target_properties(sec_api PROPERTIES
142142
LINKER_LANGUAGE C
143143
SO_VERSION 2.4
144-
VERSION 2.4.1.0
144+
VERSION 2.4.2.0
145145
)
146146

147147
target_compile_options(sec_api PRIVATE -Wno-deprecated-declarations)

include/sec_version.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2020-2022 Comcast Cable Communications Management, LLC
2+
* Copyright 2020-2025 Comcast Cable Communications Management, LLC
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,4 +16,4 @@
1616
* SPDX-License-Identifier: Apache-2.0
1717
*/
1818

19-
#define SEC_API_VERSION "2.4.1.0"
19+
#define SEC_API_VERSION "2.4.2.0"

src/sec_adapter_bundle.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2020-2022 Comcast Cable Communications Management, LLC
2+
* Copyright 2020-2025 Comcast Cable Communications Management, LLC
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -123,8 +123,6 @@ static Sec_Result Sec_StoreBundleData(Sec_ProcessorHandle* processorHandle, SEC_
123123
return SEC_RESULT_FAILURE;
124124
}
125125

126-
SecBundle_Delete(processorHandle, object_id);
127-
128126
char file_name_bundle[SEC_MAX_FILE_PATH_LEN];
129127
char file_name_verification[SEC_MAX_FILE_PATH_LEN];
130128
snprintf(file_name_bundle, sizeof(file_name_bundle), "%s" SEC_BUNDLE_FILENAME_PATTERN, processorHandle->app_dir,

src/sec_adapter_certificate.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2020-2022 Comcast Cable Communications Management, LLC
2+
* Copyright 2020-2025 Comcast Cable Communications Management, LLC
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -223,8 +223,6 @@ static Sec_Result Sec_StoreCertificateData(Sec_ProcessorHandle* processorHandle,
223223
return SEC_RESULT_FAILURE;
224224
}
225225

226-
SecCertificate_Delete(processorHandle, object_id);
227-
228226
char file_name_cert[SEC_MAX_FILE_PATH_LEN];
229227
char file_name_info[SEC_MAX_FILE_PATH_LEN];
230228
char file_name_verification[SEC_MAX_FILE_PATH_LEN];

0 commit comments

Comments
 (0)