feat: [IAC-5075]: fix ling issues

supritbeck-harness · supritbeck-harness · commit a0eabfab6dc1 · 2025-12-25T14:28:36.000+05:30
diff --git a/plugins/harness-iacm/src/components/WorkspaceList/ResourceDetailDrawer/AttributeList.tsx b/plugins/harness-iacm/src/components/WorkspaceList/ResourceDetailDrawer/AttributeList.tsx
@@ -55,13 +55,13 @@ const AttributeList: React.FC<AttributeListProps> = ({
               <Box className={classes.valueComparison}>
                 <ValueDisplay
                   value={driftValue}
-                  isDrift={true}
+                  isDrift
                   label="Actual Value:"
                   copyTopOffset="25px"
                 />
                 <ValueDisplay
                   value={item.value}
-                  isDrift={true}
+                  isDrift
                   label="Expected Value:"
                   copyTopOffset="25px"
                 />
diff --git a/plugins/harness-iacm/src/components/WorkspaceList/ResourceDetailDrawer/DriftIcon.tsx b/plugins/harness-iacm/src/components/WorkspaceList/ResourceDetailDrawer/DriftIcon.tsx
@@ -1,18 +1,18 @@
 import React from 'react';
-import ReplayCircleFilledIcon from '@mui/icons-material/ReplayCircleFilled';
+import ReplayIcon from '@material-ui/icons/Replay';
 import DeleteIcon from '@material-ui/icons/Delete';
-import CircleIcon from '@mui/icons-material/Circle';
+import LensIcon from '@material-ui/icons/Lens';
 
 export const getDriftIcon = (driftStatus?: string): React.ReactNode => {
   switch (driftStatus?.toLowerCase()) {
     case 'drifted':
-      return <ReplayCircleFilledIcon style={{ fontSize: 18, color: '#ff9800' }} />;
+      return <ReplayIcon style={{ fontSize: 18, color: '#ff9800' }} />;
     case 'changed':
-        return <ReplayCircleFilledIcon style={{ fontSize: 18, color: '#ff9800' }} />;
+        return <ReplayIcon style={{ fontSize: 18, color: '#ff9800' }} />;
     case 'deleted':
       return <DeleteIcon style={{ fontSize: 18, color: '#9e9e9e' }} />;
     case 'unchanged':
-      return <CircleIcon style={{ fontSize: 18, color: '#9e9e9e' }} />;
+      return <LensIcon style={{ fontSize: 18, color: '#9e9e9e' }} />;
     default:
       return null;
   }
diff --git a/plugins/harness-iacm/src/components/WorkspaceList/ResourceDetailDrawer/index.tsx b/plugins/harness-iacm/src/components/WorkspaceList/ResourceDetailDrawer/index.tsx
@@ -20,7 +20,10 @@ const ResourceDetailDrawer: React.FC<ResourceDetailDrawerProps> = ({
   const [searchValue, setSearchValue] = useState('');
 
   const driftStatus = resource?.drift_status;
-  const driftAttributes = (resource as any)?.drift_attributes || {};
+  const driftAttributes = useMemo(
+    () => resource?.drift_attributes || {},
+    [resource]
+  );
   const isDeleted = driftStatus === 'deleted';
   const allDeleted = isDeleted && Object.keys(driftAttributes).length > 0;
   const headerIcon = driftStatus ? getDriftIcon(driftStatus) : null;
@@ -46,7 +49,7 @@ const ResourceDetailDrawer: React.FC<ResourceDetailDrawerProps> = ({
           {resource && (
             <>
               {/* Search Input - Sticky */}
-              <SearchField value={searchValue} onChange={setSearchValue} sticky />
+              <SearchField value={searchValue} onChange={setSearchValue} />
 
               {/* VALUE Header */}
               <Typography className={classes.valueHeader}>VALUE</Typography>
diff --git a/plugins/harness-iacm/src/components/WorkspaceList/index.tsx b/plugins/harness-iacm/src/components/WorkspaceList/index.tsx
@@ -71,9 +71,9 @@ export interface Workspace {
 }
 
 export enum WorkspaceDataType {
-  Resource,
-  DataSource,
-  Output,
+  ResourceType = 'Resource',
+  DataSourceType = 'DataSource',
+  OutputType = 'Output',
 }
 
 function WorkspaceList() {
@@ -96,7 +96,7 @@ function WorkspaceList() {
   const [page, setPage] = useState(0);
   const [pageSize, setPageSize] = useState(10);
   const [selectedTab, setSelectedTab] = React.useState<WorkspaceDataType>(
-    WorkspaceDataType.Resource,
+    WorkspaceDataType.ResourceType,
   );
   const [selectedRowData, setSelectedRowData] = useState<Resource | DataSource | null>(null);
 
@@ -106,7 +106,7 @@ function WorkspaceList() {
   const drawerTitle = useMemo(() => {
     const driftStatus = selectedRowData?.drift_status || '';
     const capitalizedStatus = driftStatus ? driftStatus.charAt(0).toUpperCase() + driftStatus.slice(1) : '';
-    return `${capitalizedStatus}  ${selectedTab === WorkspaceDataType.Resource ? 'Resources' : 'Data Sources'}`
+    return `${capitalizedStatus}  ${selectedTab === WorkspaceDataType.ResourceType ? 'Resources' : 'Data Sources'}`
   }, [selectedRowData, selectedTab]);
   const {
     projectId,
@@ -174,7 +174,7 @@ function WorkspaceList() {
   );
 
   const handleRowClick = useCallback((data:  Resource  | DataSource) => {
-    if(selectedTab === WorkspaceDataType.Output) return; //do not open drawer for outputs
+    if(selectedTab === WorkspaceDataType.OutputType) return; // do not open drawer for outputs
     setSelectedRowData(data);
   }, [selectedTab]);
 
@@ -266,9 +266,9 @@ function WorkspaceList() {
           onChange={handleChange}
           aria-label="workspace_list_tabs"
         >
-          <Tab label={`Resources (${resources?.length})`} />
-          <Tab label={`Data Sources (${dataSources?.length})`} />
-          <Tab label={`Outputs (${outputs?.length})`} />
+          <Tab label={`Resources (${resources?.length ?? 0})`} value={WorkspaceDataType.ResourceType} />
+          <Tab label={`Data Sources (${dataSources?.length ?? 0})`} value={WorkspaceDataType.DataSourceType} />
+          <Tab label={`Outputs (${outputs?.length ?? 0})`} value={WorkspaceDataType.OutputType} />
         </Tabs>
         <WorkspaceTable
           setRefresh={setRefresh}
@@ -287,7 +287,7 @@ function WorkspaceList() {
         />
       </div>
       <ResourceDetailDrawer
-        open={!!selectedRowData} //open drawer if there is selected row data
+        open={!!selectedRowData} // open drawer if there is selected row data
         resource={selectedRowData}
         onClose={handleDrawerClose}
         title={drawerTitle}
diff --git a/plugins/harness-iacm/src/components/WorkspaceList/useGetWorkspaceTableColumns.tsx b/plugins/harness-iacm/src/components/WorkspaceList/useGetWorkspaceTableColumns.tsx
@@ -1,5 +1,5 @@
 import { TableColumn } from '@backstage/core-components';
-import { Button, Link, Typography, makeStyles } from '@material-ui/core';
+import { Button, Typography, makeStyles } from '@material-ui/core';
 import React, { useMemo, useState } from 'react';
 import { TableData } from '../../types';
 
@@ -38,11 +38,7 @@ const useStyles = makeStyles(theme => ({
   },
 }));
 
-export const useGetWorkspaceTableColumns = ({
-  baseUrl,
-}: {
-  baseUrl: string;
-}) => {
+export const useGetWorkspaceTableColumns = () => {
   const classes = useStyles();
 
   const getProviderIcon = (name?: string): React.ReactNode => {
@@ -115,7 +111,7 @@ export const useGetWorkspaceTableColumns = ({
           (row1.module ?? '').localeCompare(row2.module ?? ''),
       },
     ],
-    [baseUrl, classes],
+    [classes],
   );
 
   const outputsColumns: TableColumn[] = useMemo(
diff --git a/plugins/harness-iacm/src/hooks/useGetResources.ts b/plugins/harness-iacm/src/hooks/useGetResources.ts
@@ -26,6 +26,9 @@ interface BaseResource {
     associate_public_ip_address: string;
     availability_zone: string;
   };
+  drift_attributes: {
+    [key: string]: string;
+  };
 }
 
 export interface Resource extends BaseResource {}
diff --git a/plugins/harness-iacm/src/utils/getWorkspaceData.ts b/plugins/harness-iacm/src/utils/getWorkspaceData.ts
@@ -12,11 +12,11 @@ export const getCurrTableData = (
   data: WorkspaceData,
 ): Resource[] | Output[] | DataSource[] => {
   switch (workspaceDataType) {
-    case WorkspaceDataType.Resource:
+    case WorkspaceDataType.ResourceType:
       return data.resources || [];
-    case WorkspaceDataType.DataSource:
+    case WorkspaceDataType.DataSourceType:
       return data.dataSources || [];
-    case WorkspaceDataType.Output:
+    case WorkspaceDataType.OutputType:
       return data.outputs || [];
     default:
       return [];
@@ -28,11 +28,11 @@ export const getTotalElements = (
   data: WorkspaceData,
 ): number => {
   switch (workspaceDataType) {
-    case WorkspaceDataType.Resource:
+    case WorkspaceDataType.ResourceType:
       return data.resources?.length || 0;
-    case WorkspaceDataType.DataSource:
+    case WorkspaceDataType.DataSourceType:
       return data.dataSources?.length || 0;
-    case WorkspaceDataType.Output:
+    case WorkspaceDataType.OutputType:
       return data.outputs?.length || 0;
     default:
       return 0;
diff --git a/plugins/harness-iacm/src/utils/getWorkspaceTableConfig.ts b/plugins/harness-iacm/src/utils/getWorkspaceTableConfig.ts
@@ -17,17 +17,17 @@ export const getWorkspaceTableConfig = (
   columns: WorkspaceColumns,
 ): WorkspaceTableConfig => {
   switch (workspaceDataType) {
-    case WorkspaceDataType.Resource:
+    case WorkspaceDataType.ResourceType:
       return {
         columns: columns.resourceColumns,
         title: 'Workspace Resources',
       };
-    case WorkspaceDataType.Output:
+    case WorkspaceDataType.OutputType:
       return {
         columns: columns.outputsColumns,
         title: 'Workspace Outputs',
       };
-    case WorkspaceDataType.DataSource:
+    case WorkspaceDataType.DataSourceType:
       return {
         columns: columns.dataSourceColumns,
         title: 'Workspace Data Sources',

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,9 @@ interface BaseResource {`
`26`	`26`	`associate_public_ip_address: string;`
`27`	`27`	`availability_zone: string;`
`28`	`28`	`};`
	`29`	`+ drift_attributes: {`
	`30`	`+ [key: string]: string;`
	`31`	`+ };`
`29`	`32`	`}`
`30`	`33`
`31`	`34`	`export interface Resource extends BaseResource {}`