FFM-11660 Test for safe maps

Author: erdirowlands

analyticsservice/analytics.go

@@ -65,7 +65,7 @@ type AnalyticsService struct {
 	analyticsChan             chan analyticsEvent
 	evaluationAnalytics       SafeAnalyticsCache[string, analyticsEvent]
 	targetAnalytics           SafeAnalyticsCache[string, evaluation.Target]
-	seenTargets               SafeAnalyticsCache[string, bool]
+	seenTargets               SafeSeenTargetsCache[string, bool]
 	logEvaluationLimitReached atomic.Bool
 	logTargetLimitReached     atomic.Bool
 	timeout                   time.Duration
@@ -162,8 +162,15 @@ func (as *AnalyticsService) listener() {
 			continue
 		}
 
+		// Check if seen targets limit has been hit
+		limitExceeded := as.seenTargets.isLimitExceeded()
+
+		if limitExceeded {
+			continue
+		}
+
 		// Update seen targets
-		as.seenTargets.set(ad.target.Identifier, true)
+		as.seenTargets.setWithLimit(ad.target.Identifier, true)
 
 		// Update target metrics
 		if as.targetAnalytics.size() < maxTargetEntries {

analyticsservice/safe_maps_test.go

@@ -5,6 +5,7 @@ import (
 	"reflect"
 	"sync"
 	"testing"
+	"time"
 
 	"github.com/harness/ff-golang-server-sdk/evaluation"
 )
@@ -172,4 +173,32 @@ func TestSafeSeenTargets(t *testing.T) {
 			t.Errorf("Map size should be 0 after clearing, got %d", s.size())
 		}
 	})
+
+	// Add test for clearing based on interval
+	t.Run("IntervalClearingTest", func(t *testing.T) {
+		// Re-initialize the map with a clearing interval
+		s = newSafeSeenTargets(10, 100*time.Millisecond)
+
+		for key, value := range testData {
+			s.set(key, value)
+		}
+
+		// Ensure the map has items initially
+		if s.size() != len(testData) {
+			t.Errorf("Expected map size to be %d, got %d", len(testData), s.size())
+		}
+
+		// Wait for the clearing to clear the map
+		time.Sleep(300 * time.Millisecond)
+
+		// Ensure the map is cleared after the interval
+		if s.size() != 0 {
+			t.Errorf("Expected map size to be 0 after clearing interval, got %d", s.size())
+		}
+
+		// Ensure the limitExceeded flag is reset
+		if s.isLimitExceeded() {
+			t.Errorf("Expected limitExceeded to be reset after clearing")
+		}
+	})
 }